Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124166/?format=api
{ "id": 124166, "url": "https://patches.dpdk.org/api/patches/124166/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230220060839.1267349-2-ashok.k.kaladi@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230220060839.1267349-2-ashok.k.kaladi@intel.com", "date": "2023-02-20T06:08:39", "name": "[2/2] ethdev: fix race condition in fast-path ops setup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7c8eb497639eb2deef0236156e6d95c55c598ca5", "submitter": { "id": 2973, "url": "https://patches.dpdk.org/api/people/2973/?format=api", "name": "Ashok Kaladi", "email": "ashok.k.kaladi@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/mbox/", "series": [ { "id": 27077, "url": "https://patches.dpdk.org/api/series/27077/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27077", "date": "2023-02-20T06:08:38", "name": "[1/2] eventdev: fix race condition in fast-path set function", "version": 1, "mbox": "https://patches.dpdk.org/series/27077/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124166/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/124166/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B922C41CF4;\n\tMon, 20 Feb 2023 07:08:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 67E1F42F9E;\n\tMon, 20 Feb 2023 07:08:47 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id B7E6C40691;\n Mon, 20 Feb 2023 07:08:44 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2023 22:08:44 -0800", "from txandevlnx321.an.intel.com ([10.123.117.43])\n by orsmga006.jf.intel.com with ESMTP; 19 Feb 2023 22:08:43 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1676873325; x=1708409325;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=BkNZZyLjSfwaVQe0dtb33lYkpf26a0PUfmfA6D420Ps=;\n b=KfTUCRseT7ieVX+nF9bCLd4d9LB65nhEZco5GkgX6mxwMFYT5mIllQpm\n o/5pAMZy0IOVBV4M2akl2hv4ocpUm2kRN8i1ZYK79UrhL87fQpzahyHfJ\n T1oYS34c481DqexdqeGwq95scFFGDCBOfDj+gZ8EeV0Mh7lGoSDzAiZPO\n wzKth6AD/L2IbtdKi/oQduRi3KZYzKRCDi/mwvrm40Rle1Q8CI5dbaXOO\n iFVx47dibQDeRj0zZipRVvqVNPZmDJg039dPSKoHyVHEg/Tg/xu55Fnj0\n in9Y0yJH4n7B4EuHnrXkQSE83GV6Gn1OA7NZI7/FZIzqgdHrtO+s5xmlz A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10626\"; a=\"334532133\"", "E=Sophos;i=\"5.97,311,1669104000\"; d=\"scan'208\";a=\"334532133\"", "E=McAfee;i=\"6500,9779,10626\"; a=\"648722858\"", "E=Sophos;i=\"5.97,311,1669104000\"; d=\"scan'208\";a=\"648722858\"" ], "X-ExtLoop1": "1", "From": "Ashok Kaladi <ashok.k.kaladi@intel.com>", "To": "jerinj@marvell.com,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org, s.v.naga.harish.k@intel.com, erik.g.carrillo@intel.com,\n abhinandan.gujjar@intel.com, stable@dpdk.org", "Subject": "[PATCH 2/2] ethdev: fix race condition in fast-path ops setup", "Date": "Mon, 20 Feb 2023 00:08:39 -0600", "Message-Id": "<20230220060839.1267349-2-ashok.k.kaladi@intel.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20230220060839.1267349-1-ashok.k.kaladi@intel.com>", "References": "<20230220060839.1267349-1-ashok.k.kaladi@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If ethdev enqueue or dequeue function is called during\neth_dev_fp_ops_setup(), it may get pre-empted after setting\nthe function pointers, but before setting the pointer to port data.\nIn this case the newly registered enqueue/dequeue function will use\ndummy port data and end up in seg fault.\n\nThis patch moves the updation of each data pointers before updating\ncorresponding function pointers.\n\nFixes: c87d435a4d79 (\"ethdev: copy fast-path API into separate structure\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ashok Kaladi <ashok.k.kaladi@intel.com>", "diff": "diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c\nindex 48090c879a..a0232c669f 100644\n--- a/lib/ethdev/ethdev_private.c\n+++ b/lib/ethdev/ethdev_private.c\n@@ -270,17 +270,17 @@ void\n eth_dev_fp_ops_setup(struct rte_eth_fp_ops *fpo,\n \t\tconst struct rte_eth_dev *dev)\n {\n+\tfpo->rxq.data = dev->data->rx_queues;\n \tfpo->rx_pkt_burst = dev->rx_pkt_burst;\n+\tfpo->txq.data = dev->data->tx_queues;\n \tfpo->tx_pkt_burst = dev->tx_pkt_burst;\n \tfpo->tx_pkt_prepare = dev->tx_pkt_prepare;\n \tfpo->rx_queue_count = dev->rx_queue_count;\n \tfpo->rx_descriptor_status = dev->rx_descriptor_status;\n \tfpo->tx_descriptor_status = dev->tx_descriptor_status;\n \n-\tfpo->rxq.data = dev->data->rx_queues;\n \tfpo->rxq.clbk = (void **)(uintptr_t)dev->post_rx_burst_cbs;\n \n-\tfpo->txq.data = dev->data->tx_queues;\n \tfpo->txq.clbk = (void **)(uintptr_t)dev->pre_tx_burst_cbs;\n }\n \n", "prefixes": [ "2/2" ] }