Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12385/?format=api
{ "id": 12385, "url": "https://patches.dpdk.org/api/patches/12385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1462438424-22574-7-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1462438424-22574-7-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1462438424-22574-7-git-send-email-helin.zhang@intel.com", "date": "2016-05-05T08:53:35", "name": "[dpdk-dev,06/15] i40e/base: expose mirroring config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "07d4854a19cfd70b2e39ab63a1e62a787a21b9a7", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1462438424-22574-7-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/12385/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/12385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 594FC5A49;\n\tThu, 5 May 2016 10:54:07 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 1F4635A49\n\tfor <dev@dpdk.org>; Thu, 5 May 2016 10:54:05 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP; 05 May 2016 01:54:05 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 05 May 2016 01:54:04 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u458s2ia012754;\n\tThu, 5 May 2016 16:54:02 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u458rwgt022651; Thu, 5 May 2016 16:54:00 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u458rwFj022647; \n\tThu, 5 May 2016 16:53:58 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,581,1455004800\"; d=\"scan'208\";a=\"799380293\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "Helin Zhang <helin.zhang@intel.com>", "Date": "Thu, 5 May 2016 16:53:35 +0800", "Message-Id": "<1462438424-22574-7-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1462438424-22574-1-git-send-email-helin.zhang@intel.com>", "References": "<1462438424-22574-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 06/15] i40e/base: expose mirroring config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It exposes the configuration of mirroring or not egress\ntraffic to VSIs in promiscuous mode, as latest firmware\nsupports that from API version 1.5.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 9 ++++++---\n drivers/net/i40e/base/i40e_prototype.h | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 4 ++--\n drivers/net/i40e/i40e_pf.c | 2 +-\n 4 files changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex e958099..ace5b84 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -2214,10 +2214,12 @@ enum i40e_status_code i40e_aq_set_default_vsi(struct i40e_hw *hw,\n * @seid: vsi number\n * @set: set unicast promiscuous enable/disable\n * @cmd_details: pointer to command details structure or NULL\n+ * @rx_only_promisc: flag to decide if egress traffic gets mirrored in promisc\n **/\n enum i40e_status_code i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw,\n \t\t\t\tu16 seid, bool set,\n-\t\t\t\tstruct i40e_asq_cmd_details *cmd_details)\n+\t\t\t\tstruct i40e_asq_cmd_details *cmd_details,\n+\t\t\t\tbool rx_only_promisc)\n {\n \tstruct i40e_aq_desc desc;\n \tstruct i40e_aqc_set_vsi_promiscuous_modes *cmd =\n@@ -2230,8 +2232,9 @@ enum i40e_status_code i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw,\n \n \tif (set) {\n \t\tflags |= I40E_AQC_SET_VSI_PROMISC_UNICAST;\n-\t\tif (((hw->aq.api_maj_ver == 1) && (hw->aq.api_min_ver >= 5)) ||\n-\t\t (hw->aq.api_maj_ver > 1))\n+\t\tif (rx_only_promisc &&\n+\t\t (((hw->aq.api_maj_ver == 1) && (hw->aq.api_min_ver >= 5)) ||\n+\t\t (hw->aq.api_maj_ver > 1)))\n \t\t\tflags |= I40E_AQC_SET_VSI_PROMISC_TX;\n \t}\n \ndiff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\nindex 48a08fd..03dda93 100644\n--- a/drivers/net/i40e/base/i40e_prototype.h\n+++ b/drivers/net/i40e/base/i40e_prototype.h\n@@ -166,7 +166,8 @@ enum i40e_status_code i40e_aq_set_vsi_broadcast(struct i40e_hw *hw,\n \t\t\t\tu16 vsi_id, bool set_filter,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n enum i40e_status_code i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw,\n-\t\tu16 vsi_id, bool set, struct i40e_asq_cmd_details *cmd_details);\n+\t\tu16 vsi_id, bool set, struct i40e_asq_cmd_details *cmd_details,\n+\t\tbool rx_only_promisc);\n enum i40e_status_code i40e_aq_set_vsi_multicast_promiscuous(struct i40e_hw *hw,\n \t\tu16 vsi_id, bool set, struct i40e_asq_cmd_details *cmd_details);\n enum i40e_status_code i40e_aq_set_vsi_mc_promisc_on_vlan(struct i40e_hw *hw,\n@@ -404,7 +405,6 @@ enum i40e_status_code i40e_aq_remove_cloud_filters(struct i40e_hw *hw,\n \t\tu16 vsi,\n \t\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n \t\tu8 filter_count);\n-\n enum i40e_status_code i40e_aq_alternate_read(struct i40e_hw *hw,\n \t\t\t\tu32 reg_addr0, u32 *reg_val0,\n \t\t\t\tu32 reg_addr1, u32 *reg_val1);\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex bc28d3c..b1765fe 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1661,7 +1661,7 @@ i40e_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tint status;\n \n \tstatus = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\ttrue, NULL);\n+\t\t\t\t\t\t true, NULL, true);\n \tif (status != I40E_SUCCESS)\n \t\tPMD_DRV_LOG(ERR, \"Failed to enable unicast promiscuous\");\n \n@@ -1681,7 +1681,7 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tint status;\n \n \tstatus = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\tfalse, NULL);\n+\t\t\t\t\t\t false, NULL, true);\n \tif (status != I40E_SUCCESS)\n \t\tPMD_DRV_LOG(ERR, \"Failed to disable unicast promiscuous\");\n \ndiff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex 5afd61a..b549caa 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -810,7 +810,7 @@ i40e_pf_host_process_cmd_config_promisc_mode(\n \tif (promisc->flags & I40E_FLAG_VF_UNICAST_PROMISC)\n \t\tunicast = TRUE;\n \tret = i40e_aq_set_vsi_unicast_promiscuous(hw,\n-\t\t\tvf->vsi->seid, unicast, NULL);\n+\t\t\tvf->vsi->seid, unicast, NULL, true);\n \tif (ret != I40E_SUCCESS)\n \t\tgoto send_msg;\n \n", "prefixes": [ "dpdk-dev", "06/15" ] }