Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123537/?format=api
{ "id": 123537, "url": "https://patches.dpdk.org/api/patches/123537/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230209091710.485512-18-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230209091710.485512-18-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230209091710.485512-18-maxime.coquelin@redhat.com", "date": "2023-02-09T09:17:06", "name": "[17/21] net/virtio-user: send shadow virtqueue info to the backend", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "174778ea982b7d45a0fa27daa33f813b448888fa", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230209091710.485512-18-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 26913, "url": "https://patches.dpdk.org/api/series/26913/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26913", "date": "2023-02-09T09:16:49", "name": "Add control queue & MQ support to Virtio-user vDPA", "version": 1, "mbox": "https://patches.dpdk.org/series/26913/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/123537/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/123537/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6DFA41C4D;\n\tThu, 9 Feb 2023 10:19:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD30C42D77;\n\tThu, 9 Feb 2023 10:17:48 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id EBF0E42D94\n for <dev@dpdk.org>; Thu, 9 Feb 2023 10:17:45 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-73-o8DA1D2XNkWRm20hgrBbng-1; Thu, 09 Feb 2023 04:17:42 -0500", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19DBC185A7A4;\n Thu, 9 Feb 2023 09:17:42 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.26])\n by smtp.corp.redhat.com (Postfix) with ESMTP id C1FAB492C3F;\n Thu, 9 Feb 2023 09:17:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1675934265;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=T/uIGvbG1s6fr6tWLLFBy/mQNZU+czoJsAGl8eZ65a8=;\n b=ZaPfITXy72yHIU8DMY5m6srVrBG0MTT+4Wg+TNc0PVhymmX+VmPkTs5yGORk4MCaw0v/WY\n mSdz16PArjFSrGaRvhmIbRb3koODLkc1yQEiBR6VIvDiK2XNHIdVjZJEPZriS9gz0LzuGg\n LsbXiaLzbf4hn2lIXLdyC4lmG3vWWUw=", "X-MC-Unique": "o8DA1D2XNkWRm20hgrBbng-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n eperezma@redhat.com, stephen@networkplumber.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH 17/21] net/virtio-user: send shadow virtqueue info to the\n backend", "Date": "Thu, 9 Feb 2023 10:17:06 +0100", "Message-Id": "<20230209091710.485512-18-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230209091710.485512-1-maxime.coquelin@redhat.com>", "References": "<20230209091710.485512-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds sending the shadow control queue info\nto the backend.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\nAcked-by: Eugenio Pérez <eperezma@redhat.com>\n---\n .../net/virtio/virtio_user/virtio_user_dev.c | 28 ++++++++++++++++---\n 1 file changed, 24 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 16a0e07413..1a5386a3f6 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -66,6 +66,18 @@ virtio_user_kick_queue(struct virtio_user_dev *dev, uint32_t queue_sel)\n \t\t.flags = 0, /* disable log */\n \t};\n \n+\tif (queue_sel == dev->max_queue_pairs * 2) {\n+\t\tif (!dev->scvq) {\n+\t\t\tPMD_INIT_LOG(ERR, \"(%s) Shadow control queue expected but missing\",\n+\t\t\t\t\tdev->path);\n+\t\t\tgoto err;\n+\t\t}\n+\n+\t\t/* Use shadow control queue information */\n+\t\tvring = &dev->scvq->vq_split.ring;\n+\t\tpq_vring = &dev->scvq->vq_packed.ring;\n+\t}\n+\n \tif (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {\n \t\taddr.desc_user_addr =\n \t\t\t(uint64_t)(uintptr_t)pq_vring->desc;\n@@ -118,9 +130,13 @@ static int\n virtio_user_queue_setup(struct virtio_user_dev *dev,\n \t\t\tint (*fn)(struct virtio_user_dev *, uint32_t))\n {\n-\tuint32_t i;\n+\tuint32_t i, nr_vq;\n \n-\tfor (i = 0; i < dev->max_queue_pairs * 2; ++i) {\n+\tnr_vq = dev->max_queue_pairs * 2;\n+\tif (dev->hw_cvq)\n+\t\tnr_vq++;\n+\n+\tfor (i = 0; i < nr_vq; i++) {\n \t\tif (fn(dev, i) < 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"(%s) setup VQ %u failed\", dev->path, i);\n \t\t\treturn -1;\n@@ -381,11 +397,15 @@ virtio_user_dev_init_mac(struct virtio_user_dev *dev, const char *mac)\n static int\n virtio_user_dev_init_notify(struct virtio_user_dev *dev)\n {\n-\tuint32_t i, j;\n+\tuint32_t i, j, nr_vq;\n \tint callfd;\n \tint kickfd;\n \n-\tfor (i = 0; i < dev->max_queue_pairs * 2; i++) {\n+\tnr_vq = dev->max_queue_pairs * 2;\n+\tif (dev->hw_cvq)\n+\t\tnr_vq++;\n+\n+\tfor (i = 0; i < nr_vq; i++) {\n \t\t/* May use invalid flag, but some backend uses kickfd and\n \t\t * callfd as criteria to judge if dev is alive. so finally we\n \t\t * use real event_fd.\n", "prefixes": [ "17/21" ] }