Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12351/?format=api
{ "id": 12351, "url": "https://patches.dpdk.org/api/patches/12351/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1462227927-22853-14-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1462227927-22853-14-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1462227927-22853-14-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-05-02T22:25:24", "name": "[dpdk-dev,13/16] vhost: remove virtio-net.h", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "62b15b0b4806eeb0e9527208c73926f566eef75b", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": { "id": 355, "url": "https://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1462227927-22853-14-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/12351/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/12351/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2F6E15A58;\n\tTue, 3 May 2016 00:22:47 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 141E5595C\n\tfor <dev@dpdk.org>; Tue, 3 May 2016 00:22:40 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP; 02 May 2016 15:22:25 -0700", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga004.fm.intel.com with ESMTP; 02 May 2016 15:22:23 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,569,1455004800\"; d=\"scan'208\";a=\"95911212\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "huawei.xie@intel.com, Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tPanu Matilainen <pmatilai@redhat.com>,\n\tTetsuya Mukawa <mukawa@igel.co.jp>, \n\tTraynor Kevin <kevin.traynor@intel.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Mon, 2 May 2016 15:25:24 -0700", "Message-Id": "<1462227927-22853-14-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH 13/16] vhost: remove virtio-net.h", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It barely has anything useful there, just 2 functions prototype. Here\nmove them to vhost-net.h, and delete it.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n lib/librte_vhost/vhost-net.h | 3 ++\n lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 1 -\n lib/librte_vhost/vhost_rxtx.c | 1 -\n lib/librte_vhost/vhost_user/virtio-net-user.c | 1 -\n lib/librte_vhost/virtio-net.c | 1 -\n lib/librte_vhost/virtio-net.h | 43 ---------------------------\n 6 files changed, 3 insertions(+), 47 deletions(-)\n delete mode 100644 lib/librte_vhost/virtio-net.h", "diff": "diff --git a/lib/librte_vhost/vhost-net.h b/lib/librte_vhost/vhost-net.h\nindex 2e4c95d..9710009 100644\n--- a/lib/librte_vhost/vhost-net.h\n+++ b/lib/librte_vhost/vhost-net.h\n@@ -214,6 +214,9 @@ gpa_to_vva(struct virtio_net *dev, uint64_t guest_pa)\n \treturn vhost_va;\n }\n \n+struct virtio_net_device_ops const *notify_ops;\n+struct virtio_net *get_device(int vid);\n+\n int vhost_new_device(void);\n void vhost_destroy_device(int);\n \ndiff --git a/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c b/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c\nindex 0723a7a..552be7d 100644\n--- a/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c\n+++ b/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c\n@@ -54,7 +54,6 @@\n #include \"rte_virtio_net.h\"\n #include \"vhost-net.h\"\n #include \"virtio-net-cdev.h\"\n-#include \"virtio-net.h\"\n #include \"eventfd_copy.h\"\n \n /* Line size for reading maps file. */\ndiff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c\nindex 08cab08..65278bb 100644\n--- a/lib/librte_vhost/vhost_rxtx.c\n+++ b/lib/librte_vhost/vhost_rxtx.c\n@@ -46,7 +46,6 @@\n #include <rte_arp.h>\n \n #include \"vhost-net.h\"\n-#include \"virtio-net.h\"\n \n #define MAX_PKT_BURST 32\n #define VHOST_LOG_PAGE\t4096\ndiff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/virtio-net-user.c\nindex 7fa69a7..6463bdd 100644\n--- a/lib/librte_vhost/vhost_user/virtio-net-user.c\n+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c\n@@ -43,7 +43,6 @@\n #include <rte_common.h>\n #include <rte_log.h>\n \n-#include \"virtio-net.h\"\n #include \"virtio-net-user.h\"\n #include \"vhost-net-user.h\"\n #include \"vhost-net.h\"\ndiff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c\nindex 9fd80a8..6577fe0 100644\n--- a/lib/librte_vhost/virtio-net.c\n+++ b/lib/librte_vhost/virtio-net.c\n@@ -53,7 +53,6 @@\n #include <rte_virtio_net.h>\n \n #include \"vhost-net.h\"\n-#include \"virtio-net.h\"\n \n #define MAX_VHOST_DEVICE\t1024\n static struct virtio_net *vhost_devices[MAX_VHOST_DEVICE];\ndiff --git a/lib/librte_vhost/virtio-net.h b/lib/librte_vhost/virtio-net.h\ndeleted file mode 100644\nindex 9812545..0000000\n--- a/lib/librte_vhost/virtio-net.h\n+++ /dev/null\n@@ -1,43 +0,0 @@\n-/*-\n- * BSD LICENSE\n- *\n- * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n- * All rights reserved.\n- *\n- * Redistribution and use in source and binary forms, with or without\n- * modification, are permitted provided that the following conditions\n- * are met:\n- *\n- * * Redistributions of source code must retain the above copyright\n- * notice, this list of conditions and the following disclaimer.\n- * * Redistributions in binary form must reproduce the above copyright\n- * notice, this list of conditions and the following disclaimer in\n- * the documentation and/or other materials provided with the\n- * distribution.\n- * * Neither the name of Intel Corporation nor the names of its\n- * contributors may be used to endorse or promote products derived\n- * from this software without specific prior written permission.\n- *\n- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n- * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n- */\n-\n-#ifndef _VIRTIO_NET_H\n-#define _VIRTIO_NET_H\n-\n-#include \"vhost-net.h\"\n-#include \"rte_virtio_net.h\"\n-\n-struct virtio_net_device_ops const *notify_ops;\n-struct virtio_net *get_device(int vid);\n-\n-#endif\n", "prefixes": [ "dpdk-dev", "13/16" ] }