Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123362/?format=api
{ "id": 123362, "url": "https://patches.dpdk.org/api/patches/123362/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230207170050.1093917-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207170050.1093917-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207170050.1093917-1-stephen@networkplumber.org", "date": "2023-02-07T17:00:50", "name": "app/dumpcap: don't pass negative value to strerror() on error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "876fbb0a02b113847d233f817d335e6f8c56ac78", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230207170050.1093917-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 26864, "url": "https://patches.dpdk.org/api/series/26864/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26864", "date": "2023-02-07T17:00:50", "name": "app/dumpcap: don't pass negative value to strerror() on error", "version": 1, "mbox": "https://patches.dpdk.org/series/26864/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/123362/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/123362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0BF741C32;\n\tTue, 7 Feb 2023 18:00:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 988154021F;\n\tTue, 7 Feb 2023 18:00:58 +0100 (CET)", "from mail-pj1-f49.google.com (mail-pj1-f49.google.com\n [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 7F81B40151\n for <dev@dpdk.org>; Tue, 7 Feb 2023 18:00:57 +0100 (CET)", "by mail-pj1-f49.google.com with SMTP id\n rm7-20020a17090b3ec700b0022c05558d22so15600215pjb.5\n for <dev@dpdk.org>; Tue, 07 Feb 2023 09:00:57 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n z15-20020aa791cf000000b00590163e1762sm9403329pfa.200.2023.02.07.09.00.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Feb 2023 09:00:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=hj5eZAC9OM7yPnhqWaYEoYhRKUlhWc0DqcpfMiWqWrc=;\n b=obvu1s9MEkgQX3L3OrUj6vGh1/5x+/VMjmpWfaCFV5edkyx0UYlsy9XcDWiIxRRaHX\n BD4a8vg1E4r/qDpOPgi9+lVUfHaxif5nTwlbJ0UheBOs5+w7m3Nw7vsbiTtXgeP0F7ul\n dKjQN0pZH6GVwsLlT8qsL6gbxKlNnj04rfv+WoW5+zU+7ceA2vACnEG0kB2GxgqrU++o\n ADhU71bhFF6XjdRB9t4nyblFHkXNlQkL3Q429onwLioAW+UypM6MRd/I+KnF5iRgIMFb\n gVrLkNPxKu4hINvE/6cTouO4OFezoRc/EA+6chW1TM9dMHcDrCWzE7V/LfQt1YOB224s\n Uz/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=hj5eZAC9OM7yPnhqWaYEoYhRKUlhWc0DqcpfMiWqWrc=;\n b=NTwzzfBSV5bMquGJBo00wSV1AAzfBqu/yfv5gii2M/y4tN0ErpeXENvD8zq23Eq25c\n aCM7QHT1HzvbVkXnIGApDzUz1sCLXUzNJdMQq1QbNcw954jpnd6SWP9chpwwhB2q5q75\n G/ACBreQ7XdtjdCm0XcJafiq0htLSvPqcnvheCaiHy1wGeqBQzV6aqGmPm+UobgGt4wc\n tTbvpstEpM6v2+ewMQqTKnYbqnZgerbgW4IOonEJbk2wGDYNiXRXnyn+qWextnzE/ylo\n Ry2wN/Z2OY85essINrD+q60TQ0Y8GKcE31EVfHvKIWJOq97ejs0YElH5uPJbXLDjwCp2\n N+Bg==", "X-Gm-Message-State": "AO0yUKU2SBhOL1r5d9DML9tRC7cUDHmoMrZkxn1lZGcO/+wT0K77NEGk\n ZT0QJ3BasRwZXxbPx8Uro+XnqanXHTpBSVsF6sU=", "X-Google-Smtp-Source": "\n AK7set8ru8fjxhqjmKBCLgwBh8/J22KtSm7fEn50UC9zFgKrhdSez05BQo5x/5HqQp2hy3yjU4n9FA==", "X-Received": "by 2002:a05:6a20:b708:b0:c0:d8e1:8299 with SMTP id\n fg8-20020a056a20b70800b000c0d8e18299mr3410347pzb.14.1675789256212;\n Tue, 07 Feb 2023 09:00:56 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH] app/dumpcap: don't pass negative value to strerror() on error", "Date": "Tue, 7 Feb 2023 09:00:50 -0800", "Message-Id": "<20230207170050.1093917-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If eth_stats_get fails (for example with -ENOTSUPP) then\ndumpcap would pass that to strerror which is incorrect.\n\nFixes: 8744f84bb255 (\"app/dumpcap: add statistics mode\")\nCoverity issue: 383136\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex 904eb5a7d7d9..64294bbfb3e6 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -500,7 +500,7 @@ static void statistics_loop(void)\n \t\t\tif (r < 0) {\n \t\t\t\tfprintf(stderr,\n \t\t\t\t\t\"stats_get for port %u failed: %d (%s)\\n\",\n-\t\t\t\t\tp, r, strerror(r));\n+\t\t\t\t\tp, r, strerror(-r));\n \t\t\t\treturn;\n \t\t\t}\n \n", "prefixes": [] }