Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123291/?format=api
{ "id": 123291, "url": "https://patches.dpdk.org/api/patches/123291/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230207151747.245808-15-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207151747.245808-15-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207151747.245808-15-maxime.coquelin@redhat.com", "date": "2023-02-07T15:17:40", "name": "[v2,14/21] net/virtio-user: use proper type for number of queue pairs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6ebc0e3915a176d699b201fc9f0c996c2f5f83d", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230207151747.245808-15-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 26854, "url": "https://patches.dpdk.org/api/series/26854/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26854", "date": "2023-02-07T15:17:33", "name": "Add control queue & MQ support to Virtio-user vDPA", "version": 2, "mbox": "https://patches.dpdk.org/series/26854/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/123291/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/123291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7DEE41C30;\n\tTue, 7 Feb 2023 16:20:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED2A642F9A;\n\tTue, 7 Feb 2023 16:18:58 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 092AE42D93\n for <dev@dpdk.org>; Tue, 7 Feb 2023 16:18:50 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-541-WufBOFAqMjKgWiSlUsVp4Q-1; Tue, 07 Feb 2023 10:18:42 -0500", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 242F4280BCA7;\n Tue, 7 Feb 2023 15:18:17 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.26])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B4B38140EBF4;\n Tue, 7 Feb 2023 15:18:15 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1675783130;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=g+CSTBHsaU0moPl7iqJZIm7goKB9z1IxILdai+WkdPY=;\n b=g2acByPpI/IgOgq9rjVQvbxSyVnhQra9NZw8ltgTcifoesDdoq4Si1BVAfMokGe8Gx04QT\n N16f5vmOIVwTNjFcES9bgNJf/yowHpUQxFYA6DpwI9uUqPytx8yiEeyakZogWGsXk0w21w\n mfydvED2fx3PmWpp5FsCu9rBpfHXJaI=", "X-MC-Unique": "WufBOFAqMjKgWiSlUsVp4Q-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n eperezma@redhat.com, stephen@networkplumber.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v2 14/21] net/virtio-user: use proper type for number of queue\n pairs", "Date": "Tue, 7 Feb 2023 16:17:40 +0100", "Message-Id": "<20230207151747.245808-15-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230207151747.245808-1-maxime.coquelin@redhat.com>", "References": "<20230207151747.245808-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The number of queue pairs is specified as a 16 bits\nunsigned int in the Virtio specification.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-\n drivers/net/virtio/virtio_user/virtio_user_dev.h | 6 +++---\n drivers/net/virtio/virtio_user_ethdev.c | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 873c6aa036..809c9ef442 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -553,7 +553,7 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n \t 1ULL << VIRTIO_F_RING_PACKED)\n \n int\n-virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n+virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues,\n \t\t int cq, int queue_size, const char *mac, char **ifname,\n \t\t int server, int mrg_rxbuf, int in_order, int packed_vq,\n \t\t enum virtio_user_backend_type backend_type)\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h\nindex 819f6463ba..3c5453eac0 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h\n@@ -32,8 +32,8 @@ struct virtio_user_dev {\n \tint\t\tcallfds[VIRTIO_MAX_VIRTQUEUES];\n \tint\t\tkickfds[VIRTIO_MAX_VIRTQUEUES];\n \tint\t\tmac_specified;\n-\tuint32_t\tmax_queue_pairs;\n-\tuint32_t\tqueue_pairs;\n+\tuint16_t\tmax_queue_pairs;\n+\tuint16_t\tqueue_pairs;\n \tuint32_t\tqueue_size;\n \tuint64_t\tfeatures; /* the negotiated features with driver,\n \t\t\t\t * and will be sync with device\n@@ -64,7 +64,7 @@ struct virtio_user_dev {\n int virtio_user_dev_set_features(struct virtio_user_dev *dev);\n int virtio_user_start_device(struct virtio_user_dev *dev);\n int virtio_user_stop_device(struct virtio_user_dev *dev);\n-int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n+int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues,\n \t\t\t int cq, int queue_size, const char *mac, char **ifname,\n \t\t\t int server, int mrg_rxbuf, int in_order,\n \t\t\t int packed_vq,\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 78b1ed9ace..6ad5896378 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -655,7 +655,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev)\n \n \tdev = eth_dev->data->dev_private;\n \thw = &dev->hw;\n-\tif (virtio_user_dev_init(dev, path, queues, cq,\n+\tif (virtio_user_dev_init(dev, path, (uint16_t)queues, cq,\n \t\t\t queue_size, mac_addr, &ifname, server_mode,\n \t\t\t mrg_rxbuf, in_order, packed_vq, backend_type) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"virtio_user_dev_init fails\");\n", "prefixes": [ "v2", "14/21" ] }