Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123259/?format=api
{ "id": 123259, "url": "https://patches.dpdk.org/api/patches/123259/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230207151316.835441-4-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207151316.835441-4-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207151316.835441-4-jerinj@marvell.com", "date": "2023-02-07T15:13:07", "name": "[v3,03/12] mldev: support ML device handling functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "99de6b955a3f7d3b83b37b128cb0594063547d5c", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230207151316.835441-4-jerinj@marvell.com/mbox/", "series": [ { "id": 26852, "url": "https://patches.dpdk.org/api/series/26852/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26852", "date": "2023-02-07T15:13:04", "name": "mldev: introduce machine learning device library", "version": 3, "mbox": "https://patches.dpdk.org/series/26852/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/123259/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/123259/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA12041C30;\n\tTue, 7 Feb 2023 16:13:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6077D427F5;\n\tTue, 7 Feb 2023 16:13:45 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 26767427F5\n for <dev@dpdk.org>; Tue, 7 Feb 2023 16:13:44 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 317EdPWX011264; Tue, 7 Feb 2023 07:13:43 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3nkdyrsk1v-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 07 Feb 2023 07:13:43 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Tue, 7 Feb 2023 07:13:41 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Tue, 7 Feb 2023 07:13:41 -0800", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id E9CEF3F7083;\n Tue, 7 Feb 2023 07:13:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=+qrFVdZdihsqAtrh8xmMKPCojouHLHETmWCqZPOOcZo=;\n b=chZG4tuf9VzwxFggH/4iFa7BAufxPH4BLCxHi9+aIjEfA6oE/dcsuRekLjd/gmumP+Mx\n R8SejcTbNJJRT0ny4ThypBc+Zb4uTF3fpJDSPps9Hp6BWsExdUDuOnGTTsWLTON4Jk3I\n rPPAvcqpdfYJzjeQu5gvvSeniiw7QeEhuWAcB2JOgHtjr0sk/jnzeXBj1XUPrXGzFhZu\n rGX3VEwsER38oq01h19hTPo0cgwJSqlH1rpkdd9n0wO2QLi3uWJDNaJzVVS/IyP3qUY+\n Kt4kay7OkUwHe/wwr2wk7MHjUkDdcTEk2VFFLcxTcyNY05BdcO6VkMPUxZnVb16AgMvK 6w==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <stephen@networkplumber.org>, <dchickles@marvell.com>,\n <sshankarnara@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "Subject": "[dpdk-dev] [PATCH v3 03/12] mldev: support ML device handling\n functions", "Date": "Tue, 7 Feb 2023 20:43:07 +0530", "Message-ID": "<20230207151316.835441-4-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230207151316.835441-1-jerinj@marvell.com>", "References": "<20230206202453.336280-1-jerinj@marvell.com>\n <20230207151316.835441-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "htZCRTZOl1Bhdvl7ZcU8BpnlSnHqlJnx", "X-Proofpoint-GUID": "htZCRTZOl1Bhdvl7ZcU8BpnlSnHqlJnx", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1\n definitions=2023-02-07_07,2023-02-06_03,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Srikanth Yalavarthi <syalavarthi@marvell.com>\n\nAdded ML device handling APIs. These APIs are used to get device\ninformation, configure, start, stop and close ML devices. Added\nfunction prototypes to PMD layer which are used by the ML driver\nimplementations in the poll mode driver.\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/mldev/rte_mldev.c | 175 +++++++++++++++++++++++++++++++++++++\n lib/mldev/rte_mldev_core.h | 107 +++++++++++++++++++++++\n lib/mldev/version.map | 8 ++\n 3 files changed, 290 insertions(+)", "diff": "diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c\nindex 833afcbf87..961e12d150 100644\n--- a/lib/mldev/rte_mldev.c\n+++ b/lib/mldev/rte_mldev.c\n@@ -177,4 +177,179 @@ rte_ml_dev_init(size_t dev_max)\n \treturn 0;\n }\n \n+uint16_t\n+rte_ml_dev_count(void)\n+{\n+\treturn ml_dev_globals.nb_devs;\n+}\n+\n+int\n+rte_ml_dev_is_valid_dev(int16_t dev_id)\n+{\n+\tstruct rte_ml_dev *dev = NULL;\n+\n+\tif (dev_id >= ml_dev_globals.max_devs || ml_dev_globals.devs[dev_id].data == NULL)\n+\t\treturn 0;\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (dev->attached != ML_DEV_ATTACHED)\n+\t\treturn 0;\n+\telse\n+\t\treturn 1;\n+}\n+\n+int\n+rte_ml_dev_socket_id(int16_t dev_id)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\n+\treturn dev->data->socket_id;\n+}\n+\n+int\n+rte_ml_dev_info_get(int16_t dev_id, struct rte_ml_dev_info *dev_info)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_info_get == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (dev_info == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, dev_info cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\tmemset(dev_info, 0, sizeof(struct rte_ml_dev_info));\n+\n+\treturn (*dev->dev_ops->dev_info_get)(dev, dev_info);\n+}\n+\n+int\n+rte_ml_dev_configure(int16_t dev_id, const struct rte_ml_dev_config *config)\n+{\n+\tstruct rte_ml_dev_info dev_info;\n+\tstruct rte_ml_dev *dev;\n+\tint ret;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_configure == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (dev->data->dev_started) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Device %d must be stopped to allow configuration\", dev_id);\n+\t\treturn -EBUSY;\n+\t}\n+\n+\tif (config == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, config cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tret = rte_ml_dev_info_get(dev_id, &dev_info);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tif (config->nb_queue_pairs > dev_info.max_queue_pairs) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Device %d num of queues %u > %u\\n\", dev_id,\n+\t\t\t config->nb_queue_pairs, dev_info.max_queue_pairs);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn (*dev->dev_ops->dev_configure)(dev, config);\n+}\n+\n+int\n+rte_ml_dev_close(int16_t dev_id)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_close == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\t/* Device must be stopped before it can be closed */\n+\tif (dev->data->dev_started == 1) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Device %d must be stopped before closing\", dev_id);\n+\t\treturn -EBUSY;\n+\t}\n+\n+\treturn (*dev->dev_ops->dev_close)(dev);\n+}\n+\n+int\n+rte_ml_dev_start(int16_t dev_id)\n+{\n+\tstruct rte_ml_dev *dev;\n+\tint ret;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_start == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (dev->data->dev_started != 0) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Device %d is already started\", dev_id);\n+\t\treturn -EBUSY;\n+\t}\n+\n+\tret = (*dev->dev_ops->dev_start)(dev);\n+\tif (ret == 0)\n+\t\tdev->data->dev_started = 1;\n+\n+\treturn ret;\n+}\n+\n+int\n+rte_ml_dev_stop(int16_t dev_id)\n+{\n+\tstruct rte_ml_dev *dev;\n+\tint ret;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_stop == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (dev->data->dev_started == 0) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Device %d is not started\", dev_id);\n+\t\treturn -EBUSY;\n+\t}\n+\n+\tret = (*dev->dev_ops->dev_stop)(dev);\n+\tif (ret == 0)\n+\t\tdev->data->dev_started = 0;\n+\n+\treturn ret;\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_ml_dev_logtype, INFO);\ndiff --git a/lib/mldev/rte_mldev_core.h b/lib/mldev/rte_mldev_core.h\nindex 1564d0fa4d..dc79c5f630 100644\n--- a/lib/mldev/rte_mldev_core.h\n+++ b/lib/mldev/rte_mldev_core.h\n@@ -31,6 +31,110 @@ extern \"C\" {\n #define ML_DEV_DETACHED (0)\n #define ML_DEV_ATTACHED (1)\n \n+struct rte_ml_dev;\n+\n+/**\n+ * Definitions of all functions exported by a driver through the generic structure of type\n+ * *ml_dev_ops* supplied in the *rte_ml_dev* structure associated with a device.\n+ */\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to get device information.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param dev_info\n+ *\tPointer to info structure.\n+ *\n+ * @return\n+ *\t- 0 on success.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_info_get_t)(struct rte_ml_dev *dev, struct rte_ml_dev_info *dev_info);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to configure device.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param config\n+ *\tML device configurations.\n+ *\n+ * @return\n+ *\t- 0 on success\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_configure_t)(struct rte_ml_dev *dev, const struct rte_ml_dev_config *config);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to close a configured device.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ *\n+ * @return\n+ *\t- 0 on success.\n+ *\t- -EAGAIN if can't close as device is busy.\n+ *\t- < 0, error code on failure, other than busy.\n+ */\n+typedef int (*mldev_close_t)(struct rte_ml_dev *dev);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to start a configured device.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ *\n+ * @return\n+ *\t- 0 on success.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_start_t)(struct rte_ml_dev *dev);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to stop a configured device.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ *\n+ * @return\n+ *\t- 0 on success.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_stop_t)(struct rte_ml_dev *dev);\n+\n+/**\n+ * @internal\n+ *\n+ * ML device operations function pointer table.\n+ */\n+struct rte_ml_dev_ops {\n+\t/** Get device information. */\n+\tmldev_info_get_t dev_info_get;\n+\n+\t/** Configure device. */\n+\tmldev_configure_t dev_configure;\n+\n+\t/** Close device. */\n+\tmldev_close_t dev_close;\n+\n+\t/** Start device. */\n+\tmldev_start_t dev_start;\n+\n+\t/** Stop device. */\n+\tmldev_stop_t dev_stop;\n+};\n+\n /**\n * @internal\n *\n@@ -75,6 +179,9 @@ struct rte_ml_dev {\n \t/** Pointer to device data. */\n \tstruct rte_ml_dev_data *data;\n \n+\t/** Functions exported by PMD. */\n+\tstruct rte_ml_dev_ops *dev_ops;\n+\n \t/** Backing RTE device. */\n \tstruct rte_device *device;\n \ndiff --git a/lib/mldev/version.map b/lib/mldev/version.map\nindex d6bf7c8ebb..028b6a464d 100644\n--- a/lib/mldev/version.map\n+++ b/lib/mldev/version.map\n@@ -1,8 +1,16 @@\n EXPERIMENTAL {\n \tglobal:\n \n+\trte_ml_dev_close;\n+\trte_ml_dev_configure;\n+\trte_ml_dev_count;\n+\trte_ml_dev_info_get;\n \trte_ml_dev_init;\n+\trte_ml_dev_is_valid_dev;\n \trte_ml_dev_logtype;\n+\trte_ml_dev_socket_id;\n+\trte_ml_dev_start;\n+\trte_ml_dev_stop;\n \n \tlocal: *;\n };\n", "prefixes": [ "v3", "03/12" ] }