Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122717/?format=api
{ "id": 122717, "url": "https://patches.dpdk.org/api/patches/122717/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/89ad936909b04363b36f4014680ed65c@qianxin.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<89ad936909b04363b36f4014680ed65c@qianxin.com>", "list_archive_url": "https://inbox.dpdk.org/dev/89ad936909b04363b36f4014680ed65c@qianxin.com", "date": "2023-01-31T07:44:10", "name": "答复: [[SPF Failed]][PATCH v2] net/i40e: rework maximum frame size configuration", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "06fdf902dcec8c67da034491b91b39c0cc657024", "submitter": { "id": 2671, "url": "https://patches.dpdk.org/api/people/2671/?format=api", "name": "韩爽", "email": "hanshuang@qianxin.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/89ad936909b04363b36f4014680ed65c@qianxin.com/mbox/", "series": [ { "id": 26706, "url": "https://patches.dpdk.org/api/series/26706/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26706", "date": "2023-01-31T07:44:10", "name": "答复: [[SPF Failed]][PATCH v2] net/i40e: rework maximum frame size configuration", "version": 1, "mbox": "https://patches.dpdk.org/series/26706/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/122717/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/122717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2B4341B8A;\n\tTue, 31 Jan 2023 08:44:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6C67540E28;\n\tTue, 31 Jan 2023 08:44:19 +0100 (CET)", "from hmat.qianxin.com (hmat.qianxin.com [220.181.41.43])\n by mails.dpdk.org (Postfix) with ESMTP id EBA4140DFB;\n Tue, 31 Jan 2023 08:44:15 +0100 (CET)" ], "From": "=?utf-8?b?6Z+p54i9?= <hanshuang@qianxin.com>", "To": "Simei Su <simei.su@intel.com>, \"beilei.xing@intel.com\"\n <beilei.xing@intel.com>, \"yuying.zhang@intel.com\" <yuying.zhang@intel.com>,\n \"david.marchand@redhat.com\" <david.marchand@redhat.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"qi.z.zhang@intel.com\"\n <qi.z.zhang@intel.com>, \"qiming.yang@intel.com\" <qiming.yang@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>", "Subject": "=?utf-8?q?=E7=AD=94=E5=A4=8D=3A_=5B=5BSPF_Failed=5D=5D=5BPATCH_v2?=\n\t=?utf-8?q?=5D_net/i40e=3A_rework_maximum_frame_size_configuration?=", "Thread-Topic": "[[SPF Failed]][PATCH v2] net/i40e: rework maximum frame size\n configuration", "Thread-Index": "AQHZNUDC8XmV8Kf0ukeY/n3zwfq0sq64IDFg", "Date": "Tue, 31 Jan 2023 07:44:10 +0000", "Message-ID": "<89ad936909b04363b36f4014680ed65c@qianxin.com>", "References": "<20230116105318.19412-1-simei.su@intel.com>\n <20230131065229.290041-1-simei.su@intel.com>", "In-Reply-To": "<20230131065229.290041-1-simei.su@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "zh-CN", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[172.24.194.36]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Why i40e_dev_link_update must be called with wait_to_complete when link interrupt is enabled ?\nI think it's may have the same issue as ice_link_update, please check: https://patches.dpdk.org/project/dpdk/patch/1669207333-8769-1-git-send-email-hanshuang87@gmail.com/\n\n-----邮件原件-----\n发件人: Simei Su <simei.su@intel.com> \n发送时间: 2023年1月31日 14:52\n收件人: beilei.xing@intel.com; yuying.zhang@intel.com; david.marchand@redhat.com\n抄送: dev@dpdk.org; qi.z.zhang@intel.com; qiming.yang@intel.com; Simei Su <simei.su@intel.com>; stable@dpdk.org\n主题: [[SPF Failed]][PATCH v2] net/i40e: rework maximum frame size configuration\n\n该邮件SPF检测失败，发件IP不被发件域名信任，请谨慎甄别邮件，如有疑问，请蓝信搜索【网络安全部安全运营】反馈！\n\n\n邮件原文如下：\n\nThis patch removes unnecessary link status check and adds link update.\n\nFixes: a4ba77367923 (\"net/i40e: enable maximum frame size at port level\")\nFixes: 2184f7cdeeaa (\"net/i40e: fix max frame size config at port level\")\nFixes: 719469f13b11 (\"net/i40e: fix jumbo frame Rx with X722\")\nCc: stable@dpdk.org\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\nv2:\n* Refine commit log.\n* Add link update.\n\n drivers/net/i40e/i40e_ethdev.c | 54 +++++++++++-------------------------------\n 1 file changed, 14 insertions(+), 40 deletions(-)\n\n \t\t\t \"before starting the port\");\n \n-\tmax_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD;\n-\ti40e_set_mac_max_frame(dev, max_frame_size);\n+\ti40e_dev_link_update(dev, 1);\n+\n+\tmax_frame_size = dev->data->mtu ?\n+\t\tdev->data->mtu + I40E_ETH_OVERHEAD :\n+\t\tI40E_FRAME_SIZE_MAX;\n+\n+\t/* Set the max frame size to HW*/\n+\tret = i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Fail to set mac config\");\n+\t\treturn ret;\n+\t}\n \n \treturn I40E_SUCCESS;\n \n@@ -2809,9 +2818,6 @@ i40e_dev_set_link_down(struct rte_eth_dev *dev)\n \treturn i40e_phy_conf_link(hw, abilities, speed, false); }\n \n-#define CHECK_INTERVAL 100 /* 100ms */\n-#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n-\n static __rte_always_inline void\n update_link_reg(struct i40e_hw *hw, struct rte_eth_link *link) { @@ -2878,6 +2884,8 @@ static __rte_always_inline void update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link,\n \tbool enable_lse, int wait_to_complete) {\n+#define CHECK_INTERVAL 100 /* 100ms */\n+#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n \tuint32_t rep_cnt = MAX_REPEAT_TIME;\n \tstruct i40e_link_status link_status;\n \tint status;\n@@ -12123,40 +12131,6 @@ i40e_cloud_filter_qinq_create(struct i40e_pf *pf)\n \treturn ret;\n }\n \n-static void\n-i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size) -{\n-\tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint32_t rep_cnt = MAX_REPEAT_TIME;\n-\tstruct rte_eth_link link;\n-\tenum i40e_status_code status;\n-\tbool can_be_set = true;\n-\n-\t/*\n-\t * I40E_MEDIA_TYPE_BASET link up can be ignored\n-\t * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type\n-\t * is I40E_MEDIA_TYPE_UNKNOWN\n-\t */\n-\tif (hw->phy.media_type != I40E_MEDIA_TYPE_BASET &&\n-\t hw->phy.media_type != I40E_MEDIA_TYPE_UNKNOWN) {\n-\t\tdo {\n-\t\t\tupdate_link_reg(hw, &link);\n-\t\t\tif (link.link_status)\n-\t\t\t\tbreak;\n-\t\t\trte_delay_ms(CHECK_INTERVAL);\n-\t\t} while (--rep_cnt);\n-\t\tcan_be_set = !!link.link_status;\n-\t}\n-\n-\tif (can_be_set) {\n-\t\tstatus = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);\n-\t\tif (status != I40E_SUCCESS)\n-\t\t\tPMD_DRV_LOG(ERR, \"Failed to set max frame size at port level\");\n-\t} else {\n-\t\tPMD_DRV_LOG(ERR, \"Set max frame size at port level not applicable on link down\");\n-\t}\n-}\n-\n RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE); RTE_LOG_REGISTER_SUFFIX(i40e_logtype_driver, driver, NOTICE); #ifdef RTE_ETHDEV_DEBUG_RX\n--\n2.9.5", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 7726a89d..a3100ec 100644\r\n--- a/drivers/net/i40e/i40e_ethdev.c\r\n+++ b/drivers/net/i40e/i40e_ethdev.c\r\n@@ -387,7 +387,6 @@ static int i40e_set_default_mac_addr(struct rte_eth_dev *dev,\r\n \t\t\t\t struct rte_ether_addr *mac_addr);\r\n \r\n static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); -static void i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size);\r\n \r\n static int i40e_ethertype_filter_convert(\r\n \tconst struct rte_eth_ethertype_filter *input, @@ -2467,8 +2466,18 @@ i40e_dev_start(struct rte_eth_dev *dev)\r\n \t\t\t \"please call hierarchy_commit() \"\r\n", "prefixes": [] }