Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122608/?format=api
{ "id": 122608, "url": "https://patches.dpdk.org/api/patches/122608/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230128030603.1168073-1-chenh@yusur.tech/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230128030603.1168073-1-chenh@yusur.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/20230128030603.1168073-1-chenh@yusur.tech", "date": "2023-01-28T03:06:02", "name": "vhost: fix vdpa driver multi-queue initialization failure", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2aafe8ef2929ef1d317c4f5c9cfe60e018fd77b1", "submitter": { "id": 2846, "url": "https://patches.dpdk.org/api/people/2846/?format=api", "name": "Hao Chen", "email": "chenh@yusur.tech" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230128030603.1168073-1-chenh@yusur.tech/mbox/", "series": [ { "id": 26673, "url": "https://patches.dpdk.org/api/series/26673/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26673", "date": "2023-01-28T03:06:02", "name": "vhost: fix vdpa driver multi-queue initialization failure", "version": 1, "mbox": "https://patches.dpdk.org/series/26673/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/122608/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/122608/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C37E424A6;\n\tSat, 28 Jan 2023 04:05:17 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CEB4740223;\n\tSat, 28 Jan 2023 04:05:16 +0100 (CET)", "from out29-127.mail.aliyun.com (out29-127.mail.aliyun.com\n [115.124.29.127])\n by mails.dpdk.org (Postfix) with ESMTP id 2605640146\n for <dev@dpdk.org>; Sat, 28 Jan 2023 04:05:14 +0100 (CET)", "from localhost.localdomain(mailfrom:chenh@yusur.tech\n fp:SMTPD_---.R2UgSrQ_1674875111) by smtp.aliyun-inc.com;\n Sat, 28 Jan 2023 11:05:12 +0800" ], "X-Alimail-AntiSpam": "AC=CONTINUE; BC=0.1630338|-1; CH=green;\n DM=|CONTINUE|false|;\n DS=CONTINUE|ham_system_inform|0.00922433-0.000737289-0.990038;\n FP=0|0|0|0|0|-1|-1|-1; HT=ay29a033018047207; MF=chenh@yusur.tech; NM=1;\n PH=DS;\n RN=5; RT=5; SR=0; TI=SMTPD_---.R2UgSrQ_1674875111;", "From": "Hao Chen <chenh@yusur.tech>", "To": "dev@dpdk.org", "Cc": "zy@yusur.tech, huangml@yusur.tech,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Subject": "[PATCH] vhost: fix vdpa driver multi-queue initialization failure", "Date": "Sat, 28 Jan 2023 11:06:02 +0800", "Message-Id": "<20230128030603.1168073-1-chenh@yusur.tech>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be\ncalled, and the vdpa driver called 'rte_vhost_get_vhost_vring' to\nget the vring addr info from 'vhost_devices->virtqueue[]'.\nvirtio_is_ready's nr_vring is VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY(2),\nmulti-queue's nr_vring is greater than 2.\nOnly 'vhost_devices->virtqueue[0]' and 'vhost_devices->virtqueue[1]'\nare obtained in the for loop. Other queues of multiple queues cannot\nobtain the corresponding 'vhost_devices->virtqueue[i]', which will\ncause 'vdpa_dev->ops->dev_conf' to obtain QEMU vring addr information\nfrom 'vhost_devices->virtqueue[i]' failed.\nHere, nr_ving is modified to dev->nr_vring, so that multiple queues\ncan obtain the corresponding 'vhost_devices->virtqueue[i]'.\n\nSigned-off-by: Hao Chen <chenh@yusur.tech>\n---\n lib/vhost/vhost_user.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 9902ae9944..9249eafc06 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -1473,7 +1473,7 @@ virtio_is_ready(struct virtio_net *dev)\n \tif (dev->nr_vring < nr_vring)\n \t\treturn 0;\n \n-\tfor (i = 0; i < nr_vring; i++) {\n+\tfor (i = 0; i < dev->nr_vring; i++) {\n \t\tvq = dev->virtqueue[i];\n \n \t\tif (!vq_is_ready(dev, vq))\n", "prefixes": [] }