Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122344/?format=api
https://patches.dpdk.org/api/patches/122344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230119045824.665663-10-rongweil@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230119045824.665663-10-rongweil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230119045824.665663-10-rongweil@nvidia.com", "date": "2023-01-19T04:58:22", "name": "[v2,09/11] app/testpmd: raw encap with flex item support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6b584628839e31bd373145f8793017032c3294bc", "submitter": { "id": 2223, "url": "https://patches.dpdk.org/api/people/2223/?format=api", "name": "rongwei liu", "email": "rongweil@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230119045824.665663-10-rongweil@nvidia.com/mbox/", "series": [ { "id": 26603, "url": "https://patches.dpdk.org/api/series/26603/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26603", "date": "2023-01-19T04:58:13", "name": "add flex item support", "version": 2, "mbox": "https://patches.dpdk.org/series/26603/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/122344/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/122344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 114E842413;\n\tThu, 19 Jan 2023 06:00:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 30B2F42DA0;\n\tThu, 19 Jan 2023 05:59:25 +0100 (CET)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2064.outbound.protection.outlook.com [40.107.93.64])\n by mails.dpdk.org (Postfix) with ESMTP id C488A42DA0\n for <dev@dpdk.org>; Thu, 19 Jan 2023 05:59:23 +0100 (CET)", "from MW4PR04CA0163.namprd04.prod.outlook.com (2603:10b6:303:85::18)\n by BL1PR12MB5850.namprd12.prod.outlook.com (2603:10b6:208:395::6)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Thu, 19 Jan\n 2023 04:59:22 +0000", "from CO1NAM11FT076.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:85:cafe::96) by MW4PR04CA0163.outlook.office365.com\n (2603:10b6:303:85::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25 via Frontend\n Transport; Thu, 19 Jan 2023 04:59:22 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT076.mail.protection.outlook.com (10.13.174.152) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6002.13 via Frontend Transport; Thu, 19 Jan 2023 04:59:21 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 18 Jan\n 2023 20:59:02 -0800", "from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 18 Jan\n 2023 20:59:00 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CyCmwwR2XliBivni0b4ekSI8jNM5cctQbpoDF+rhqc2gS+P2XA3LbeG+GWlmJGCDDOYwYbN6EdGX3ueJgl97lTIYgUB2DYTAHe4vfYh2xpSay/eIhX2vqlRBeVLaThuOkqtMLChdj2ae1db0L+I/rjYQzut4YA0NN1cD890s8MZzo6aCdasj3v9oKtaa1KEO9dQOBNp9aE4O4IQpBCzF+gjC4xCpUZJ3E9vrY50+n3CMtKRS1bj9mKY9pomO+MfIuK15JWF3j4fo+jU+cfECbp96AWiiib0BHmXfvRW0gO/tFvQ2cqSXKli3kkYHVSWVgqpJw2ldBGsFSfrQCZ3Ejg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=JexVsaSgu/22qoV30sz62/ycgRbfmwXUDeWQHk+bkWs=;\n b=Umax9Q9J0Ed2QL3QETYZz4adnCdzJ4i/spfs06mmUU5yGzmIz97CMLN0kQvUYTIER87kBfMM1b33nHLmAEsmi8Ojyay1Lr6TYSZcXhiC9rw4WFHM9uo7yGw1rCnvUonewzzOy1cmG4msBh6MfWD2CXXfGAxqfzo2BqzqWM8GRBYUzmczw+1pC1wcWpWv+lJM92Gp9gGxucJLLzigAalfWWiM7ibCiUrUet9jz3dCVi1xTEMApSUNM3FgMk+IW8EsYcI54ysrIpZsIuRfdc9envjPW7epxM95tdUkmbUsbpshedRSqjg8gVOUgva0T8SXEp0vGEMU8UCZLw0DR01KPA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=JexVsaSgu/22qoV30sz62/ycgRbfmwXUDeWQHk+bkWs=;\n b=RCf9dMXuRzdGeJnudMJPf9pVApYVCADOpRY+7z2kqGmGDayXqCcYw/nC6/BYtEvCaN4Ijusp5ITgfZM9iwBUL0r1zTNeZn9W0pEW4ts9cgGg7TsM9L/X3LJI0H//mRtAvA8QpHFMKzWiUUpt+A0NYeRGARfpLYnXWtCLifKieTDBVzkUGr47dgbRtWFgw6UFbp7BKIRjtN2pYFoWQd0dKOYcPgxUGB/1RVXUqfn5HbOJvfz/qziT9fLvvzK0cfnvQ4xFoMIW1GUr+mHFRV/OYj1JOPvVDK0r6Bz6/91B6hLoG4BtWy+dV9cZvFrQLjAooa4WNED0AAzGgS/t3CjjxA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Rongwei Liu <rongweil@nvidia.com>", "To": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,\n <thomas@monjalon.net>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang\n <yuying.zhang@intel.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>", "Subject": "[PATCH v2 09/11] app/testpmd: raw encap with flex item support", "Date": "Thu, 19 Jan 2023 06:58:22 +0200", "Message-ID": "<20230119045824.665663-10-rongweil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230119045824.665663-1-rongweil@nvidia.com>", "References": "<20221221084000.3680015-2-rongweil@nvidia.com>\n <20230119045824.665663-1-rongweil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.37]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT076:EE_|BL1PR12MB5850:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e877bcda-f896-42d9-88af-08daf9d9ed95", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n UBEgN/K45KkDuZl9dXt3yPGEMb5Phn023lcNO87i/DcIFP7du8iH0w3W9PbFA5Rq22YBqVmBAPftCZdsL6hjVBCdLobz5YwZ6pr8xaqBXlbPr7nJ5PalR+S7H03DZBYrBeadfro/K0elR6hlR0A6a1dJHpr1VUlYrrOwXv4OpMqFhRL03jvJgXH0eMtreVIP9lwZQdQzWqJJH1GwRel/wqdcI58kkQP/ltKdUmoxQe1xVjAqlPI6wbp+JDGF0e4ql/sIiuFWDy8uG/jjP75SOEUUjb4eL6c/8099mu0Szf/MscCiWYPI0gu587Mrkq+z9iKip0/9kujg5aN4HmyPVlypB62h5O1CyMipZl6gyo8Dv/6LPB2BYXRcgtriUgrcPEEBZf5ewPhnXQ268VcFopCv3xcpVhW/fpcfZr7ut/8TEJw6mh0q2QsMbScG+PIQKL0A+tHNQ2YsytjjfxFQBikfM++58znjVf1uBGUQ1zNQZSQLXV19Y7KS5yoMv/3goOhkYVnwvGJQrt7YaA7WqiBg7UCJC68dc6htqRfx64ss7TxUOuUkXspvnboz+xeDY+qkl2AHpPkbU1BZgKuPF4fCfvbM/NAFZfr5K/8bc0CZ7ggNiVZgjKGE0xrcsTZSB3VKLPvHhzzavjMuNxGS5+Je9cebdSF8DXArUdzWf/ppOumWHQ38lScMm9M/czp3pytUy8nBucHxtoLu3i6CpA==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(2906002)(478600001)(336012)(1076003)(36860700001)(7696005)(86362001)(41300700001)(5660300002)(8936002)(36756003)(70586007)(4326008)(70206006)(8676002)(83380400001)(426003)(82310400005)(6666004)(107886003)(186003)(26005)(55016003)(6286002)(16526019)(7636003)(2616005)(82740400003)(356005)(40460700003)(316002)(47076005)(54906003)(110136005)(40480700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Jan 2023 04:59:21.3534 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e877bcda-f896-42d9-88af-08daf9d9ed95", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT076.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL1PR12MB5850", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Application should retrieve raw_encap buffer from\nspec->pattern if it is flex item.\n\nSigned-off-by: Rongwei Liu <rongweil@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++---------\n 1 file changed, 17 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex f5d7a67def..50c8ec5594 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -11193,6 +11193,7 @@ cmd_set_raw_parsed(const struct buffer *in)\n \tuint16_t proto = 0;\n \tuint16_t idx = in->port; /* We borrow port field as index */\n \tint gtp_psc = -1; /* GTP PSC option index. */\n+\tconst void *src_spec;\n \n \tif (in->command == SET_SAMPLE_ACTIONS)\n \t\treturn cmd_set_raw_parsed_sample(in);\n@@ -11216,6 +11217,7 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\titem = in->args.vc.pattern + i;\n \t\tif (item->spec == NULL)\n \t\t\titem->spec = flow_item_default_mask(item);\n+\t\tsrc_spec = item->spec;\n \t\tswitch (item->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t\tsize = sizeof(struct rte_ether_hdr);\n@@ -11343,9 +11345,13 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\t\tsize = sizeof(struct rte_flow_item_pfcp);\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_FLEX:\n-\t\t\tsize = item->spec ?\n-\t\t\t\t((const struct rte_flow_item_flex *)\n-\t\t\t\titem->spec)->length : 0;\n+\t\t\tif (item->spec != NULL) {\n+\t\t\t\tsize = ((const struct rte_flow_item_flex *)item->spec)->length;\n+\t\t\t\tsrc_spec = ((const struct rte_flow_item_flex *)item->spec)->pattern;\n+\t\t\t} else {\n+\t\t\t\tsize = 0;\n+\t\t\t\tsrc_spec = NULL;\n+\t\t\t}\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_GRE_OPTION:\n \t\t\tsize = 0;\n@@ -11378,12 +11384,14 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\t\tfprintf(stderr, \"Error - Not supported item\\n\");\n \t\t\tgoto error;\n \t\t}\n-\t\t*total_size += size;\n-\t\trte_memcpy(data_tail - (*total_size), item->spec, size);\n-\t\t/* update some fields which cannot be set by cmdline */\n-\t\tupdate_fields((data_tail - (*total_size)), item,\n-\t\t\t upper_layer);\n-\t\tupper_layer = proto;\n+\t\tif (size) {\n+\t\t\t*total_size += size;\n+\t\t\trte_memcpy(data_tail - (*total_size), src_spec, size);\n+\t\t\t/* update some fields which cannot be set by cmdline */\n+\t\t\tupdate_fields((data_tail - (*total_size)), item,\n+\t\t\t\t upper_layer);\n+\t\t\tupper_layer = proto;\n+\t\t}\n \t}\n \tif (verbose_level & 0x1)\n \t\tprintf(\"total data size is %zu\\n\", (*total_size));\n", "prefixes": [ "v2", "09/11" ] }{ "id": 122344, "url": "