Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121909/?format=api
{ "id": 121909, "url": "https://patches.dpdk.org/api/patches/121909/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230112112140.807233-6-adwivedi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230112112140.807233-6-adwivedi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230112112140.807233-6-adwivedi@marvell.com", "date": "2023-01-12T11:21:39", "name": "[v5,5/6] ethdev: add trace points for mtr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "048372cb55aaffeaa728e7350c0a9409cbbbe5c3", "submitter": { "id": 1561, "url": "https://patches.dpdk.org/api/people/1561/?format=api", "name": "Ankur Dwivedi", "email": "adwivedi@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230112112140.807233-6-adwivedi@marvell.com/mbox/", "series": [ { "id": 26505, "url": "https://patches.dpdk.org/api/series/26505/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26505", "date": "2023-01-12T11:21:34", "name": "add trace points in ethdev library", "version": 5, "mbox": "https://patches.dpdk.org/series/26505/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121909/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/121909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A9D2423B5;\n\tThu, 12 Jan 2023 12:27:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F347742D22;\n\tThu, 12 Jan 2023 12:27:10 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 02EA640E25\n for <dev@dpdk.org>; Thu, 12 Jan 2023 12:27:08 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 30C9dqFN021078; Thu, 12 Jan 2023 03:24:51 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n1k56yswp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 12 Jan 2023 03:24:49 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 12 Jan 2023 03:24:37 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 12 Jan 2023 03:24:37 -0800", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id 47A353F70A0;\n Thu, 12 Jan 2023 03:24:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=IZLUMH46ygjVzc6J7Rhv7OXnZtVbKMipF5tv2RXkw/0=;\n b=QnNhY6VIVbV7+PQd4cm9PvAebWPB1SwibrwmNgR6fryf4PyvOjAnLPEBQPZ52cGYxw1u\n OUCMrIQrfPLS+lCC6FEA7cuTJuaGPoLIhDe2o5AS072RJ+jiK2idLiFmSmXH6nqeLV3i\n FviVY40SHQ6ucHHYpN/TMrUkA7faLHZCo3cbuNrI6VjbCrWnuNKUC0bLL6dL8CYto/Yo\n hq4ZkeFcF4rs+mMVXnzV0nwJ3H8jcwmKmUjb1MokQuDdoRlYytQIKbYKFJMjmxTJM4H9\n swq6/XXY2vQ00S2s7s/X/DTAdFaylPAbZtCLYs2kEbeTaquWb4wcVYqFc/ky9oK4T+DY Aw==", "From": "Ankur Dwivedi <adwivedi@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,\n <orika@nvidia.com>, <ferruh.yigit@amd.com>, <chas3@att.com>,\n <humin29@huawei.com>, <linville@tuxdriver.com>,\n <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>, <mw@semihalf.com>,\n <mk@semihalf.com>, <shaibran@amazon.com>, <evgenys@amazon.com>,\n <igorch@amazon.com>, <chandu@amd.com>, <irusskikh@marvell.com>,\n <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,\n <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,\n <somnath.kotur@broadcom.com>, <jerinj@marvell.com>,\n <mczekaj@marvell.com>, <sthotton@marvell.com>,\n <srinivasan@marvell.com>, <hkalra@marvell.com>,\n <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>,\n <hyonkim@cisco.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>,\n <cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,\n <simei.su@intel.com>, <wenjun1.wu@intel.com>, <qiming.yang@intel.com>,\n <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,\n <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>,\n <junfeng.guo@intel.com>, <rosen.xu@intel.com>,\n <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,\n <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>,\n <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>,\n <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <longli@microsoft.com>, <spinler@cesnet.cz>,\n <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>,\n <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>,\n <g.singh@nxp.com>, <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>,\n <aboyer@pensando.io>, <rmody@marvell.com>, <shshaikh@marvell.com>,\n <dsinghrawat@marvell.com>, <andrew.rybchenko@oktetlabs.ru>,\n <jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>,\n <jbehrens@vmware.com>, <maxime.coquelin@redhat.com>,\n <chenbo.xia@intel.com>, <steven.webster@windriver.com>,\n <matt.peters@windriver.com>, <bruce.richardson@intel.com>,\n <mtetsuyah@gmail.com>, <grive@u256.net>, <jasvinder.singh@intel.com>,\n <cristian.dumitrescu@intel.com>, <jgrajcia@cisco.com>,\n <mb@smartsharesystems.com>, Ankur Dwivedi <adwivedi@marvell.com>", "Subject": "[PATCH v5 5/6] ethdev: add trace points for mtr", "Date": "Thu, 12 Jan 2023 16:51:39 +0530", "Message-ID": "<20230112112140.807233-6-adwivedi@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230112112140.807233-1-adwivedi@marvell.com>", "References": "<20221222063306.3383695-1-adwivedi@marvell.com>\n <20230112112140.807233-1-adwivedi@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "VEm4F8zrn1lmIWlqDzizC4CCKAowhAXe", "X-Proofpoint-GUID": "VEm4F8zrn1lmIWlqDzizC4CCKAowhAXe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2023-01-12_07,2023-01-12_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adds trace points for rte_mtr specific functions in ethdev lib.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\n---\n lib/ethdev/ethdev_trace_points.c | 63 +++++++++++++\n lib/ethdev/rte_ethdev_trace.h | 112 ++++++++++++++++++++++\n lib/ethdev/rte_ethdev_trace_fp.h | 100 ++++++++++++++++++++\n lib/ethdev/rte_mtr.c | 156 +++++++++++++++++++++++++++----\n lib/ethdev/version.map | 21 +++++\n 5 files changed, 434 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/ethdev/ethdev_trace_points.c b/lib/ethdev/ethdev_trace_points.c\nindex 1953d90a5a..067e5fdab4 100644\n--- a/lib/ethdev/ethdev_trace_points.c\n+++ b/lib/ethdev/ethdev_trace_points.c\n@@ -591,3 +591,66 @@ RTE_TRACE_POINT_REGISTER(rte_flow_trace_async_action_handle_update,\n \n RTE_TRACE_POINT_REGISTER(rte_flow_trace_async_action_handle_query,\n \tlib.ethdev.flow.async.action.handle.query)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_capabilities_get,\n+\tlib.ethdev.mtr.capabilities_get)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_create,\n+\tlib.ethdev.mtr.create)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_destroy,\n+\tlib.ethdev.mtr.destroy)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_disable,\n+\tlib.ethdev.mtr.meter_disable)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_dscp_table_update,\n+\tlib.ethdev.mtr.meter_dscp_table_update)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_enable,\n+\tlib.ethdev.mtr.meter_enable)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_profile_add,\n+\tlib.ethdev.mtr.meter_profile_add)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_profile_delete,\n+\tlib.ethdev.mtr.meter_profile_delete)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_profile_get,\n+\tlib.ethdev.mtr.meter_profile_get)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_profile_update,\n+\tlib.ethdev.mtr.meter_profile_update)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_stats_read,\n+\tlib.ethdev.mtr.stats_read)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_stats_update,\n+\tlib.ethdev.mtr.stats_update)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_policy_add,\n+\tlib.ethdev.mtr.meter_policy_add)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_policy_delete,\n+\tlib.ethdev.mtr.meter_policy_delete)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_policy_get,\n+\tlib.ethdev.mtr.meter_policy_get)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_policy_update,\n+\tlib.ethdev.mtr.meter_policy_update)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_policy_validate,\n+\tlib.ethdev.mtr.meter_policy_validate)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_meter_vlan_table_update,\n+\tlib.ethdev.mtr.meter_vlan_table_update)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_color_in_protocol_get,\n+\tlib.ethdev.mtr.color_in_protocol_get)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_color_in_protocol_priority_get,\n+\tlib.ethdev.mtr.color_in_protocol_priority_get)\n+\n+RTE_TRACE_POINT_REGISTER(rte_mtr_trace_color_in_protocol_set,\n+\tlib.ethdev.mtr.color_in_protocol_set)\ndiff --git a/lib/ethdev/rte_ethdev_trace.h b/lib/ethdev/rte_ethdev_trace.h\nindex 5bf7ffec6c..71994a9ab4 100644\n--- a/lib/ethdev/rte_ethdev_trace.h\n+++ b/lib/ethdev/rte_ethdev_trace.h\n@@ -18,6 +18,7 @@ extern \"C\" {\n #include <rte_trace_point.h>\n \n #include \"rte_ethdev.h\"\n+#include \"rte_mtr.h\"\n \n RTE_TRACE_POINT(\n \trte_ethdev_trace_configure,\n@@ -1285,6 +1286,117 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_int(ret);\n )\n \n+RTE_TRACE_POINT(\n+\trte_mtr_trace_capabilities_get,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id,\n+\t\tstruct rte_mtr_capabilities *cap, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_ptr(cap);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_create,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tstruct rte_mtr_params *params, int shared, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_ptr(params);\n+\trte_trace_point_emit_u32(params->meter_profile_id);\n+\trte_trace_point_emit_int(params->use_prev_mtr_color);\n+\trte_trace_point_emit_int(params->meter_enable);\n+\trte_trace_point_emit_u64(params->stats_mask);\n+\trte_trace_point_emit_u32(params->meter_policy_id);\n+\trte_trace_point_emit_int(params->default_input_color);\n+\trte_trace_point_emit_int(shared);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_destroy,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_disable,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_enable,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_profile_add,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id,\n+\t\tuint32_t meter_profile_id,\n+\t\tstruct rte_mtr_meter_profile *profile, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(meter_profile_id);\n+\trte_trace_point_emit_int(profile->alg);\n+\trte_trace_point_emit_int(profile->packet_mode);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_profile_delete,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id,\n+\t\tuint32_t meter_profile_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(meter_profile_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_policy_add,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t policy_id,\n+\t\tconst struct rte_flow_action *actions),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(policy_id);\n+\trte_trace_point_emit_ptr(actions);\n+\trte_trace_point_emit_int(actions->type);\n+\trte_trace_point_emit_ptr(actions->conf);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_policy_delete,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t policy_id),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(policy_id);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_meter_policy_validate,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id,\n+\t\tconst struct rte_flow_action *actions),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_ptr(actions);\n+\trte_trace_point_emit_int(actions->type);\n+\trte_trace_point_emit_ptr(actions->conf);\n+)\n+\n+RTE_TRACE_POINT(\n+\trte_mtr_trace_color_in_protocol_set,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tenum rte_mtr_color_in_protocol proto, uint32_t priority,\n+\t\tint ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(proto);\n+\trte_trace_point_emit_u32(priority);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/ethdev/rte_ethdev_trace_fp.h b/lib/ethdev/rte_ethdev_trace_fp.h\nindex 57b98a3994..d7ab85f938 100644\n--- a/lib/ethdev/rte_ethdev_trace_fp.h\n+++ b/lib/ethdev/rte_ethdev_trace_fp.h\n@@ -18,6 +18,7 @@ extern \"C\" {\n #include <rte_trace_point.h>\n \n #include \"rte_ethdev.h\"\n+#include \"rte_mtr.h\"\n \n RTE_TRACE_POINT_FP(\n \trte_eth_trace_call_rx_callbacks,\n@@ -759,6 +760,105 @@ RTE_TRACE_POINT_FP(\n \trte_trace_point_emit_int(ret);\n )\n \n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_profile_get,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id,\n+\t\tuint32_t meter_profile_id, void *ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(meter_profile_id);\n+\trte_trace_point_emit_ptr(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_policy_get,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t policy_id,\n+\t\tvoid *ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(policy_id);\n+\trte_trace_point_emit_ptr(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_profile_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tuint32_t meter_profile_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_u32(meter_profile_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_policy_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tuint32_t meter_policy_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_u32(meter_policy_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_dscp_table_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tenum rte_color *dscp_table, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_ptr(dscp_table);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_meter_vlan_table_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tenum rte_color *vlan_table, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_ptr(vlan_table);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_color_in_protocol_get,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_color_in_protocol_priority_get,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tenum rte_mtr_color_in_protocol proto, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_int(proto);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_stats_read,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tstruct rte_mtr_stats *stats, uint64_t *stats_mask,\n+\t\tint clear, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_ptr(stats);\n+\trte_trace_point_emit_ptr(stats_mask);\n+\trte_trace_point_emit_int(clear);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n+RTE_TRACE_POINT_FP(\n+\trte_mtr_trace_stats_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t mtr_id,\n+\t\tuint64_t stats_mask, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(mtr_id);\n+\trte_trace_point_emit_u64(stats_mask);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/ethdev/rte_mtr.c b/lib/ethdev/rte_mtr.c\nindex 3954839531..da092cd939 100644\n--- a/lib/ethdev/rte_mtr.c\n+++ b/lib/ethdev/rte_mtr.c\n@@ -6,6 +6,8 @@\n \n #include <rte_errno.h>\n #include \"rte_ethdev.h\"\n+#include \"rte_ethdev_trace.h\"\n+#include \"rte_ethdev_trace_fp.h\"\n #include \"rte_mtr_driver.h\"\n #include \"rte_mtr.h\"\n \n@@ -82,8 +84,14 @@ rte_mtr_capabilities_get(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, capabilities_get)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, capabilities_get)(dev,\n \t\tcap, error);\n+\n+\trte_mtr_trace_capabilities_get(port_id, cap, ret);\n+\n+\treturn ret;\n }\n \n /* MTR meter profile add */\n@@ -94,8 +102,14 @@ rte_mtr_meter_profile_add(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_profile_add)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_profile_add)(dev,\n \t\tmeter_profile_id, profile, error);\n+\n+\trte_mtr_trace_meter_profile_add(port_id, meter_profile_id, profile, ret);\n+\n+\treturn ret;\n }\n \n /** MTR meter profile delete */\n@@ -105,8 +119,14 @@ rte_mtr_meter_profile_delete(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_profile_delete)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_profile_delete)(dev,\n \t\tmeter_profile_id, error);\n+\n+\trte_mtr_trace_meter_profile_delete(port_id, meter_profile_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR meter profile get */\n@@ -116,8 +136,14 @@ rte_mtr_meter_profile_get(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_HNDL_FUNC(port_id, meter_profile_get)(dev,\n+\tstruct rte_flow_meter_profile *ret;\n+\n+\tret = RTE_MTR_HNDL_FUNC(port_id, meter_profile_get)(dev,\n \t\tmeter_profile_id, error);\n+\n+\trte_mtr_trace_meter_profile_get(port_id, meter_profile_id, ret);\n+\n+\treturn ret;\n }\n \n /* MTR meter policy validate */\n@@ -127,6 +153,10 @@ rte_mtr_meter_policy_validate(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\tint i;\n+\n+\tfor (i = 0; i < RTE_COLORS; i++)\n+\t\trte_mtr_trace_meter_policy_validate(port_id, policy->actions[i]);\n \treturn RTE_MTR_FUNC(port_id, meter_policy_validate)(dev,\n \t\tpolicy, error);\n }\n@@ -139,6 +169,11 @@ rte_mtr_meter_policy_add(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\tint i;\n+\n+\tfor (i = 0; i < RTE_COLORS; i++)\n+\t\trte_mtr_trace_meter_policy_add(port_id, policy_id,\n+\t\t\t\t\t policy->actions[i]);\n \treturn RTE_MTR_FUNC(port_id, meter_policy_add)(dev,\n \t\tpolicy_id, policy, error);\n }\n@@ -150,6 +185,7 @@ rte_mtr_meter_policy_delete(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\trte_mtr_trace_meter_policy_delete(port_id, policy_id);\n \treturn RTE_MTR_FUNC(port_id, meter_policy_delete)(dev,\n \t\tpolicy_id, error);\n }\n@@ -161,8 +197,14 @@ rte_mtr_meter_policy_get(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_HNDL_FUNC(port_id, meter_policy_get)(dev,\n+\tstruct rte_flow_meter_policy *ret;\n+\n+\tret = RTE_MTR_HNDL_FUNC(port_id, meter_policy_get)(dev,\n \t\tpolicy_id, error);\n+\n+\trte_mtr_trace_meter_policy_get(port_id, policy_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object create */\n@@ -174,8 +216,14 @@ rte_mtr_create(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, create)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, create)(dev,\n \t\tmtr_id, params, shared, error);\n+\n+\trte_mtr_trace_create(port_id, mtr_id, params, shared, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object destroy */\n@@ -185,8 +233,14 @@ rte_mtr_destroy(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, destroy)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, destroy)(dev,\n \t\tmtr_id, error);\n+\n+\trte_mtr_trace_destroy(port_id, mtr_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter enable */\n@@ -196,8 +250,14 @@ rte_mtr_meter_enable(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_enable)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_enable)(dev,\n \t\tmtr_id, error);\n+\n+\trte_mtr_trace_meter_enable(port_id, mtr_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter disable */\n@@ -207,8 +267,14 @@ rte_mtr_meter_disable(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_disable)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_disable)(dev,\n \t\tmtr_id, error);\n+\n+\trte_mtr_trace_meter_disable(port_id, mtr_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter profile update */\n@@ -219,8 +285,14 @@ rte_mtr_meter_profile_update(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_profile_update)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_profile_update)(dev,\n \t\tmtr_id, meter_profile_id, error);\n+\n+\trte_mtr_trace_meter_profile_update(port_id, mtr_id, meter_profile_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter policy update */\n@@ -231,8 +303,14 @@ rte_mtr_meter_policy_update(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_policy_update)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_policy_update)(dev,\n \t\tmtr_id, meter_policy_id, error);\n+\n+\trte_mtr_trace_meter_policy_update(port_id, mtr_id, meter_policy_id, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter DSCP table update */\n@@ -243,8 +321,14 @@ rte_mtr_meter_dscp_table_update(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_dscp_table_update)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_dscp_table_update)(dev,\n \t\tmtr_id, proto, dscp_table, error);\n+\n+\trte_mtr_trace_meter_dscp_table_update(port_id, mtr_id, dscp_table, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object meter VLAN table update */\n@@ -255,8 +339,14 @@ rte_mtr_meter_vlan_table_update(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, meter_vlan_table_update)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, meter_vlan_table_update)(dev,\n \t\tmtr_id, proto, vlan_table, error);\n+\n+\trte_mtr_trace_meter_vlan_table_update(port_id, mtr_id, vlan_table, ret);\n+\n+\treturn ret;\n }\n \n /** Set the input color protocol on MTR object */\n@@ -268,8 +358,14 @@ rte_mtr_color_in_protocol_set(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, in_proto_set)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, in_proto_set)(dev,\n \t\tmtr_id, proto, priority, error);\n+\n+\trte_mtr_trace_color_in_protocol_set(port_id, mtr_id, proto, priority, ret);\n+\n+\treturn ret;\n }\n \n /** Get input color protocols of MTR object */\n@@ -280,8 +376,14 @@ rte_mtr_color_in_protocol_get(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, in_proto_get)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, in_proto_get)(dev,\n \t\tmtr_id, proto_mask, error);\n+\n+\trte_mtr_trace_color_in_protocol_get(port_id, mtr_id, ret);\n+\n+\treturn ret;\n }\n \n /** Get input color protocol priority of MTR object */\n@@ -293,8 +395,14 @@ rte_mtr_color_in_protocol_priority_get(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, in_proto_prio_get)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, in_proto_prio_get)(dev,\n \t\tmtr_id, proto, priority, error);\n+\n+\trte_mtr_trace_color_in_protocol_priority_get(port_id, mtr_id, proto, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object enabled stats update */\n@@ -305,8 +413,14 @@ rte_mtr_stats_update(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, stats_update)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, stats_update)(dev,\n \t\tmtr_id, stats_mask, error);\n+\n+\trte_mtr_trace_stats_update(port_id, mtr_id, stats_mask, ret);\n+\n+\treturn ret;\n }\n \n /** MTR object stats read */\n@@ -319,6 +433,12 @@ rte_mtr_stats_read(uint16_t port_id,\n \tstruct rte_mtr_error *error)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n-\treturn RTE_MTR_FUNC(port_id, stats_read)(dev,\n+\tint ret;\n+\n+\tret = RTE_MTR_FUNC(port_id, stats_read)(dev,\n \t\tmtr_id, stats, stats_mask, clear, error);\n+\n+\trte_mtr_trace_stats_read(port_id, mtr_id, stats, stats_mask, clear, ret);\n+\n+\treturn ret;\n }\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex 0cb8222ad9..c1a6e4d30a 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -482,6 +482,27 @@ EXPERIMENTAL {\n \t__rte_flow_trace_tunnel_item_release;\n \t__rte_flow_trace_tunnel_match;\n \t__rte_flow_trace_validate;\n+\t__rte_mtr_trace_capabilities_get;\n+\t__rte_mtr_trace_color_in_protocol_get;\n+\t__rte_mtr_trace_color_in_protocol_priority_get;\n+\t__rte_mtr_trace_color_in_protocol_set;\n+\t__rte_mtr_trace_create;\n+\t__rte_mtr_trace_destroy;\n+\t__rte_mtr_trace_meter_disable;\n+\t__rte_mtr_trace_meter_dscp_table_update;\n+\t__rte_mtr_trace_meter_enable;\n+\t__rte_mtr_trace_meter_policy_add;\n+\t__rte_mtr_trace_meter_policy_delete;\n+\t__rte_mtr_trace_meter_policy_get;\n+\t__rte_mtr_trace_meter_policy_update;\n+\t__rte_mtr_trace_meter_policy_validate;\n+\t__rte_mtr_trace_meter_profile_add;\n+\t__rte_mtr_trace_meter_profile_delete;\n+\t__rte_mtr_trace_meter_profile_get;\n+\t__rte_mtr_trace_meter_profile_update;\n+\t__rte_mtr_trace_meter_vlan_table_update;\n+\t__rte_mtr_trace_stats_read;\n+\t__rte_mtr_trace_stats_update;\n };\n \n INTERNAL {\n", "prefixes": [ "v5", "5/6" ] }