Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121905/?format=api
{ "id": 121905, "url": "https://patches.dpdk.org/api/patches/121905/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230112112140.807233-2-adwivedi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230112112140.807233-2-adwivedi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230112112140.807233-2-adwivedi@marvell.com", "date": "2023-01-12T11:21:35", "name": "[v5,1/6] eal: trace: add trace point emit for blob", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dab1f36d23094df76d224600f0b211feec95f638", "submitter": { "id": 1561, "url": "https://patches.dpdk.org/api/people/1561/?format=api", "name": "Ankur Dwivedi", "email": "adwivedi@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230112112140.807233-2-adwivedi@marvell.com/mbox/", "series": [ { "id": 26505, "url": "https://patches.dpdk.org/api/series/26505/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26505", "date": "2023-01-12T11:21:34", "name": "add trace points in ethdev library", "version": 5, "mbox": "https://patches.dpdk.org/series/26505/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121905/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/121905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C296423B5;\n\tThu, 12 Jan 2023 12:25:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0D9AB40E25;\n\tThu, 12 Jan 2023 12:25:00 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 2C2C842D2D\n for <dev@dpdk.org>; Thu, 12 Jan 2023 12:24:58 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 30C9dqx8021107; Thu, 12 Jan 2023 03:22:41 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n1k56ysn4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 12 Jan 2023 03:22:41 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 12 Jan 2023 03:22:39 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 12 Jan 2023 03:22:39 -0800", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id EAEA93F7083;\n Thu, 12 Jan 2023 03:22:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=pS5WEZTyfsEIy5mGNXtItslR0RFVGQpow6Zc3P6sG7I=;\n b=cu51pynIaWNSJKf+KXQovbO3dlv8nzeUoPDwsQ40YX4+dvtK7FxRtNJsYXn01Pfk/kgA\n XhCBhYUuzCywOmyt4MUwI03sJJZbahK5Ma9ebOnZJQP07cenB3hiUyOVheyBhWnjXwaz\n 2TOn9ZxyTsJ3l5LT5tGe0owpJhyIZgEiMeB6OH9f4Z32C9GlcSXiGVY266opxRiNn1u2\n XaD++SB5i6onvFV79mw3A/aIWFDE4Gskl87LSaOcrTHBgYxeByfOGGN6RCao9jbgZCB5\n zH9SK64WsI368yoZmJIOHK3ou015K6Js9DE2olzgV1QFKkHcmQKt8S4H18GH7AQFPG0P xA==", "From": "Ankur Dwivedi <adwivedi@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,\n <orika@nvidia.com>, <ferruh.yigit@amd.com>, <chas3@att.com>,\n <humin29@huawei.com>, <linville@tuxdriver.com>,\n <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>, <mw@semihalf.com>,\n <mk@semihalf.com>, <shaibran@amazon.com>, <evgenys@amazon.com>,\n <igorch@amazon.com>, <chandu@amd.com>, <irusskikh@marvell.com>,\n <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,\n <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,\n <somnath.kotur@broadcom.com>, <jerinj@marvell.com>,\n <mczekaj@marvell.com>, <sthotton@marvell.com>,\n <srinivasan@marvell.com>, <hkalra@marvell.com>,\n <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>,\n <hyonkim@cisco.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>,\n <cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,\n <simei.su@intel.com>, <wenjun1.wu@intel.com>, <qiming.yang@intel.com>,\n <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,\n <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>,\n <junfeng.guo@intel.com>, <rosen.xu@intel.com>,\n <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,\n <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>,\n <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>,\n <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <longli@microsoft.com>, <spinler@cesnet.cz>,\n <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>,\n <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>,\n <g.singh@nxp.com>, <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>,\n <aboyer@pensando.io>, <rmody@marvell.com>, <shshaikh@marvell.com>,\n <dsinghrawat@marvell.com>, <andrew.rybchenko@oktetlabs.ru>,\n <jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>,\n <jbehrens@vmware.com>, <maxime.coquelin@redhat.com>,\n <chenbo.xia@intel.com>, <steven.webster@windriver.com>,\n <matt.peters@windriver.com>, <bruce.richardson@intel.com>,\n <mtetsuyah@gmail.com>, <grive@u256.net>, <jasvinder.singh@intel.com>,\n <cristian.dumitrescu@intel.com>, <jgrajcia@cisco.com>,\n <mb@smartsharesystems.com>, Ankur Dwivedi <adwivedi@marvell.com>", "Subject": "[PATCH v5 1/6] eal: trace: add trace point emit for blob", "Date": "Thu, 12 Jan 2023 16:51:35 +0530", "Message-ID": "<20230112112140.807233-2-adwivedi@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230112112140.807233-1-adwivedi@marvell.com>", "References": "<20221222063306.3383695-1-adwivedi@marvell.com>\n <20230112112140.807233-1-adwivedi@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "8k1Zc14POlcWItFFYh3QfDuPl7cwOzIP", "X-Proofpoint-GUID": "8k1Zc14POlcWItFFYh3QfDuPl7cwOzIP", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2023-01-12_07,2023-01-12_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adds a trace point emit function for emitting a blob. The maximum blob\nbytes which can be captured is maximum value contained in uint16_t,\nwhich is 65535.\n\nAlso adds test case for emit array tracepoint function.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\n---\n app/test/test_trace.c | 5 +++++\n lib/eal/common/eal_common_trace_points.c | 2 ++\n lib/eal/include/rte_eal_trace.h | 6 ++++++\n lib/eal/include/rte_trace_point.h | 17 +++++++++++++++++\n lib/eal/include/rte_trace_point_register.h | 7 +++++++\n lib/eal/version.map | 3 +++\n 6 files changed, 40 insertions(+)", "diff": "diff --git a/app/test/test_trace.c b/app/test/test_trace.c\nindex 6bedf14024..cf781dc25b 100644\n--- a/app/test/test_trace.c\n+++ b/app/test/test_trace.c\n@@ -4,6 +4,7 @@\n \n #include <rte_eal_trace.h>\n #include <rte_lcore.h>\n+#include <rte_random.h>\n #include <rte_trace.h>\n \n #include \"test.h\"\n@@ -177,6 +178,7 @@ test_fp_trace_points(void)\n static int\n test_generic_trace_points(void)\n {\n+\tuint8_t arr[32] = {0};\n \tint tmp;\n \n \trte_eal_trace_generic_void();\n@@ -195,6 +197,9 @@ test_generic_trace_points(void)\n \trte_eal_trace_generic_ptr(&tmp);\n \trte_eal_trace_generic_str(\"my string\");\n \trte_eal_trace_generic_size_t(sizeof(void *));\n+\trte_eal_trace_generic_blob(arr, 17);\n+\trte_eal_trace_generic_blob(arr, 32);\n+\trte_eal_trace_generic_blob(arr, rte_rand() % 32);\n \tRTE_EAL_TRACE_GENERIC_FUNC;\n \n \treturn TEST_SUCCESS;\ndiff --git a/lib/eal/common/eal_common_trace_points.c b/lib/eal/common/eal_common_trace_points.c\nindex 0b0b254615..051f89809c 100644\n--- a/lib/eal/common/eal_common_trace_points.c\n+++ b/lib/eal/common/eal_common_trace_points.c\n@@ -40,6 +40,8 @@ RTE_TRACE_POINT_REGISTER(rte_eal_trace_generic_size_t,\n \tlib.eal.generic.size_t)\n RTE_TRACE_POINT_REGISTER(rte_eal_trace_generic_func,\n \tlib.eal.generic.func)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_generic_blob,\n+\tlib.eal.generic.blob)\n \n RTE_TRACE_POINT_REGISTER(rte_eal_trace_alarm_set,\n \tlib.eal.alarm.set)\ndiff --git a/lib/eal/include/rte_eal_trace.h b/lib/eal/include/rte_eal_trace.h\nindex 5ef4398230..02e3a564a1 100644\n--- a/lib/eal/include/rte_eal_trace.h\n+++ b/lib/eal/include/rte_eal_trace.h\n@@ -143,6 +143,12 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_string(func);\n )\n \n+RTE_TRACE_POINT(\n+\trte_eal_trace_generic_blob,\n+\tRTE_TRACE_POINT_ARGS(void *in, uint16_t len),\n+\trte_trace_point_emit_blob(in, len);\n+)\n+\n #define RTE_EAL_TRACE_GENERIC_FUNC rte_eal_trace_generic_func(__func__)\n \n /* Interrupt */\ndiff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h\nindex 0f8700974f..21b6bf7bf6 100644\n--- a/lib/eal/include/rte_trace_point.h\n+++ b/lib/eal/include/rte_trace_point.h\n@@ -144,6 +144,8 @@ _tp _args \\\n #define rte_trace_point_emit_ptr(val)\n /** Tracepoint function payload for string datatype */\n #define rte_trace_point_emit_string(val)\n+/** Tracepoint function payload for char array */\n+#define rte_trace_point_emit_blob(val, len)\n \n #endif /* __DOXYGEN__ */\n \n@@ -374,12 +376,27 @@ do { \\\n \tmem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX); \\\n } while (0)\n \n+#define rte_trace_point_emit_blob(in, len) \\\n+do { \\\n+\tif (unlikely(in == NULL)) \\\n+\t\treturn; \\\n+\t__rte_trace_point_emit(len, uint16_t); \\\n+\tmemcpy(mem, in, len); \\\n+\tmem = RTE_PTR_ADD(mem, len); \\\n+} while (0)\n+\n #else\n \n #define __rte_trace_point_emit_header_generic(t) RTE_SET_USED(t)\n #define __rte_trace_point_emit_header_fp(t) RTE_SET_USED(t)\n #define __rte_trace_point_emit(in, type) RTE_SET_USED(in)\n #define rte_trace_point_emit_string(in) RTE_SET_USED(in)\n+#define rte_trace_point_emit_blob(in, len) \\\n+do { \\\n+\tRTE_SET_USED(in); \\\n+\tRTE_SET_USED(len); \\\n+} while (0)\n+\n \n #endif /* ALLOW_EXPERIMENTAL_API */\n #endif /* _RTE_TRACE_POINT_REGISTER_H_ */\ndiff --git a/lib/eal/include/rte_trace_point_register.h b/lib/eal/include/rte_trace_point_register.h\nindex a32f4d731b..a54f9769da 100644\n--- a/lib/eal/include/rte_trace_point_register.h\n+++ b/lib/eal/include/rte_trace_point_register.h\n@@ -47,6 +47,13 @@ do { \\\n \t\tRTE_STR(in)\"[32]\", \"string_bounded_t\"); \\\n } while (0)\n \n+#define rte_trace_point_emit_blob(in, len) \\\n+do { \\\n+\tRTE_SET_USED(in); \\\n+\t__rte_trace_point_emit(len, uint16_t); \\\n+\t__rte_trace_point_emit_field(len, RTE_STR(in)\"[\"#len\"]\", RTE_STR(uint8_t)); \\\n+} while (0)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 7ad12a7dc9..67be24686a 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -440,6 +440,9 @@ EXPERIMENTAL {\n \trte_thread_detach;\n \trte_thread_equal;\n \trte_thread_join;\n+\n+\t# added in 23.03\n+\t__rte_eal_trace_generic_blob;\n };\n \n INTERNAL {\n", "prefixes": [ "v5", "1/6" ] }