Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121815/?format=api
{ "id": 121815, "url": "https://patches.dpdk.org/api/patches/121815/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230111071545.504706-7-mingxia.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230111071545.504706-7-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230111071545.504706-7-mingxia.liu@intel.com", "date": "2023-01-11T07:15:45", "name": "[v2,6/6] common/idpf: add xstats ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7e64132456fa356df125b9fcaf6aafcd2d397e88", "submitter": { "id": 2514, "url": "https://patches.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230111071545.504706-7-mingxia.liu@intel.com/mbox/", "series": [ { "id": 26469, "url": "https://patches.dpdk.org/api/series/26469/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26469", "date": "2023-01-11T07:15:39", "name": "add idpf pmd enhancement features", "version": 1, "mbox": "https://patches.dpdk.org/series/26469/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121815/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/121815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33864423AA;\n\tWed, 11 Jan 2023 09:13:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC96F42D3A;\n\tWed, 11 Jan 2023 09:13:10 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 4522342D23\n for <dev@dpdk.org>; Wed, 11 Jan 2023 09:13:09 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jan 2023 00:13:08 -0800", "from dpdk-mingxial-01.sh.intel.com ([10.67.119.112])\n by orsmga005.jf.intel.com with ESMTP; 11 Jan 2023 00:13:07 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673424789; x=1704960789;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=IDoUf6IqNbs8MTx9OdlOabiEsE2vYbR4Qo0i+ADc0k4=;\n b=IhSgc9UYocylo+rWeXbgceYALSfyIozPghr/BbAX72e9qQmpMl/zvkSO\n BslEpbl7wT8pTfXJnT3VcelmfHpSwTcOKtWt/MMbXKJ7in0dj/futnJWp\n Aoec/5jjqA+aAl0BzseX5qRC3m4esEOY/EfQ/P3EP3NRk0/uXimQcXeMZ\n 5tuknMwYmtVdha5lz0Tmn1t1CFNlTd7XP6MpslGJEVeA9IdKoZh1339Wt\n Wuw6zETCEQ6wF49Wf1CC/MORbYkZOMFqkttBfExAMjGBcREsY9AVOu3E4\n IQHAiTOBQWWrcYLBVQ4fHcLNnzKKJB5B9rquFVbn0NmqaPYiH+p9qNyfF A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10586\"; a=\"311167503\"", "E=Sophos;i=\"5.96,315,1665471600\"; d=\"scan'208\";a=\"311167503\"", "E=McAfee;i=\"6500,9779,10586\"; a=\"831271436\"", "E=Sophos;i=\"5.96,315,1665471600\"; d=\"scan'208\";a=\"831271436\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, beilei.xing@intel.com,\n Mingxia Liu <mingxia.liu@intel.com>", "Subject": "[PATCH v2 6/6] common/idpf: add xstats ops", "Date": "Wed, 11 Jan 2023 07:15:45 +0000", "Message-Id": "<20230111071545.504706-7-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230111071545.504706-1-mingxia.liu@intel.com>", "References": "<20221216093706.2453812-1-mingxia.liu@intel.com>\n <20230111071545.504706-1-mingxia.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for these device ops:\n-idpf_dev_xstats_get\n-idpf_dev_xstats_get_names\n-idpf_dev_xstats_reset\n\nSigned-off-by: Mingxia Liu <mingxia.liu@intel.com>\n---\n drivers/net/idpf/idpf_ethdev.c | 80 ++++++++++++++++++++++++++++++++++\n 1 file changed, 80 insertions(+)", "diff": "diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex b86f63f94e..bcd15db3c5 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -80,6 +80,30 @@ static const uint64_t idpf_ipv6_rss = RTE_ETH_RSS_NONFRAG_IPV6_UDP |\n \t\t\t RTE_ETH_RSS_NONFRAG_IPV6_OTHER |\n \t\t\t RTE_ETH_RSS_FRAG_IPV6;\n \n+struct rte_idpf_xstats_name_off {\n+\tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n+\tunsigned int offset;\n+};\n+\n+static const struct rte_idpf_xstats_name_off rte_idpf_stats_strings[] = {\n+\t{\"rx_bytes\", offsetof(struct virtchnl2_vport_stats, rx_bytes)},\n+\t{\"rx_unicast_packets\", offsetof(struct virtchnl2_vport_stats, rx_unicast)},\n+\t{\"rx_multicast_packets\", offsetof(struct virtchnl2_vport_stats, rx_multicast)},\n+\t{\"rx_broadcast_packets\", offsetof(struct virtchnl2_vport_stats, rx_broadcast)},\n+\t{\"rx_dropped_packets\", offsetof(struct virtchnl2_vport_stats, rx_discards)},\n+\t{\"rx_errors\", offsetof(struct virtchnl2_vport_stats, rx_errors)},\n+\t{\"rx_unknown_protocol_packets\", offsetof(struct virtchnl2_vport_stats,\n+\t\t\t\t\t\t rx_unknown_protocol)},\n+\t{\"tx_bytes\", offsetof(struct virtchnl2_vport_stats, tx_bytes)},\n+\t{\"tx_unicast_packets\", offsetof(struct virtchnl2_vport_stats, tx_unicast)},\n+\t{\"tx_multicast_packets\", offsetof(struct virtchnl2_vport_stats, tx_multicast)},\n+\t{\"tx_broadcast_packets\", offsetof(struct virtchnl2_vport_stats, tx_broadcast)},\n+\t{\"tx_dropped_packets\", offsetof(struct virtchnl2_vport_stats, tx_discards)},\n+\t{\"tx_error_packets\", offsetof(struct virtchnl2_vport_stats, tx_errors)}};\n+\n+#define IDPF_NB_XSTATS (sizeof(rte_idpf_stats_strings) / \\\n+\t\tsizeof(rte_idpf_stats_strings[0]))\n+\n static int\n idpf_dev_link_update(struct rte_eth_dev *dev,\n \t\t __rte_unused int wait_to_complete)\n@@ -312,6 +336,59 @@ idpf_dev_stats_reset(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int idpf_dev_xstats_reset(struct rte_eth_dev *dev)\n+{\n+\tidpf_dev_stats_reset(dev);\n+\treturn 0;\n+}\n+\n+static int idpf_dev_xstats_get(struct rte_eth_dev *dev,\n+\t\t\t struct rte_eth_xstat *xstats, unsigned int n)\n+{\n+\tstruct idpf_vport *vport =\n+\t\t(struct idpf_vport *)dev->data->dev_private;\n+\tstruct virtchnl2_vport_stats *pstats = NULL;\n+\tunsigned int i;\n+\tint ret;\n+\n+\tif (n < IDPF_NB_XSTATS)\n+\t\treturn IDPF_NB_XSTATS;\n+\n+\tif (!xstats)\n+\t\treturn 0;\n+\n+\tret = idpf_query_stats(vport, &pstats);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Get statistics failed\");\n+\t\treturn 0;\n+\t}\n+\n+\tidpf_update_stats(&vport->eth_stats_offset, pstats);\n+\n+\t/* loop over xstats array and values from pstats */\n+\tfor (i = 0; i < IDPF_NB_XSTATS; i++) {\n+\t\txstats[i].id = i;\n+\t\txstats[i].value = *(uint64_t *)(((char *)pstats) +\n+\t\t\trte_idpf_stats_strings[i].offset);\n+\t}\n+\treturn IDPF_NB_XSTATS;\n+}\n+\n+static int idpf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t __rte_unused unsigned int limit)\n+{\n+\tunsigned int i;\n+\n+\tif (xstats_names)\n+\t\tfor (i = 0; i < IDPF_NB_XSTATS; i++) {\n+\t\t\tsnprintf(xstats_names[i].name,\n+\t\t\t\t sizeof(xstats_names[i].name),\n+\t\t\t\t \"%s\", rte_idpf_stats_strings[i].name);\n+\t\t}\n+\treturn IDPF_NB_XSTATS;\n+}\n+\n static int idpf_config_rss_hf(struct idpf_vport *vport, uint64_t rss_hf)\n {\n \tuint64_t hena = 0, valid_rss_hf = 0;\n@@ -1158,6 +1235,9 @@ static const struct eth_dev_ops idpf_eth_dev_ops = {\n \t.reta_query\t\t\t= idpf_rss_reta_query,\n \t.rss_hash_update\t\t= idpf_rss_hash_update,\n \t.rss_hash_conf_get\t\t= idpf_rss_hash_conf_get,\n+\t.xstats_get\t\t\t= idpf_dev_xstats_get,\n+\t.xstats_get_names\t\t= idpf_dev_xstats_get_names,\n+\t.xstats_reset\t\t\t= idpf_dev_xstats_reset,\n };\n \n static uint16_t\n", "prefixes": [ "v2", "6/6" ] }