Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121554/?format=api
{ "id": 121554, "url": "https://patches.dpdk.org/api/patches/121554/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230104064145.2600261-2-s.v.naga.harish.k@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230104064145.2600261-2-s.v.naga.harish.k@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230104064145.2600261-2-s.v.naga.harish.k@intel.com", "date": "2023-01-04T06:41:43", "name": "[v6,2/4] eventdev/eth_tx: change eventdev reconfig logic", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9f7a822f194085b5445c6a17ee6e6a95d717a7f5", "submitter": { "id": 2280, "url": "https://patches.dpdk.org/api/people/2280/?format=api", "name": "Naga Harish K, S V", "email": "s.v.naga.harish.k@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230104064145.2600261-2-s.v.naga.harish.k@intel.com/mbox/", "series": [ { "id": 26376, "url": "https://patches.dpdk.org/api/series/26376/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26376", "date": "2023-01-04T06:41:42", "name": "[v6,1/4] eventdev/eth_rx: change eventdev reconfig logic", "version": 6, "mbox": "https://patches.dpdk.org/series/26376/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121554/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/121554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F0FBA00C2;\n\tWed, 4 Jan 2023 07:41:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B753942B8E;\n\tWed, 4 Jan 2023 07:41:52 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 748DA410EA\n for <dev@dpdk.org>; Wed, 4 Jan 2023 07:41:51 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jan 2023 22:41:51 -0800", "from txandevlnx322.an.intel.com ([10.123.117.44])\n by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2023 22:41:50 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1672814511; x=1704350511;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=6YWu9MvaPoeXZulDs2X1wNm2iM5Uih+YEVaau8Ej+rE=;\n b=LfExGPB9oXfjGAkL2UOrkLAYCtRZR2QmWehQXJ2klqzcWah9ELrYikbb\n 5HPnAi8yklMQHQyfTZK/MwdB1AIMFabyjaPywxKsk46AgBoKB5JzD99Ko\n R2qPiVeBTyvp25uP1oq5rVNQHv2UozwAK99Lh3QNHSd0eRWN0DYIG1jVc\n gs2oB9dqi1mJXp0j7kA0kX65hpfDmDSGaofiiASXvOAol6Hf6pBGsO0l3\n GM92SOjEd8z3Oo869U3VrBjM2QL6eXEEaTMUUKBBkYG4v75TkBTm+ey6A\n us6qxYpS/RKMCHvd9HiCk/YTjqOWYqGz4WgpuLBYPLLoAbQxx3XKfWzKr w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10579\"; a=\"302227786\"", "E=Sophos;i=\"5.96,299,1665471600\"; d=\"scan'208\";a=\"302227786\"", "E=McAfee;i=\"6500,9779,10579\"; a=\"900451509\"", "E=Sophos;i=\"5.96,299,1665471600\"; d=\"scan'208\";a=\"900451509\"" ], "X-ExtLoop1": "1", "From": "Naga Harish K S V <s.v.naga.harish.k@intel.com>", "To": "jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com", "Cc": "dev@dpdk.org,\n\tjay.jayatheerthan@intel.com", "Subject": "[PATCH v6 2/4] eventdev/eth_tx: change eventdev reconfig logic", "Date": "Wed, 4 Jan 2023 00:41:43 -0600", "Message-Id": "<20230104064145.2600261-2-s.v.naga.harish.k@intel.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20230104064145.2600261-1-s.v.naga.harish.k@intel.com>", "References": "<20230102051444.1263632-1-s.v.naga.harish.k@intel.com>\n <20230104064145.2600261-1-s.v.naga.harish.k@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When rte_event_eth_tx_adapter_create() is used for creating adapter\ninstance, eventdev is reconfigured with additional\n``rte_event_dev_config::nb_event_ports`` parameter.\n\nThis eventdev reconfig logic is enhanced to increment the\n``rte_event_dev_config::nb_single_link_event_port_queues``\nparameter if the adapter event port config is of type\n``RTE_EVENT_PORT_CFG_SINGLE_LINK``.\n\nWith this change the application is no longer need to configure the\neventdev with ``rte_event_dev_config::nb_single_link_event_port_queues``\nparameter required for eth_tx adapter when the adapter is created\nusing above mentioned api.\n\nSigned-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>\nAcked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>\n---\nv2:\n* fix build error in doc/prog_guide\nv3:\n* update doxygen\nv5:\n* update doxygen as per review comments\nv6:\n* no update in txa\n---\n---\n .../prog_guide/event_ethernet_tx_adapter.rst | 17 +++++++++++++++++\n lib/eventdev/rte_event_eth_tx_adapter.c | 2 ++\n lib/eventdev/rte_event_eth_tx_adapter.h | 14 ++++++++++++++\n 3 files changed, 33 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst\nindex 905cb445e0..711ecb7441 100644\n--- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst\n+++ b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst\n@@ -56,6 +56,23 @@ and needs to create an event port for it. The callback is expected to fill the\n \n err = rte_event_eth_tx_adapter_create(id, dev_id, &tx_p_conf);\n \n+Event device configuration for service based adapter\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+When rte_event_eth_tx_adapter_create() is used for creating\n+adapter instance, ``rte_event_dev_config::nb_event_ports`` is\n+automatically incremented, and the event device is reconfigured with additional\n+event port during service initialization. This event device reconfigure logic\n+also increments the ``rte_event_dev_config::nb_single_link_event_port_queues``\n+parameter if the adapter event port config is of type\n+``RTE_EVENT_PORT_CFG_SINGLE_LINK``.\n+\n+Application no longer needs to configure the event device with\n+``rte_event_dev_config::nb_event_ports`` and\n+``rte_event_dev_config::nb_single_link_event_port_queues``\n+parameters required for eth Tx adapter when the adapter is created\n+using the above-mentioned API.\n+\n Adding Tx Queues to the Adapter Instance\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c\nindex 88309d2aaa..c780ee1264 100644\n--- a/lib/eventdev/rte_event_eth_tx_adapter.c\n+++ b/lib/eventdev/rte_event_eth_tx_adapter.c\n@@ -316,6 +316,8 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,\n \n \tport_id = dev_conf.nb_event_ports;\n \tdev_conf.nb_event_ports += 1;\n+\tif (pc->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK)\n+\t\tdev_conf.nb_single_link_event_port_queues += 1;\n \n \tret = rte_event_dev_configure(dev_id, &dev_conf);\n \tif (ret) {\ndiff --git a/lib/eventdev/rte_event_eth_tx_adapter.h b/lib/eventdev/rte_event_eth_tx_adapter.h\nindex 645b87b78a..cd539af7ef 100644\n--- a/lib/eventdev/rte_event_eth_tx_adapter.h\n+++ b/lib/eventdev/rte_event_eth_tx_adapter.h\n@@ -142,6 +142,20 @@ struct rte_event_eth_tx_adapter_stats {\n /**\n * Create a new ethernet Tx adapter with the specified identifier.\n *\n+ * When this API is used for creating adapter instance,\n+ * ``rte_event_dev_config::nb_event_ports`` is automatically incremented,\n+ * and event device is reconfigured with additional event port during service\n+ * initialization. This event device reconfigure logic also increments the\n+ * ``rte_event_dev_config::nb_single_link_event_port_queues``\n+ * parameter if the adapter event port config is of type\n+ * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.\n+ *\n+ * Application no longer needs to account for the\n+ * ``rte_event_dev_config::nb_event_ports`` and\n+ * ``rte_event_dev_config::nb_single_link_event_port_queues``\n+ * parameters required for eth Tx adapter in event device configure when\n+ * the adapter is created with this API.\n+ *\n * @param id\n * The identifier of the ethernet Tx adapter.\n * @param dev_id\n", "prefixes": [ "v6", "2/4" ] }