Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121502/?format=api
{ "id": 121502, "url": "https://patches.dpdk.org/api/patches/121502/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230102114655.300-1-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230102114655.300-1-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230102114655.300-1-anoobj@marvell.com", "date": "2023-01-02T11:46:53", "name": "[1/3] app/crypto-perf: use right API to free session", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9d617a037d5fdb63148d838512c9c052ae4b3720", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230102114655.300-1-anoobj@marvell.com/mbox/", "series": [ { "id": 26348, "url": "https://patches.dpdk.org/api/series/26348/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26348", "date": "2023-01-02T11:46:53", "name": "[1/3] app/crypto-perf: use right API to free session", "version": 1, "mbox": "https://patches.dpdk.org/series/26348/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121502/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/121502/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E2D4A00C2;\n\tMon, 2 Jan 2023 12:47:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A6B2040693;\n\tMon, 2 Jan 2023 12:47:05 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id B55FB40689\n for <dev@dpdk.org>; Mon, 2 Jan 2023 12:47:03 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3022wXmr005542; Mon, 2 Jan 2023 03:47:03 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3mtnftbuwk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 02 Jan 2023 03:47:02 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Mon, 2 Jan 2023 03:47:00 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Mon, 2 Jan 2023 03:47:00 -0800", "from BG-LT92004.corp.innovium.com (unknown [10.193.74.65])\n by maili.marvell.com (Postfix) with ESMTP id 95ECE3F7082;\n Mon, 2 Jan 2023 03:46:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=byPAoXBjMp7XnhdP4oHaPTUQ+yZc1+05DDvlUbN/buA=;\n b=huj5VE927L3cz3oK2nHXWt19zFmn4/+bIjmwY4hrYeBj0NoxOELXbFFHcBaoZzWuL+T0\n nL5g63dmL4bTbBGbn8SSvmqsatEKxqCulp+XPM0TogunoSjexf0c1vIypxaaz+Z2/nFS\n mPA8daxFnX8hJUWbkRcffHXG/1EV2LZdcIk4Te5twE0B1ZTIrA++EaG6xbL3c+jCwMyX\n AtDE5nHr0uK0CQ2AL8RUBhyT325KRCa3fhysuab32uWk/kvw21Y40coaxRyAraRZGa76\n 0O4aqOSUF5C7+D7tjVdgWzrvHDhAlodYDl05s9ux3tDWAFvnOZ5JiMFQacsxlOsvmfNb gQ==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Ciara Power <ciara.power@intel.com>, Akhil Goyal <gakhil@marvell.com>", "CC": "Gagandeep Singh <g.singh@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Jerin Jacob <jerinj@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 1/3] app/crypto-perf: use right API to free session", "Date": "Mon, 2 Jan 2023 17:16:53 +0530", "Message-ID": "<20230102114655.300-1-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "0Heh_H8mF6ffK3nFx1h_DkyilytSwuJa", "X-Proofpoint-ORIG-GUID": "0Heh_H8mF6ffK3nFx1h_DkyilytSwuJa", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2023-01-02_06,2022-12-30_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use the right API for session freeing. Sessions can be asymmetric,\nsymmetric or security.\n\nFixes: 28dde5da503e (\"app/crypto-perf: support lookaside IPsec\")\nFixes: a538d1d2d01e (\"test/crypto-perf: extend asymmetric crypto throughput test\")\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n app/test-crypto-perf/cperf_test_latency.c | 27 +++++++++++++++++------\n app/test-crypto-perf/cperf_test_verify.c | 25 ++++++++++++++++-----\n 2 files changed, 39 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c\nindex 49bf421c01..406e082e4e 100644\n--- a/app/test-crypto-perf/cperf_test_latency.c\n+++ b/app/test-crypto-perf/cperf_test_latency.c\n@@ -43,15 +43,28 @@ struct priv_op_data {\n static void\n cperf_latency_test_free(struct cperf_latency_ctx *ctx)\n {\n-\tif (ctx) {\n-\t\tif (ctx->sess)\n-\t\t\trte_cryptodev_sym_session_free(ctx->dev_id, ctx->sess);\n-\n-\t\trte_mempool_free(ctx->pool);\n+\tif (ctx == NULL)\n+\t\treturn;\n \n-\t\trte_free(ctx->res);\n-\t\trte_free(ctx);\n+\tif (ctx->sess != NULL) {\n+\t\tif (ctx->options->op_type == CPERF_ASYM_MODEX)\n+\t\t\trte_cryptodev_asym_session_free(ctx->dev_id, ctx->sess);\n+#ifdef RTE_LIB_SECURITY\n+\t\telse if (ctx->options->op_type == CPERF_PDCP ||\n+\t\t\t ctx->options->op_type == CPERF_DOCSIS ||\n+\t\t\t ctx->options->op_type == CPERF_IPSEC) {\n+\t\t\tstruct rte_security_ctx *sec_ctx =\n+\t\t\t\trte_cryptodev_get_sec_ctx(ctx->dev_id);\n+\t\t\trte_security_session_destroy(sec_ctx, ctx->sess);\n+\t\t}\n+#endif\n+\t\telse\n+\t\t\trte_cryptodev_sym_session_free(ctx->dev_id, ctx->sess);\n \t}\n+\n+\trte_mempool_free(ctx->pool);\n+\trte_free(ctx->res);\n+\trte_free(ctx);\n }\n \n void *\ndiff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c\nindex c03e1d5ba5..8042c94e04 100644\n--- a/app/test-crypto-perf/cperf_test_verify.c\n+++ b/app/test-crypto-perf/cperf_test_verify.c\n@@ -38,14 +38,27 @@ struct cperf_op_result {\n static void\n cperf_verify_test_free(struct cperf_verify_ctx *ctx)\n {\n-\tif (ctx) {\n-\t\tif (ctx->sess)\n-\t\t\trte_cryptodev_sym_session_free(ctx->dev_id, ctx->sess);\n-\n-\t\trte_mempool_free(ctx->pool);\n+\tif (ctx == NULL)\n+\t\treturn;\n \n-\t\trte_free(ctx);\n+\tif (ctx->sess != NULL) {\n+\t\tif (ctx->options->op_type == CPERF_ASYM_MODEX)\n+\t\t\trte_cryptodev_asym_session_free(ctx->dev_id, ctx->sess);\n+#ifdef RTE_LIB_SECURITY\n+\t\telse if (ctx->options->op_type == CPERF_PDCP ||\n+\t\t\t ctx->options->op_type == CPERF_DOCSIS ||\n+\t\t\t ctx->options->op_type == CPERF_IPSEC) {\n+\t\t\tstruct rte_security_ctx *sec_ctx =\n+\t\t\t\trte_cryptodev_get_sec_ctx(ctx->dev_id);\n+\t\t\trte_security_session_destroy(sec_ctx, ctx->sess);\n+\t\t}\n+#endif\n+\t\telse\n+\t\t\trte_cryptodev_sym_session_free(ctx->dev_id, ctx->sess);\n \t}\n+\n+\trte_mempool_free(ctx->pool);\n+\trte_free(ctx);\n }\n \n void *\n", "prefixes": [ "1/3" ] }