Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121354/?format=api
{ "id": 121354, "url": "https://patches.dpdk.org/api/patches/121354/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221223085527.29760-5-ke1.xu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221223085527.29760-5-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221223085527.29760-5-ke1.xu@intel.com", "date": "2022-12-23T08:55:26", "name": "[V6,4/5] tests/vf_offload: add new method to anayse tunnel packets.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bcfd2b4bf8dad093d8499cb32161dbe87f9a8b7d", "submitter": { "id": 2810, "url": "https://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221223085527.29760-5-ke1.xu@intel.com/mbox/", "series": [ { "id": 26260, "url": "https://patches.dpdk.org/api/series/26260/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=26260", "date": "2022-12-23T08:55:22", "name": "add vf checksum offload and tso case for tunnel packets.", "version": 6, "mbox": "https://patches.dpdk.org/series/26260/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121354/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/121354/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6512AA0093;\n\tFri, 23 Dec 2022 09:57:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 60B904282D;\n\tFri, 23 Dec 2022 09:57:03 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id D4ECB40698\n for <dts@dpdk.org>; Fri, 23 Dec 2022 09:57:01 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Dec 2022 00:57:01 -0800", "from dpdk-xuke-lab.sh.intel.com ([10.67.119.8])\n by orsmga004.jf.intel.com with ESMTP; 23 Dec 2022 00:56:59 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1671785822; x=1703321822;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=2DqAhc9qM416mDMeeXmdR5erlATuWYcw5HBmBzjWWzI=;\n b=L8PcEcV9qOcGijs1e5zz8g4s8zLaspj3OcPeWHefmqDKtF+hJ5MyPB5u\n y5ndzItS4Y+VHrqD1PpE6FfePzJjVP9vVd6JNbAphvpPto7mekXmbH1ZD\n jbd7DWdw3XWGNWZ3H0Uu0mrpuAcfqx5vxzoJLhr525uphwmyOZizzvQtC\n YBqnUJ5GCnNdZpeXC3JxDPdvScMPYHHkvVtFhW4J1O9AJNPB6s0/SaQYR\n AvNGoruYMPmDTeEP1nOQnUMOt37a8G3ScBmE6DNtC6oWhJbdp0rMmTlkL\n NNA0PvLxpH++/hxav8bX7IORqfmKDDKYTcpo/0YMuri5Fa6ZsvETXAdwt w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10569\"; a=\"303773493\"", "E=Sophos;i=\"5.96,268,1665471600\"; d=\"scan'208\";a=\"303773493\"", "E=McAfee;i=\"6500,9779,10569\"; a=\"776304479\"", "E=Sophos;i=\"5.96,268,1665471600\"; d=\"scan'208\";a=\"776304479\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "ke1.xu@intel.com, weiyuanx.li@intel.com, qi.fu@intel.com,\n lijuan.tu@intel.com", "Subject": "[DTS][PATCH V6 4/5] tests/vf_offload: add new method to anayse tunnel\n packets.", "Date": "Fri, 23 Dec 2022 16:55:26 +0800", "Message-Id": "<20221223085527.29760-5-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221223085527.29760-1-ke1.xu@intel.com>", "References": "<20221223085527.29760-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "As tcpdump not supporting some of the packet\n organizations we are to cover, a newly implemented\n function is introduced to replace number_of_packets\n and number_of_bytes in tunnel cases.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n tests/TestSuite_vf_offload.py | 64 +++++++++++++++++++++++++----------\n 1 file changed, 46 insertions(+), 18 deletions(-)", "diff": "diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py\nindex 3d89729d..6765fcc5 100644\n--- a/tests/TestSuite_vf_offload.py\n+++ b/tests/TestSuite_vf_offload.py\n@@ -6,8 +6,19 @@ import re\n import string\n import time\n \n+from scapy.contrib.lldp import LLDPDU, LLDPDUManagementAddress\n+from scapy.contrib.mpls import MPLS\n+from scapy.contrib.nsh import NSH\n+from scapy.layers.inet import ICMP, IP, TCP, UDP\n+from scapy.layers.inet6 import IPv6, IPv6ExtHdrFragment, IPv6ExtHdrRouting\n+from scapy.layers.l2 import ARP, GRE, Dot1Q, Ether\n+from scapy.layers.sctp import SCTP\n+from scapy.layers.vxlan import VXLAN\n+from scapy.packet import Raw\n+\n import framework.utils as utils\n from framework.crb import Crb\n+from framework.packet import Packet\n from framework.pmd_output import PmdOutput\n from framework.settings import DPDK_DCFMODE_SETTING, HEADER_SIZE, load_global_setting\n from framework.test_case import TestCase, check_supported_nic, skip_unsupported_pkg\n@@ -687,6 +698,25 @@ class TestVfOffload(TestCase):\n self.tester.send_expect('echo \"Cleaning buffer\"', \"#\")\n time.sleep(1)\n \n+ def tcpdump_analyse_sniff(self, iface):\n+ \"\"\"\n+ Analyse the tcpdump captured packets. Returning the number of\n+ packets and the bytes of packets payload.\n+ \"\"\"\n+ packet = Packet()\n+ pkts = packet.read_pcapfile(\"tcpdump_{0}.pcap\".format(iface), self.tester)\n+ pkts = [\n+ p\n+ for p in pkts\n+ if len(p.layers()) >= 3\n+ and p.layers()[1] in {IP, IPv6}\n+ and p.layers()[2] in {IP, IPv6, UDP, TCP, SCTP, GRE, MPLS}\n+ and Raw in p\n+ ]\n+ rx_packet_count = len(pkts)\n+ rx_packet_size = [len(p[Raw]) for p in pkts]\n+ return rx_packet_count, rx_packet_size\n+\n def tcpdump_command(self, command):\n \"\"\"\n Send a tcpdump related command and return an integer from the output.\n@@ -973,26 +1003,25 @@ class TestVfOffload(TestCase):\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n print(out)\n self.tcpdump_stop_sniff()\n- rx_stats = self.number_of_packets(rx_interface)\n- tx_stats = self.number_of_packets(tx_interface)\n- tx_outlist = self.number_of_bytes(rx_interface)\n- self.logger.info(tx_outlist)\n+ rx_stats, payload_size_list = self.tcpdump_analyse_sniff(rx_interface)\n+ tx_stats, _ = self.tcpdump_analyse_sniff(tx_interface)\n+ self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and int(tx_outlist[0]) == loading_size,\n+ rx_stats == tx_stats and payload_size_list[0] == loading_size,\n f\"{key_outer} tunnel IPV4 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- int(tx_outlist[i]) == 800,\n- \"the packet segmentation incorrect, %s\" % tx_outlist,\n+ payload_size_list[i] == 800,\n+ \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- int(tx_outlist[num]) == loading_size % 800,\n- \"the packet segmentation incorrect, %s\" % tx_outlist,\n+ payload_size_list[num] == loading_size % 800,\n+ \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n for loading_size in self.loading_sizes:\n@@ -1017,26 +1046,25 @@ class TestVfOffload(TestCase):\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n print(out)\n self.tcpdump_stop_sniff()\n- rx_stats = self.number_of_packets(rx_interface)\n- tx_stats = self.number_of_packets(tx_interface)\n- tx_outlist = self.number_of_bytes(rx_interface)\n- self.logger.info(tx_outlist)\n+ rx_stats, payload_size_list = self.tcpdump_analyse_sniff(rx_interface)\n+ tx_stats, _ = self.tcpdump_analyse_sniff(tx_interface)\n+ self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and int(tx_outlist[0]) == loading_size,\n+ rx_stats == tx_stats and payload_size_list[0] == loading_size,\n f\"{key_outer} tunnel IPV6 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- int(tx_outlist[i]) == 800,\n- \"the packet segmentation incorrect, %s\" % tx_outlist,\n+ payload_size_list[i] == 800,\n+ \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- int(tx_outlist[num]) == loading_size % 800,\n- \"the packet segmentation incorrect, %s\" % tx_outlist,\n+ payload_size_list[num] == loading_size % 800,\n+ \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n def tear_down(self):\n", "prefixes": [ "V6", "4/5" ] }