Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12115/?format=api
{ "id": 12115, "url": "https://patches.dpdk.org/api/patches/12115/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/2181162.yfzPt0qCzR@xps13/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<2181162.yfzPt0qCzR@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2181162.yfzPt0qCzR@xps13", "date": "2016-04-19T14:13:58", "name": "[dpdk-dev] ethdev: remove deprecated statistics", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "7604310363441a356ddee36fea907fb136b99fc0", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/2181162.yfzPt0qCzR@xps13/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/12115/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/12115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2DA4E37B2;\n\tTue, 19 Apr 2016 16:14:03 +0200 (CEST)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5955C37B1\n\tfor <dev@dpdk.org>; Tue, 19 Apr 2016 16:14:01 +0200 (CEST)", "by mail-wm0-f52.google.com with SMTP id l6so28556597wml.1\n\tfor <dev@dpdk.org>; Tue, 19 Apr 2016 07:14:01 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\t188sm4583628wmk.6.2016.04.19.07.14.00\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 19 Apr 2016 07:14:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:organization:user-agent\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=NDwzlLOuOpTJS1uKejz8wW9ATKLj+707ghMveAmJhvk=;\n\tb=HYICV1++r2rneb+TO2+yWhVbNKQtrJWZFW6bzt8R30mYKUYAwrXmgS4w/Wi7KBpVgo\n\tz8EeOaPWvtqFhpNG0GALA+1OiFqTKy+GxEuQtz7LDjQZI4zKAGoI2i3KxWA+HBwhi7/g\n\tXd9Fk4YitH4Q6hcK2YCHJ3UIzrUmGXYCxMpoxdIuPivAskH6gCLeIxCl/DfZ+4FT4kVi\n\ta3DdetQro+XWyqyEi6Bgmre6Zm+vVhkdfDMY6BCws6V/avetd3yJOU1RdA+0z8Pd91Lo\n\tKHD6+wRLVDLqU+P5pGaV9t7Fub+qm9D/ot/wfoIS3dm2blEjG32+5it6Sq+wqou4sfFa\n\tdXLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding;\n\tbh=NDwzlLOuOpTJS1uKejz8wW9ATKLj+707ghMveAmJhvk=;\n\tb=Eg4l/j/Wa7aEs5+idhFKHgTXGC6gH9fLUlqKRHbF+R6wwQLMjzczPyXQVPL0umCCvZ\n\t/6jhU57nbRb1za1oX5QTWx568If+GNFwQ89bPoVR7mGG0QwpztgJeEdQh6lcCtmFZqsN\n\tJzFnC0Zcj0rLy8YOyrdFGl3zi6GufynKO0CqPU/uoi7FOgS5qDmTkqwQOhHnpOGZPCyb\n\tyveMGl5v6hR8/JkZitT9FxcnNDWWu6Td4/AgtZEQmdLBbJvfcgLAuBKW04qZK6ws5eAf\n\tub6MRMyrszYt9NKStq84FJFIZiLwaLQNPD80oIVDAWeolyvszBP93eQhlqA4HNaJqJVY\n\tmoWQ==", "X-Gm-Message-State": "AOPr4FWBpqA6bVjZPBRfoF40ctgC9Ld2Hnp1LF/w3ajr8UUDkZMe408RZ31QfImbnVr/HlhL", "X-Received": "by 10.194.158.226 with SMTP id wx2mr3309328wjb.91.1461075241127; \n\tTue, 19 Apr 2016 07:14:01 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "maryam.tahhan@intel.com, harry.van.haaren@intel.com", "Cc": "dev@dpdk.org", "Date": "Tue, 19 Apr 2016 16:13:58 +0200", "Message-ID": "<2181162.yfzPt0qCzR@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )", "In-Reply-To": "<1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1461074613-32360-1-git-send-email-thomas.monjalon@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH] ethdev: remove deprecated statistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "2016-04-19 16:03, Thomas Monjalon:\n> Some statistics were deprecated since release 2.1 (49f386542af4).\n> \n> The last deprecated counter to be used was imcasts.\n> \n> The new counters should be added to extended statistics.\n> \n> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n[...]\n> --- a/lib/librte_ether/rte_ethdev.h\n> +++ b/lib/librte_ether/rte_ethdev.h\n> @@ -200,27 +200,9 @@ struct rte_eth_stats {\n> \t/**< Total of RX packets dropped by the HW,\n> \t * because there are no available mbufs (i.e. RX queues are full).\n> \t */\n> -\tuint64_t ibadcrc __rte_deprecated;\n> -\t/**< Deprecated; Total of RX packets with CRC error. */\n> -\tuint64_t ibadlen __rte_deprecated;\n> -\t/**< Deprecated; Total of RX packets with bad length. */\n> \tuint64_t ierrors; /**< Total number of erroneous received packets. */\n> \tuint64_t oerrors; /**< Total number of failed transmitted packets. */\n> -\tuint64_t imcasts;\n> -\t/**< Deprecated; Total number of multicast received packets. */\n> \tuint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */\n> -\tuint64_t fdirmatch __rte_deprecated;\n> -\t/**< Deprecated; Total number of RX packets matching a filter. */\n> -\tuint64_t fdirmiss __rte_deprecated;\n> -\t/**< Deprecated; Total number of RX packets not matching any filter. */\n> -\tuint64_t tx_pause_xon __rte_deprecated;\n> -\t /**< Deprecated; Total nb. of XON pause frame sent. */\n> -\tuint64_t rx_pause_xon __rte_deprecated;\n> -\t/**< Deprecated; Total nb. of XON pause frame received. */\n> -\tuint64_t tx_pause_xoff __rte_deprecated;\n> -\t/**< Deprecated; Total nb. of XOFF pause frame sent. */\n> -\tuint64_t rx_pause_xoff __rte_deprecated;\n> -\t/**< Deprecated; Total nb. of XOFF pause frame received. */\n> \tuint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n> \t/**< Total number of queue RX packets. */\n> \tuint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n\nI suggest to remove also the loopback statistics which are implemented only\nfor igbvf and available as extended stats:", "diff": "--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -213,14 +213,6 @@ struct rte_eth_stats {\n /**< Total number of successfully transmitted queue bytes. */\n uint64_t q_errors[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n /**< Total number of queue packets received that are dropped. */\n- uint64_t ilbpackets;\n- /**< Total number of good packets received from loopback,VF Only */\n- uint64_t olbpackets;\n- /**< Total number of good packets transmitted to loopback,VF Only */\n- uint64_t ilbbytes;\n- /**< Total number of good bytes received from loopback,VF Only */\n- uint64_t olbbytes;\n- /**< Total number of good bytes transmitted to loopback,VF Only */\n };\n\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1805,10 +1805,6 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)\n rte_stats->ibytes = hw_stats->gorc;\n rte_stats->opackets = hw_stats->gptc;\n rte_stats->obytes = hw_stats->gotc;\n- rte_stats->ilbpackets = hw_stats->gprlbc;\n- rte_stats->ilbbytes = hw_stats->gorlbc;\n- rte_stats->olbpackets = hw_stats->gptlbc;\n- rte_stats->olbbytes = hw_stats->gotlbc;\n }\n\nI'll send a v2 if no objection.\n", "prefixes": [ "dpdk-dev" ] }