Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120734/?format=api
{ "id": 120734, "url": "https://patches.dpdk.org/api/patches/120734/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221212024943.2776599-1-weix.ling@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221212024943.2776599-1-weix.ling@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221212024943.2776599-1-weix.ling@intel.com", "date": "2022-12-12T02:49:43", "name": "[V3,1/2] framework/qemu_kvm: support pin VM's thread to vhost CPU lcore", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2d014a30b62fa32b58088ac6d311074dc509359f", "submitter": { "id": 1828, "url": "https://patches.dpdk.org/api/people/1828/?format=api", "name": "Ling, WeiX", "email": "weix.ling@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221212024943.2776599-1-weix.ling@intel.com/mbox/", "series": [ { "id": 26072, "url": "https://patches.dpdk.org/api/series/26072/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=26072", "date": "2022-12-12T02:49:32", "name": "support pin VM's thread to vhost CPU lcore", "version": 3, "mbox": "https://patches.dpdk.org/series/26072/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120734/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/120734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 76AC9A04FD;\n\tMon, 12 Dec 2022 03:57:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 70AB940684;\n\tMon, 12 Dec 2022 03:57:01 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 2B50040151\n for <dts@dpdk.org>; Mon, 12 Dec 2022 03:56:59 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Dec 2022 18:56:58 -0800", "from unknown (HELO localhost.localdomain) ([10.239.252.222])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Dec 2022 18:56:56 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1670813819; x=1702349819;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=pKm01Ws7aLHBFSgyZu1caN7QY9Ru9QfySACiOb+yuzQ=;\n b=ILZCqaEemmKhEqAudzDfUf09vIWsAbX8cWL7r0jiFk0viYPMcCdK9wMn\n Wft/o1EjDHfbGoaYhzfWMXzEUXGLqT2p9OSYTEpma0qflJ/WfV/3/wL/Q\n A9e8QIpq3RVZRQqMUA8NyiHApVsCcs/teOVwgWj6cmZ93tuNGFqtALBsI\n XmS+VbGrhTdcWQQpgM35rdzhfpOrsyi4/a7xUR5quF8Zh1/e953RIunCi\n Ighn7LwRqxg4mICGJDfDC/l9qzxbQxWMctm/tNvXlMzY24+pX/p1qU6XE\n Vn3iMwjU1bFup5RS4QhlaDFxgXioucr7UBDMjG3vN+ygkaN7IFG9qIY3/ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10558\"; a=\"316449039\"", "E=Sophos;i=\"5.96,237,1665471600\"; d=\"scan'208\";a=\"316449039\"", "E=McAfee;i=\"6500,9779,10558\"; a=\"641597463\"", "E=Sophos;i=\"5.96,237,1665471600\"; d=\"scan'208\";a=\"641597463\"" ], "From": "Wei Ling <weix.ling@intel.com>", "To": "dts@dpdk.org", "Cc": "Wei Ling <weix.ling@intel.com>", "Subject": "[dts][PATCH V3 1/2] framework/qemu_kvm: support pin VM's thread to\n vhost CPU lcore", "Date": "Mon, 12 Dec 2022 10:49:43 +0800", "Message-Id": "<20221212024943.2776599-1-weix.ling@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "1)Support pin VM's thread to vhost CPU lcore.\n2)Fix add_vm_daemon method issue.\n\nSigned-off-by: Wei Ling <weix.ling@intel.com>\n---\n framework/qemu_kvm.py | 50 ++++++++++++++++++++++++++++++++-----------\n 1 file changed, 37 insertions(+), 13 deletions(-)", "diff": "diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py\nindex 20aa8008..0efe286c 100644\n--- a/framework/qemu_kvm.py\n+++ b/framework/qemu_kvm.py\n@@ -1241,7 +1241,7 @@ class QEMUKvm(VirtBase):\n By default VM will start with the daemonize status.\n Not support starting it on the stdin now.\n \"\"\"\n- if \"daemon\" in list(options.keys()) and options[\"enable\"] == \"no\":\n+ if \"enable\" in list(options.keys()) and options[\"enable\"] == \"no\":\n pass\n else:\n daemon_boot_line = \"-daemonize\"\n@@ -1365,7 +1365,7 @@ class QEMUKvm(VirtBase):\n \n self.migrate_port = int(m.group(1))\n \n- def _start_vm(self):\n+ def _start_vm(self, pin_threads=True):\n \"\"\"\n Start VM.\n \"\"\"\n@@ -1377,6 +1377,11 @@ class QEMUKvm(VirtBase):\n \n self.__get_pci_mapping()\n \n+ # pin VM threads with host CPU cores\n+ if pin_threads:\n+ lcores = self.vcpus_pinned_to_vm.split(\" \")\n+ self.pin_threads(lcores=lcores)\n+\n # query status\n self.update_status()\n \n@@ -1385,7 +1390,7 @@ class QEMUKvm(VirtBase):\n \n # when vm is waiting for migration, can't ping\n if self.vm_status is not ST_PAUSE:\n- self.__wait_vm_ready()\n+ self.__wait_vm_ready(pin_threads=pin_threads)\n \n self.__wait_vmnet_ready()\n \n@@ -1445,7 +1450,7 @@ class QEMUKvm(VirtBase):\n \n return logged_in\n \n- def __wait_vm_ready(self):\n+ def __wait_vm_ready(self, pin_threads=True):\n logged_in = self.__ping_vm()\n if not logged_in:\n if not self.restarted:\n@@ -1454,7 +1459,7 @@ class QEMUKvm(VirtBase):\n self.vm_status = ST_NOTSTART\n self._stop_vm()\n self.restarted = True\n- self._start_vm()\n+ self._start_vm(pin_threads=pin_threads)\n else:\n raise StartVMFailedException(\n \"Not response in %d seconds!!!\" % self.START_TIMEOUT\n@@ -2003,14 +2008,33 @@ class QEMUKvm(VirtBase):\n \n def pin_threads(self, lcores):\n \"\"\"\n- Pin thread to assigned cores\n+ Pin thread to assigned cores.\n+ If threads <= lcores, like: threads=[427756, 427757], lcores=[48, 49, 50]:\n+ taskset -pc 48 427756\n+ taskset -pc 49 427757\n+\n+ If threads > lcores, like threads=[427756, 427757, 427758, 427759, 427760], lcores=[48,49,50]\n+ taskset -pc 48 427756\n+ taskset -pc 49 427757\n+ taskset -pc 50 427758\n+ taskset -pc 48 427759\n+ taskset -pc 49 427760\n \"\"\"\n- thread_reg = r\"CPU #(\\d+): .* thread_id=(\\d+)\"\n+ thread_reg = r\"CPU #\\d+: thread_id=(\\d+)\"\n output = self.__monitor_session(\"info\", \"cpus\")\n- thread_cores = re.findall(thread_reg, output)\n- cores_map = list(zip(thread_cores, lcores))\n- for thread_info, core_id in cores_map:\n- cpu_id, thread_id = thread_info\n- self.host_session.send_expect(\n- \"taskset -pc %d %s\" % (core_id, thread_id), \"#\"\n+ threads = re.findall(thread_reg, output)\n+ if len(threads) <= len(lcores):\n+ map = list(zip(threads, lcores))\n+ else:\n+ self.host_logger.warning(\n+ \"lcores is less than threads, please check the 'number' and 'cpupin' config.\"\n )\n+ lcore_len = len(lcores)\n+ for item in threads:\n+ thread_idx = threads.index(item)\n+ if thread_idx >= lcore_len:\n+ lcore_idx = thread_idx % lcore_len\n+ lcores.append(lcores[lcore_idx])\n+ map = list(zip(threads, lcores))\n+ for thread, lcore in map:\n+ self.host_session.send_expect(\"taskset -pc %s %s\" % (lcore, thread), \"#\")\n", "prefixes": [ "V3", "1/2" ] }