Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 120711,
    "url": "https://patches.dpdk.org/api/patches/120711/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-4-lihuisong@huawei.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20221209110450.62456-4-lihuisong@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20221209110450.62456-4-lihuisong@huawei.com",
    "date": "2022-12-09T11:04:42",
    "name": "[V2,03/11] test: add test cases for adding u32 value API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5bf283d2ae6617547eb69fbb9d8ed6156d7516e7",
    "submitter": {
        "id": 2085,
        "url": "https://patches.dpdk.org/api/people/2085/?format=api",
        "name": "lihuisong (C)",
        "email": "lihuisong@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-4-lihuisong@huawei.com/mbox/",
    "series": [
        {
            "id": 26064,
            "url": "https://patches.dpdk.org/api/series/26064/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26064",
            "date": "2022-12-09T11:04:39",
            "name": "telemetry: add u32 value type and hex integer string API",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/26064/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/120711/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/120711/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF04FA00C2;\n\tFri,  9 Dec 2022 12:05:11 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CB0D742D3C;\n\tFri,  9 Dec 2022 12:04:53 +0100 (CET)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id C775B42BAC\n for <dev@dpdk.org>; Fri,  9 Dec 2022 12:04:48 +0100 (CET)",
            "from kwepemm600004.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NT7SD5x6zzJqRK;\n Fri,  9 Dec 2022 19:03:56 +0800 (CST)",
            "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 9 Dec 2022 19:04:44 +0800"
        ],
        "From": "Huisong Li <lihuisong@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<bruce.richardson@intel.com>, <mb@smartsharesystems.com>,\n <ciara.power@intel.com>, <liudongdong3@huawei.com>, <huangdaode@huawei.com>,\n <fengchengwen@huawei.com>, <lihuisong@huawei.com>",
        "Subject": "[PATCH V2 03/11] test: add test cases for adding u32 value API",
        "Date": "Fri, 9 Dec 2022 19:04:42 +0800",
        "Message-ID": "<20221209110450.62456-4-lihuisong@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20221209110450.62456-1-lihuisong@huawei.com>",
        "References": "<20221208080540.62913-1-lihuisong@huawei.com>\n <20221209110450.62456-1-lihuisong@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemm600004.china.huawei.com (7.193.23.242)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Add test cases for adding u32 value API.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test/test_telemetry_data.c | 85 +++++++++++++++++++++++++++++++++-\n app/test/test_telemetry_json.c | 23 ++++++++-\n 2 files changed, 104 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c\nindex d92667a527..8ab3441cbe 100644\n--- a/app/test/test_telemetry_data.c\n+++ b/app/test/test_telemetry_data.c\n@@ -278,6 +278,17 @@ test_array_with_array_string_values(void)\n \treturn CHECK_OUTPUT(\"[[\\\"aaaa\\\"],[\\\"bbbb\\\"]]\");\n }\n \n+static int\n+test_case_array_u32(void)\n+{\n+\tuint32_t i;\n+\n+\trte_tel_data_start_array(&response_data, RTE_TEL_U32_VAL);\n+\tfor (i = 0; i < 5; i++)\n+\t\trte_tel_data_add_array_u32(&response_data, i);\n+\treturn CHECK_OUTPUT(\"[0,1,2,3,4]\");\n+}\n+\n static int\n test_case_array_u64(void)\n {\n@@ -289,6 +300,21 @@ test_case_array_u64(void)\n \treturn CHECK_OUTPUT(\"[0,1,2,3,4]\");\n }\n \n+static int\n+test_case_add_dict_u32(void)\n+{\n+\tuint32_t i = 0;\n+\tchar name_of_value[8];\n+\n+\trte_tel_data_start_dict(&response_data);\n+\n+\tfor (i = 0; i < 5; i++) {\n+\t\tsprintf(name_of_value, \"dict_%u\", i);\n+\t\trte_tel_data_add_dict_u32(&response_data, name_of_value, i);\n+\t}\n+\treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":0,\\\"dict_1\\\":1,\\\"dict_2\\\":2,\\\"dict_3\\\":3,\\\"dict_4\\\":4}\");\n+}\n+\n static int\n test_case_add_dict_u64(void)\n {\n@@ -304,6 +330,32 @@ test_case_add_dict_u64(void)\n \treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":0,\\\"dict_1\\\":1,\\\"dict_2\\\":2,\\\"dict_3\\\":3,\\\"dict_4\\\":4}\");\n }\n \n+static int\n+test_dict_with_array_u32_values(void)\n+{\n+\tuint32_t i;\n+\n+\tstruct rte_tel_data *child_data = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data, RTE_TEL_U32_VAL);\n+\n+\tstruct rte_tel_data *child_data2 = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data2, RTE_TEL_U32_VAL);\n+\n+\trte_tel_data_start_dict(&response_data);\n+\n+\tfor (i = 0; i < 10; i++) {\n+\t\trte_tel_data_add_array_u32(child_data, i);\n+\t\trte_tel_data_add_array_u32(child_data2, i);\n+\t}\n+\n+\trte_tel_data_add_dict_container(&response_data, \"dict_0\",\n+\t child_data, 0);\n+\trte_tel_data_add_dict_container(&response_data, \"dict_1\",\n+\t child_data2, 0);\n+\n+\treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":[0,1,2,3,4,5,6,7,8,9],\\\"dict_1\\\":[0,1,2,3,4,5,6,7,8,9]}\");\n+}\n+\n static int\n test_dict_with_array_u64_values(void)\n {\n@@ -330,6 +382,29 @@ test_dict_with_array_u64_values(void)\n \treturn CHECK_OUTPUT(\"{\\\"dict_0\\\":[0,1,2,3,4,5,6,7,8,9],\\\"dict_1\\\":[0,1,2,3,4,5,6,7,8,9]}\");\n }\n \n+static int\n+test_array_with_array_u32_values(void)\n+{\n+\tuint32_t i;\n+\n+\tstruct rte_tel_data *child_data = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data, RTE_TEL_U32_VAL);\n+\n+\tstruct rte_tel_data *child_data2 = rte_tel_data_alloc();\n+\trte_tel_data_start_array(child_data2, RTE_TEL_U32_VAL);\n+\n+\trte_tel_data_start_array(&response_data, RTE_TEL_CONTAINER);\n+\n+\tfor (i = 0; i < 5; i++) {\n+\t\trte_tel_data_add_array_u32(child_data, i);\n+\t\trte_tel_data_add_array_u32(child_data2, i);\n+\t}\n+\trte_tel_data_add_array_container(&response_data, child_data, 0);\n+\trte_tel_data_add_array_container(&response_data, child_data2, 0);\n+\n+\treturn CHECK_OUTPUT(\"[[0,1,2,3,4],[0,1,2,3,4]]\");\n+}\n+\n static int\n test_array_with_array_u64_values(void)\n {\n@@ -428,14 +503,20 @@ telemetry_data_autotest(void)\n \t\t\ttest_null_return,\n \t\t\ttest_simple_string,\n \t\t\ttest_case_array_string,\n-\t\t\ttest_case_array_int, test_case_array_u64,\n-\t\t\ttest_case_add_dict_int, test_case_add_dict_u64,\n+\t\t\ttest_case_array_int,\n+\t\t\ttest_case_array_u32,\n+\t\t\ttest_case_array_u64,\n+\t\t\ttest_case_add_dict_int,\n+\t\t\ttest_case_add_dict_u32,\n+\t\t\ttest_case_add_dict_u64,\n \t\t\ttest_case_add_dict_string,\n \t\t\ttest_dict_with_array_int_values,\n+\t\t\ttest_dict_with_array_u32_values,\n \t\t\ttest_dict_with_array_u64_values,\n \t\t\ttest_dict_with_array_string_values,\n \t\t\ttest_dict_with_dict_values,\n \t\t\ttest_array_with_array_int_values,\n+\t\t\ttest_array_with_array_u32_values,\n \t\t\ttest_array_with_array_u64_values,\n \t\t\ttest_array_with_array_string_values,\n \t\t\ttest_string_char_escaping,\ndiff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c\nindex 184c3ba9f1..e25442f8f0 100644\n--- a/app/test/test_telemetry_json.c\n+++ b/app/test/test_telemetry_json.c\n@@ -31,7 +31,25 @@ test_basic_array(void)\n }\n \n static int\n-test_basic_obj(void)\n+test_basic_obj_u32(void)\n+{\n+\tconst char *expected = \"{\\\"weddings\\\":4,\\\"funerals\\\":1}\";\n+\tchar buf[1024];\n+\tint used = 0;\n+\n+\tused = rte_tel_json_add_obj_u32(buf, sizeof(buf), used,\n+\t\t\"weddings\", 4);\n+\tused = rte_tel_json_add_obj_u32(buf, sizeof(buf), used,\n+\t\t\"funerals\", 1);\n+\n+\tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != (int)strlen(expected))\n+\t\treturn -1;\n+\treturn strncmp(expected, buf, sizeof(buf));\n+}\n+\n+static int\n+test_basic_obj_u64(void)\n {\n \tconst char *expected = \"{\\\"weddings\\\":4,\\\"funerals\\\":1}\";\n \tchar buf[1024];\n@@ -195,7 +213,8 @@ test_telemetry_json(void)\n \tunsigned int i;\n \ttest_fn fns[] = {\n \t\t\ttest_basic_array,\n-\t\t\ttest_basic_obj,\n+\t\t\ttest_basic_obj_u32,\n+\t\t\ttest_basic_obj_u64,\n \t\t\ttest_overflow_array,\n \t\t\ttest_overflow_obj,\n \t\t\ttest_large_array_element,\n",
    "prefixes": [
        "V2",
        "03/11"
    ]
}