Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120709/?format=api
{ "id": 120709, "url": "https://patches.dpdk.org/api/patches/120709/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-5-lihuisong@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221209110450.62456-5-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221209110450.62456-5-lihuisong@huawei.com", "date": "2022-12-09T11:04:43", "name": "[V2,04/11] ethdev: fix possible data truncation and conversion error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d2e73caedf4fbb4fa1bf5a1c0e5634f8fe157e0a", "submitter": { "id": 2085, "url": "https://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-5-lihuisong@huawei.com/mbox/", "series": [ { "id": 26064, "url": "https://patches.dpdk.org/api/series/26064/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26064", "date": "2022-12-09T11:04:39", "name": "telemetry: add u32 value type and hex integer string API", "version": 2, "mbox": "https://patches.dpdk.org/series/26064/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120709/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/120709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D5E52A00C2;\n\tFri, 9 Dec 2022 12:04:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9B2C442D2B;\n\tFri, 9 Dec 2022 12:04:51 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 752F840695\n for <dev@dpdk.org>; Fri, 9 Dec 2022 12:04:48 +0100 (CET)", "from kwepemm600004.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NT7SD6xMGzJqPs;\n Fri, 9 Dec 2022 19:03:56 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 9 Dec 2022 19:04:44 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<bruce.richardson@intel.com>, <mb@smartsharesystems.com>,\n <ciara.power@intel.com>, <liudongdong3@huawei.com>, <huangdaode@huawei.com>,\n <fengchengwen@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH V2 04/11] ethdev: fix possible data truncation and conversion\n error", "Date": "Fri, 9 Dec 2022 19:04:43 +0800", "Message-ID": "<20221209110450.62456-5-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20221209110450.62456-1-lihuisong@huawei.com>", "References": "<20221208080540.62913-1-lihuisong@huawei.com>\n <20221209110450.62456-1-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemm600004.china.huawei.com (7.193.23.242)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32'\ndata need to use the 'u32' telemetry API to add, and the 'u64' data need to\nuse the 'u64' telemetry API to add.\n\nFixes: 58b43c1ddfd1 (\"ethdev: add telemetry endpoint for device info\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 5d5e18db1e..dfb269970e 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -6037,9 +6037,9 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,\n \t\t\teth_dev->data->nb_tx_queues);\n \trte_tel_data_add_dict_int(d, \"port_id\", eth_dev->data->port_id);\n \trte_tel_data_add_dict_int(d, \"mtu\", eth_dev->data->mtu);\n-\trte_tel_data_add_dict_int(d, \"rx_mbuf_size_min\",\n+\trte_tel_data_add_dict_u32(d, \"rx_mbuf_size_min\",\n \t\t\teth_dev->data->min_rx_buf_size);\n-\trte_tel_data_add_dict_int(d, \"rx_mbuf_alloc_fail\",\n+\trte_tel_data_add_dict_u64(d, \"rx_mbuf_alloc_fail\",\n \t\t\teth_dev->data->rx_mbuf_alloc_failed);\n \trte_ether_format_addr(mac_addr, sizeof(mac_addr),\n \t\t\teth_dev->data->mac_addrs);\n@@ -6068,12 +6068,12 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,\n \trte_tel_data_add_dict_container(d, \"rxq_state\", rxq_state, 0);\n \trte_tel_data_add_dict_container(d, \"txq_state\", txq_state, 0);\n \trte_tel_data_add_dict_int(d, \"numa_node\", eth_dev->data->numa_node);\n-\trte_tel_data_add_dict_int(d, \"dev_flags\", eth_dev->data->dev_flags);\n-\trte_tel_data_add_dict_int(d, \"rx_offloads\",\n+\trte_tel_data_add_dict_u32(d, \"dev_flags\", eth_dev->data->dev_flags);\n+\trte_tel_data_add_dict_u64(d, \"rx_offloads\",\n \t\t\teth_dev->data->dev_conf.rxmode.offloads);\n-\trte_tel_data_add_dict_int(d, \"tx_offloads\",\n+\trte_tel_data_add_dict_u64(d, \"tx_offloads\",\n \t\t\teth_dev->data->dev_conf.txmode.offloads);\n-\trte_tel_data_add_dict_int(d, \"ethdev_rss_hf\",\n+\trte_tel_data_add_dict_u64(d, \"ethdev_rss_hf\",\n \t\t\teth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf);\n \n \treturn 0;\n", "prefixes": [ "V2", "04/11" ] }