Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120447/?format=api
{ "id": 120447, "url": "https://patches.dpdk.org/api/patches/120447/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/a18b51355c3c07c9b76b6c2d868851b73b01abf7.1669973539.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<a18b51355c3c07c9b76b6c2d868851b73b01abf7.1669973539.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a18b51355c3c07c9b76b6c2d868851b73b01abf7.1669973539.git.wangyunjian@huawei.com", "date": "2022-12-05T08:02:29", "name": "[1/1] eal: fix error log in rte_dev_probe", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "048454777358296861ecb6d0493f2f032a50c907", "submitter": { "id": 551, "url": "https://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/a18b51355c3c07c9b76b6c2d868851b73b01abf7.1669973539.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 25994, "url": "https://patches.dpdk.org/api/series/25994/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25994", "date": "2022-12-05T08:02:29", "name": "[1/1] eal: fix error log in rte_dev_probe", "version": 1, "mbox": "https://patches.dpdk.org/series/25994/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120447/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/120447/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D341A0547;\n\tMon, 5 Dec 2022 09:02:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E8C0B40F18;\n\tMon, 5 Dec 2022 09:02:43 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 2D07B40A87;\n Mon, 5 Dec 2022 09:02:43 +0100 (CET)", "from dggpemm500008.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NQbc0521hzRpgY;\n Mon, 5 Dec 2022 16:01:52 +0800 (CST)", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec\n 2022 16:02:40 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<david.marchand@redhat.com>, <qi.z.zhang@intel.com>,\n <anatoly.burakov@intel.com>, <huangshaozhang@huawei.com>, Yunjian Wang\n <wangyunjian@huawei.com>, <stable@dpdk.org>, Lipei Liang\n <lianglipei@huawei.com>", "Subject": "[dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe", "Date": "Mon, 5 Dec 2022 16:02:29 +0800", "Message-ID": "\n <a18b51355c3c07c9b76b6c2d868851b73b01abf7.1669973539.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the device probing, there is no need to log the error message in the\ncase, that device has been already probed and return with -EEXIST.\n\nFixes: 244d5130719c (\"eal: enable hotplug on multi-process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lipei Liang <lianglipei@huawei.com>\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n lib/eal/common/eal_common_dev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c\nindex 614ef6c9fc..4650216c78 100644\n--- a/lib/eal/common/eal_common_dev.c\n+++ b/lib/eal/common/eal_common_dev.c\n@@ -264,17 +264,17 @@ rte_dev_probe(const char *devargs)\n \tret = local_dev_probe(devargs, &dev);\n \n \tif (ret != 0) {\n-\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\"Failed to attach device on primary process\\n\");\n-\n \t\t/**\n \t\t * it is possible that secondary process failed to attached a\n \t\t * device that primary process have during initialization,\n \t\t * so for -EEXIST case, we still need to sync with secondary\n \t\t * process.\n \t\t */\n-\t\tif (ret != -EEXIST)\n+\t\tif (ret != -EEXIST) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"Failed to attach device on primary process\\n\");\n \t\t\treturn ret;\n+\t\t}\n \t}\n \n \t/* primary send attach sync request to secondary. */\n", "prefixes": [ "1/1" ] }