Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120306/?format=api
{ "id": 120306, "url": "https://patches.dpdk.org/api/patches/120306/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221130035329.98118-3-ke1.xu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221130035329.98118-3-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221130035329.98118-3-ke1.xu@intel.com", "date": "2022-11-30T03:53:28", "name": "[V1,2/3] test_plans/dcf_lifecycle: remove redundant white space", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0e4e1869fa00dbea7c90030f5cfe8e34c532180d", "submitter": { "id": 2810, "url": "https://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221130035329.98118-3-ke1.xu@intel.com/mbox/", "series": [ { "id": 25935, "url": "https://patches.dpdk.org/api/series/25935/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=25935", "date": "2022-11-30T03:53:26", "name": "update test plans and tests to support represented port action and port representor action from deprecated vf action in dcf_lifecycle", "version": 1, "mbox": "https://patches.dpdk.org/series/25935/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120306/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/120306/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7FE43A00C2;\n\tWed, 30 Nov 2022 04:54:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 76AE540151;\n\tWed, 30 Nov 2022 04:54:50 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 1EBE44014F\n for <dts@dpdk.org>; Wed, 30 Nov 2022 04:54:47 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Nov 2022 19:54:47 -0800", "from dpdk-xuke-lab.sh.intel.com ([10.67.114.198])\n by orsmga006.jf.intel.com with ESMTP; 29 Nov 2022 19:54:45 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1669780488; x=1701316488;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=8oqv7vtQLk1ktWYALy8E85KDbPAiONMko/P/964cGj4=;\n b=VwmDjhfskRUdtJmHsgaZb2uY6dkINL0axPfqJ79b9v6aghwDZF/qJKVU\n YnkL6vpu1GIE7VS9Ft/Ka20l5oC4AiKoUg9//zCXPYRGdq+4JFejlnZ2I\n GEFxhxF9jDaBDWiYKWo4hl+N8uvJV3K87w923e+4z+NCsAoQhHoOOf2AU\n mOQiN+RRa4YTzQCb4MfeEeyCaUMK91jPjZWoQwgfOY0xmVtkj3Ph403Le\n d+MuLrBvGDSmXoP2O/Sjo+km1hsZvEb27wdB6etv9HE8bbj+ttt6nydZl\n K5evAooyTt/xYmuSwBLmxvZavAEoI4PtyKZUBl5R1UNeS5qb8izTrd3c7 A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10546\"; a=\"312910910\"", "E=Sophos;i=\"5.96,205,1665471600\"; d=\"scan'208\";a=\"312910910\"", "E=McAfee;i=\"6500,9779,10546\"; a=\"621728182\"", "E=Sophos;i=\"5.96,205,1665471600\"; d=\"scan'208\";a=\"621728182\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com, Ke Xu <ke1.xu@intel.com>,\n Jin Ling <jin.ling@intel.com>", "Subject": "[DTS][PATCH V1 2/3] test_plans/dcf_lifecycle: remove redundant white\n space", "Date": "Wed, 30 Nov 2022 11:53:28 +0800", "Message-Id": "<20221130035329.98118-3-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221130035329.98118-1-ke1.xu@intel.com>", "References": "<20221130035329.98118-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Signed-off-by: Jin Ling <jin.ling@intel.com>\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n test_plans/dcf_lifecycle_test_plan.rst | 112 ++++++++++++-------------\n 1 file changed, 55 insertions(+), 57 deletions(-)", "diff": "diff --git a/test_plans/dcf_lifecycle_test_plan.rst b/test_plans/dcf_lifecycle_test_plan.rst\nindex d1b19fe1..8475698a 100644\n--- a/test_plans/dcf_lifecycle_test_plan.rst\n+++ b/test_plans/dcf_lifecycle_test_plan.rst\n@@ -1046,9 +1046,9 @@ ICE DCF enable device reset API\n \n Description\n ===========\n-DCF PMD need to support rte_eth_dev_reset.The reason is that when a DCF instance be killed, all the flow rules still exist in hardware. when DCF gets to reconnect, \n-It has already lost the flow context, and if the application wants to create new rules, they may fail because FW reports that the rules already exist.The current \n-workaround assumes that the user can turn off / turn on VF trust mode, so kernel PF will reset DCF by removing all old rules.The rte_eth_dev_reset API provides \n+DCF PMD need to support rte_eth_dev_reset.The reason is that when a DCF instance be killed, all the flow rules still exist in hardware. when DCF gets to reconnect,\n+It has already lost the flow context, and if the application wants to create new rules, they may fail because FW reports that the rules already exist.The current\n+workaround assumes that the user can turn off / turn on VF trust mode, so kernel PF will reset DCF by removing all old rules.The rte_eth_dev_reset API provides\n a more elegant way for the application to reset DCF through the command \"port reset all\" when reconnecting.\n \n Prerequisites\n@@ -1070,7 +1070,7 @@ General Set Up\n # CC=gcc meson --werror -Denable_kmods=True -Dlibdir=lib --default-library=static <dpdk build dir>\n # ninja -C <dpdk build dir> -j 110\n \n-2. Get the pci device id and interface of DUT and tester. \n+2. Get the pci device id and interface of DUT and tester.\n For example, 0000:3b:00.0 and 0000:af:00.0 is pci device id,\n ens785f0 and ens260f0 is interface::\n \n@@ -1097,7 +1097,7 @@ General Set Up\n 6. Bind the DUT port to dpdk::\n \n <dpdk dir># ./usertools/dpdk-devbind.py -b vfio-pci <DUT port pci device id>\n- \n+\n Test case\n =========\n \n@@ -1107,26 +1107,26 @@ The common steps launch two testpmds and kill DCF process, then relaunch two tes\n \n 1. Launch the userland ``testpmd`` application on DUT as follows::\n \n- <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i \n+ <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i\n \n-..note:: \n+..note::\n \n For <EAL options>, you can use \"-c 0x6 -n 4\", you can also refer to testpmd doc for other setings.\n For <DUT port pci device id>, you can use \"0000:3b:01.0,cap=dcf,representor=vf[1] --file-prefix=dcf\" for this test plan.\n- \n+\n 2. Launch another ``testpmd`` application on the VF1 of DUT as follows::\n \n- <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i \n+ <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i\n \n-..note:: \n+..note::\n \n For <EAL options>, you can use \"-c 0x18 -n 4\", you can also refer to testpmd doc for other setings.\n- For this test plan, you can use \"0000:3b:01.1 --file-prefix=vf\" for this test plan. \n+ For this test plan, you can use \"0000:3b:01.1 --file-prefix=vf\" for this test plan.\n \n 3. Set verbose in VF testpmd::\n- \n+\n testpmd> set verbose 1\n- \n+\n 4. Set fwd engine and start in VF testpmd::\n \n testpmd> set fwd mac\n@@ -1151,7 +1151,7 @@ The common steps launch two testpmds and kill DCF process, then relaunch two tes\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1181,14 +1181,14 @@ Test Steps\n ~~~~~~~~~~\n 1. Check the process ID and kill DCF process::\n \n- # ps -ef |grep testpmd \n+ # ps -ef |grep testpmd\n # kill -9 #####\n \n 2. Relaunch the userland ``testpmd`` application on DUT as follows::\n \n- <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i \n+ <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i\n \n-..note:: \n+..note::\n \n For <EAL options>, you can use \"-c 0x6 -n 4\", you can also refer to testpmd doc for other setings.\n For <DUT port pci device id>, you can use \"0000:3b:01.0,cap=dcf,representor=vf[1] --file-prefix=dcf\" for this test plan.\n@@ -1233,7 +1233,7 @@ the VF1 of DUT::\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1260,7 +1260,7 @@ Test Steps\n # echo 1 > /sys/bus/pci/devices/0000:3b:01.0/reset\n \n 2. Reset port in DCF testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n@@ -1287,7 +1287,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1314,8 +1314,8 @@ Test Steps\n # echo 1 > /sys/bus/pci/devices/0000:3b:01.0/reset\n \n 2. Detach and reset port in DCF testpmd::\n- \n- testpmd> stop \n+\n+ testpmd> stop\n testpmd> port stop 0\n testpmd> port detach 0\n testpmd> port attach 3b:01.0,cap=dcf\n@@ -1343,7 +1343,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1357,7 +1357,7 @@ the VF1 of DUT::\n \n testpmd> port 0/queue 0: received 1 packets\n src=00:11:22:33:44:55 - dst=C6:44:32:0A:EC:E1 - type=0x0800 - length=98 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=14 - l3_len=20 - Receive queue=0x0\n- ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN \n+ ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN\n \n Test Case 4: two_testpmd_dcf_reset_mtu\n --------------------------------------\n@@ -1370,14 +1370,14 @@ Test Steps\n # ifconfig ens785f0 mtu 3000\n \n 2. Reset port in DCF testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n testpmd> port start all\n testpmd> start\n testpmd> flow list 0\n- \n+\n 3. Validate a switch rule to VF1 in DCF testpmd::\n \n testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 src is <ipv4 src> dst is <ipv4 dst> / end actions represented_port ethdev_port_id 1 / end\n@@ -1397,7 +1397,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1412,7 +1412,7 @@ the VF1 of DUT::\n testpmd> port 0/queue 0: received 1 packets\n src=00:11:22:33:44:55 - dst=C6:44:32:0A:EC:E1 - type=0x0800 - length=98 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=14 - l3_len=20 - Receive queue=0x0\n ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN\n- \n+\n Test Case 5: two_testpmd_dcf_reset_mac\n --------------------------------------\n The test case resets DCF by resetting mac addr, and DCF should clean up all old rules.\n@@ -1424,7 +1424,7 @@ Test Steps\n # ip link set ens785f0 vf 0 mac 00:01:02:03:04:05\n \n 2. Reset port in DCF testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n@@ -1451,7 +1451,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1473,17 +1473,17 @@ The common steps launch one testpmd and kill DCF process, then relaunch one test\n \n 1. Launch the userland ``testpmd`` application on DUT as follows::\n \n- <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i \n+ <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i\n \n-..note:: \n+..note::\n \n For <EAL options>, you can use \"-c 0x6 -n 4\", you can also refer to testpmd doc for other setings.\n For <DUT port pci device id>, you can use\"-a 3b:01.0,cap=dcf,representor=vf[1] -a 3b:01.1 --file-prefix=dcf\" for this test plan.\n \n 2. Set verbose::\n- \n+\n testpmd> set verbose 1\n- \n+\n 3. Set fwd engine and start::\n \n testpmd> set fwd mac\n@@ -1508,7 +1508,7 @@ The common steps launch one testpmd and kill DCF process, then relaunch one test\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1532,22 +1532,22 @@ Test Steps\n ~~~~~~~~~~\n 1. Check the process ID and kill DCF process::\n \n- # ps -ef |grep testpmd \n+ # ps -ef |grep testpmd\n # kill -9 #####\n \n 2. Relaunch the userland ``testpmd`` application on DUT as follows::\n \n- <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i \n+ <dpdk build dir>/app/dpdk-testpmd <EAL options> -a <DUT port pci device id> -- -i\n \n-..note:: \n+..note::\n \n For <EAL options>, you can use \"-c 0x6 -n 4\", you can also refer to testpmd doc for other setings.\n For <DUT port pci device id>, you can use\"-a 3b:01.0,cap=dcf,representor=vf[1] -a 3b:01.1 --file-prefix=dcf\" for this test plan.\n \n 3. Set verbose::\n- \n+\n testpmd> set verbose 1\n- \n+\n 4. Set fwd engine and start::\n \n testpmd> set fwd mac\n@@ -1562,10 +1562,10 @@ Tester::\n \n DUT::\n \n- testpmd> \n+ testpmd>\n \n 6. Reset port in testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n@@ -1591,7 +1591,7 @@ DUT::\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1605,7 +1605,7 @@ DUT::\n \n testpmd> port 1/queue 0: received 1 packets\n src=00:11:22:33:44:55 - dst=C6:44:32:0A:EC:E1 - type=0x0800 - length=98 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=14 - l3_len=20 - Receive queue=0x0\n- ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN \n+ ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN\n \n Test Case 7: one_testpmd_dcf_reset_device\n -----------------------------------------\n@@ -1618,7 +1618,7 @@ Test Steps\n # echo 1 > /sys/bus/pci/devices/0000:3b:01.0/reset\n \n 2. Reset port in testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n@@ -1645,7 +1645,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1672,8 +1672,8 @@ Test Steps\n # echo 1 > /sys/bus/pci/devices/0000:3b:01.0/reset\n \n 2. Detach and reset port in DCF testpmd::\n- \n- testpmd> stop \n+\n+ testpmd> stop\n testpmd> port stop 0\n testpmd> port detach 0\n testpmd> port attach 3b:01.0,cap=dcf,representor=vf[1]\n@@ -1701,7 +1701,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1715,7 +1715,7 @@ DUT::\n \n testpmd> port 1/queue 0: received 1 packets\n src=00:11:22:33:44:55 - dst=C6:44:32:0A:EC:E1 - type=0x0800 - length=98 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=14 - l3_len=20 - Receive queue=0x0\n- ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN \n+ ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN\n \n Test Case 9: one_testpmd_dcf_reset_mtu\n --------------------------------------\n@@ -1728,13 +1728,13 @@ Test Steps\n # ifconfig ens785f0 mtu 3000\n \n 2. Reset port in DCF testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n testpmd> port start all\n testpmd> start\n- testpmd> flow list 0 \n+ testpmd> flow list 0\n \n 3. Validate a switch rule to VF1::\n \n@@ -1755,7 +1755,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1782,7 +1782,7 @@ Test Steps\n # ip link set ens785f0 vf 0 mac 00:01:02:03:04:05\n \n 2. Reset port in DCF testpmd::\n- \n+\n testpmd> stop\n testpmd> port stop all\n testpmd> port reset all\n@@ -1809,7 +1809,7 @@ Test Steps\n Check the flow list::\n \n testpmd> flow list 0\n- \n+\n ID Group Prio Attr Rule\n 0 0 0 i-- ETH IPV4 => VF\n \n@@ -1824,5 +1824,3 @@ DUT::\n testpmd> port 1/queue 0: received 1 packets\n src=00:11:22:33:44:55 - dst=C6:44:32:0A:EC:E1 - type=0x0800 - length=98 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=14 - l3_len=20 - Receive queue=0x0\n ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN\n-\n-\n", "prefixes": [ "V1", "2/3" ] }