Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 12013,
    "url": "https://patches.dpdk.org/api/patches/12013/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com",
    "date": "2016-04-11T16:03:48",
    "name": "[dpdk-dev] app/testpmd: fix strcat can overrun fixed-size string",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2cb28685bb00b0509955b5c5b8fa3535f09fe95b",
    "submitter": {
        "id": 155,
        "url": "https://patches.dpdk.org/api/people/155/?format=api",
        "name": "Tomasz Kulasek",
        "email": "tomaszx.kulasek@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/12013/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/12013/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 60F7D2BEF;\n\tMon, 11 Apr 2016 18:03:59 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 87F212BEF\n\tfor <dev@dpdk.org>; Mon, 11 Apr 2016 18:03:57 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 11 Apr 2016 09:03:57 -0700",
            "from unknown (HELO Sent) ([10.217.248.18])\n\tby fmsmga002.fm.intel.com with SMTP; 11 Apr 2016 09:03:53 -0700",
            "by Sent (sSMTP sendmail emulation); Mon, 11 Apr 2016 18:03:50 +0200"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.24,462,1455004800\"; d=\"scan'208\";a=\"956299965\"",
        "From": "Tomasz Kulasek <tomaszx.kulasek@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 11 Apr 2016 18:03:48 +0200",
        "Message-Id": "<1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: fix strcat can overrun fixed-size\n\tstring",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "CID 13307 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)\nfixed_size_dest: You might overrun the 128 byte fixed-size string fwd_modes\nby copying fwd_eng->fwd_mode_name without checking the length.\n\nFixes: 769ce6b17835 (\"app/testpmd: list forwarding engines\")\n\nSigned-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>\n---\n app/test-pmd/config.c |    6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex b1bbec6..fff2d96 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1673,8 +1673,10 @@ list_pkt_forwarding_modes(void)\n \n \tif (strlen (fwd_modes) == 0) {\n \t\twhile ((fwd_eng = fwd_engines[i++]) != NULL) {\n-\t\t\tstrcat(fwd_modes, fwd_eng->fwd_mode_name);\n-\t\t\tstrcat(fwd_modes, separator);\n+\t\t\tstrncat(fwd_modes, fwd_eng->fwd_mode_name, sizeof(fwd_modes) -\n+\t\t\t\t\tstrlen(fwd_modes) - 1);\n+\t\t\tstrncat(fwd_modes, separator, sizeof(fwd_modes) - strlen(fwd_modes)\n+\t\t\t\t\t- 1);\n \t\t}\n \t\tfwd_modes[strlen(fwd_modes) - strlen(separator)] = '\\0';\n \t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}