Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120017/?format=api
{ "id": 120017, "url": "https://patches.dpdk.org/api/patches/120017/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221121223208.1147154-4-okaya@kernel.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221121223208.1147154-4-okaya@kernel.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221121223208.1147154-4-okaya@kernel.org", "date": "2022-11-21T22:32:02", "name": "[v2,03/11] memzone: check result of rte_fbarray_get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ff634d85cb3a9f454b0cdf88cd2d46b33e084d0c", "submitter": { "id": 2903, "url": "https://patches.dpdk.org/api/people/2903/?format=api", "name": "Sinan Kaya", "email": "okaya@kernel.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221121223208.1147154-4-okaya@kernel.org/mbox/", "series": [ { "id": 25843, "url": "https://patches.dpdk.org/api/series/25843/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25843", "date": "2022-11-21T22:31:59", "name": "codeql fixes for various subsystems", "version": 2, "mbox": "https://patches.dpdk.org/series/25843/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120017/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/120017/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7A811A056D;\n\tMon, 21 Nov 2022 23:32:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE56D42D4A;\n\tMon, 21 Nov 2022 23:32:19 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n by mails.dpdk.org (Postfix) with ESMTP id BA19342D38\n for <dev@dpdk.org>; Mon, 21 Nov 2022 23:32:17 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 46BEB614C1\n for <dev@dpdk.org>; Mon, 21 Nov 2022 22:32:17 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 50B49C433D7;\n Mon, 21 Nov 2022 22:32:16 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1669069936;\n bh=K5pugBFGoxJAPUF3ZEC7fWyznWQWud30IQqSknljZ7A=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=K7/Dv2LmKD1jaI/tcGt9PlsQMvaUigFa8ydxaHabxwcttJUAl3m3ucWW2iNoV+60z\n 9uKq4WirrZn/eLMh+7xo+akluaqoYsrx3h/dk2WWsU1mGObi+68SAvuQPOv+g7ZTiE\n RS8yPPnFPDvrDy2+ULm3fpiwEWdArP37GDMIRHMomPElETnJG4cwv0Bswwvz6xG/0O\n 5QvrISpvgkxTwsPvNAMWw4FOhwLAYGPVUuC/bgXBi15TvZnOHgYO0SNgo5W9hHEDFO\n ssSquA1jGoxcJY62jLLdh4LttUosek9eSYZj9uo8wU1LXgaFKnoASC3PBNCGlyVZp+\n dSwj9faUXLIzw==", "From": "okaya@kernel.org", "To": "dev@dpdk.org", "Cc": "Sinan Kaya <okaya@kernel.org>", "Subject": "[PATCH v2 03/11] memzone: check result of rte_fbarray_get", "Date": "Mon, 21 Nov 2022 17:32:02 -0500", "Message-Id": "<20221121223208.1147154-4-okaya@kernel.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221121223208.1147154-1-okaya@kernel.org>", "References": "<20221121223208.1147154-1-okaya@kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sinan Kaya <okaya@kernel.org>\n\nIn memzone_lookup_thread_unsafe result of call to rte_fbarray_get\nis dereferenced here and may be null.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\n---\n lib/eal/common/eal_common_memzone.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c\nindex 860fb5fb64..8d472505eb 100644\n--- a/lib/eal/common/eal_common_memzone.c\n+++ b/lib/eal/common/eal_common_memzone.c\n@@ -41,7 +41,7 @@ memzone_lookup_thread_unsafe(const char *name)\n \ti = rte_fbarray_find_next_used(arr, 0);\n \twhile (i >= 0) {\n \t\tmz = rte_fbarray_get(arr, i);\n-\t\tif (mz->addr != NULL &&\n+\t\tif ((mz != NULL) && (mz->addr != NULL) &&\n \t\t\t\t!strncmp(name, mz->name, RTE_MEMZONE_NAMESIZE))\n \t\t\treturn mz;\n \t\ti = rte_fbarray_find_next_used(arr, i + 1);\n@@ -358,6 +358,10 @@ dump_memzone(const struct rte_memzone *mz, void *arg)\n \tfprintf(f, \"physical segments used:\\n\");\n \tms_idx = RTE_PTR_DIFF(mz->addr, msl->base_va) / page_sz;\n \tms = rte_fbarray_get(&msl->memseg_arr, ms_idx);\n+\tif (ms == NULL) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Skipping bad memzone\\n\");\n+\t\treturn;\n+\t}\n \n \tdo {\n \t\tfprintf(f, \" addr: %p iova: 0x%\" PRIx64 \" \"\n", "prefixes": [ "v2", "03/11" ] }