Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120012/?format=api
{ "id": 120012, "url": "https://patches.dpdk.org/api/patches/120012/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221121204015.1135573-8-okaya@kernel.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221121204015.1135573-8-okaya@kernel.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221121204015.1135573-8-okaya@kernel.org", "date": "2022-11-21T20:40:13", "name": "[07/11] malloc: check result of rte_fbarray_get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d8e59255a7423fec328ca25725f8eacf0feb3540", "submitter": { "id": 2903, "url": "https://patches.dpdk.org/api/people/2903/?format=api", "name": "Sinan Kaya", "email": "okaya@kernel.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221121204015.1135573-8-okaya@kernel.org/mbox/", "series": [ { "id": 25842, "url": "https://patches.dpdk.org/api/series/25842/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25842", "date": "2022-11-21T20:40:06", "name": "codeql fixes for various subsystems", "version": 1, "mbox": "https://patches.dpdk.org/series/25842/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120012/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/120012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 267B6A056B;\n\tMon, 21 Nov 2022 21:41:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E428542D50;\n\tMon, 21 Nov 2022 21:40:40 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n by mails.dpdk.org (Postfix) with ESMTP id 131F342D43\n for <dev@dpdk.org>; Mon, 21 Nov 2022 21:40:36 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id D7878B815D5\n for <dev@dpdk.org>; Mon, 21 Nov 2022 20:40:35 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 4D806C433B5;\n Mon, 21 Nov 2022 20:40:34 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1669063234;\n bh=BPYN3i4UD0HJpTXVhiBL3FIbmMerNwTvZ3DLcv1+SaA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Y0MhgmkeYcY5QLyKG2DpGUkXHBY6d7f9rkLZnQP2989A75IHtLNyOjzUYpS2oQFdx\n eWVGga1YeU6OeASKZtgxFguje1G2gu+1fWXlCm0v1KVoZQSivSbvIAyETcDBWRp7z6\n P7angG+BPGvBt7h69dQQ8oDZ27vK50PblC++2U4Mxnnx387z2fE/R7FlzopB0ANbM9\n H51Ay8Kipfe4dgHeKki5l2459yq09sZxJzkNSXd/5HsoJ7dGVfbfz/Rw2kVdi/DX0g\n sChym7Fe7Qu4TqTtzGn9eA4IqnafGLwjaCOi49F00Uuvodt3Rki48TOsauAHMVWv2O\n PcDthSNjGSEvQ==", "From": "okaya@kernel.org", "To": "dev@dpdk.org", "Cc": "Sinan Kaya <okaya@kernel.org>", "Subject": "[PATCH 07/11] malloc: check result of rte_fbarray_get", "Date": "Mon, 21 Nov 2022 15:40:13 -0500", "Message-Id": "<20221121204015.1135573-8-okaya@kernel.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221121204015.1135573-1-okaya@kernel.org>", "References": "<20221121204015.1135573-1-okaya@kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sinan Kaya <okaya@kernel.org>\n\nIn eal_memalloc_is_contig result of call to rte_fbarray_get\nis dereferenced here and may be null.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\n---\n lib/eal/common/eal_common_memalloc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/common/eal_common_memalloc.c b/lib/eal/common/eal_common_memalloc.c\nindex ab04479c1c..e7f4bede39 100644\n--- a/lib/eal/common/eal_common_memalloc.c\n+++ b/lib/eal/common/eal_common_memalloc.c\n@@ -126,6 +126,8 @@ eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n \n \t\t/* skip first iteration */\n \t\tms = rte_fbarray_get(&msl->memseg_arr, start_seg);\n+\t\tif (!ms)\n+\t\t\treturn false;\n \t\tcur = ms->iova;\n \t\texpected = cur + pgsz;\n \n@@ -137,7 +139,7 @@ eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n \t\t\t\tcur_seg++, expected += pgsz) {\n \t\t\tms = rte_fbarray_get(&msl->memseg_arr, cur_seg);\n \n-\t\t\tif (ms->iova != expected)\n+\t\t\tif (ms && (ms->iova != expected))\n \t\t\t\treturn false;\n \t\t}\n \t}\n", "prefixes": [ "07/11" ] }