Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119948/?format=api
{ "id": 119948, "url": "https://patches.dpdk.org/api/patches/119948/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221118133928.8516-1-songx.jiale@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221118133928.8516-1-songx.jiale@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221118133928.8516-1-songx.jiale@intel.com", "date": "2022-11-18T13:39:28", "name": "[V2] tests/ice_ecpri: optimize script to solve case random failed issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6b9d01f5571bd42959b7f9e1e64ef91c5ca62f2e", "submitter": { "id": 2352, "url": "https://patches.dpdk.org/api/people/2352/?format=api", "name": "Jiale, SongX", "email": "songx.jiale@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221118133928.8516-1-songx.jiale@intel.com/mbox/", "series": [ { "id": 25812, "url": "https://patches.dpdk.org/api/series/25812/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=25812", "date": "2022-11-18T13:39:28", "name": "[V2] tests/ice_ecpri: optimize script to solve case random failed issue", "version": 2, "mbox": "https://patches.dpdk.org/series/25812/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119948/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/119948/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8191A0544;\n\tFri, 18 Nov 2022 06:21:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BCD324067B;\n\tFri, 18 Nov 2022 06:21:27 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 8F6314021F\n for <dts@dpdk.org>; Fri, 18 Nov 2022 06:21:26 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Nov 2022 21:21:25 -0800", "from unknown (HELO localhost.localdomain) ([10.239.252.94])\n by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Nov 2022 21:21:24 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1668748886; x=1700284886;\n h=from:to:cc:subject:date:message-id;\n bh=XZrXoNW4b9GS0CgXteIuxH9VoHQ0zw6n/hXJHUMNWJQ=;\n b=ltwMILznOTVKyiVnE8piuIn+yVK2dm/W+F3GoxukP63zIkzIdk2G4M87\n bCDEvviI9Vf7ABMFasJ3dojpI2wzeVkyiyICpjdzimE1OzRF5ri0dAoKm\n cc/9fiQ0MEo2tDrP6qDHZOEwpFJZ9WHT/c/JNMCSJ9qmKYp1YofE+UzFS\n zSBh22tta0KYNEyskN41XRe3DAsw4N4grWGeM51Vc+/aOe7pOYaVpi6l6\n 2nFPDietz6Fn6FegF99XuXk6ZgjlNANz6TzdQ68hAX+ULw3GCi/V6V+gA\n l5qknawh/zJHt00OphLgUeLQrXCgrVWhEcXQzuVccPUieih/j6YvxZwZI w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10534\"; a=\"313070704\"", "E=Sophos;i=\"5.96,173,1665471600\"; d=\"scan'208\";a=\"313070704\"", "E=McAfee;i=\"6500,9779,10534\"; a=\"642381702\"", "E=Sophos;i=\"5.96,173,1665471600\"; d=\"scan'208\";a=\"642381702\"" ], "From": "Song Jiale <songx.jiale@intel.com>", "To": "dts@dpdk.org", "Cc": "Song Jiale <songx.jiale@intel.com>", "Subject": "[dts] [PATCH V2] tests/ice_ecpri: optimize script to solve case\n random failed issue", "Date": "Fri, 18 Nov 2022 13:39:28 +0000", "Message-Id": "<20221118133928.8516-1-songx.jiale@intel.com>", "X-Mailer": "git-send-email 2.17.1", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "fix 2 issue that cause the case to fail randomly:\n 1. when the hash value is different, the queue may be the same. the number of different queues deleted is equal to \nthe number of different hash values.\n 2. because the queue allocated by the packets hitting the fdir rule may be the same as the queue calculated by the \nhash, but the test is to check that the queue conforming to this rule is different from the queue calculated by the hash \nvalue, which causes the case test to fail. therefore, delete the hash value calculation check in this case.\n\nSigned-off-by: Song Jiale <songx.jiale@intel.com>\n---\n\nv2:\n-modify patch description.\n\n tests/TestSuite_ice_ecpri.py | 21 +++++++++++----------\n 1 file changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/tests/TestSuite_ice_ecpri.py b/tests/TestSuite_ice_ecpri.py\nindex 92d6aa4a..4b60478b 100644\n--- a/tests/TestSuite_ice_ecpri.py\n+++ b/tests/TestSuite_ice_ecpri.py\n@@ -444,15 +444,13 @@ class TestICEEcpri(TestCase):\n data_lst = self.get_receive_lst(tag_lst, [pkt_str])\n hash_lst = [i.get(\"RSS hash\") for i in data_lst]\n self.verify(\n- len(set(hash_lst))\n- == len(tag_lst)\n- == len(set([i.get(\"queue\") for i in data_lst])),\n+ len(set(hash_lst)) == len(tag_lst),\n \"test fail, RSS hash is same.\",\n )\n # destroy rule and test\n self.pmd_output.execute_cmd(\"flow destroy 1 rule 0\")\n out = self.pmd_output.execute_cmd(\"flow list 1\")\n- data_lst = self.get_receive_lst(tag_lst, [pkt_str], stats=False)\n+ data_lst = self.get_receive_lst(tag_lst, [pkt_str], check_rss=False)\n hash_lst = [i.get(\"RSS hash\") for i in data_lst]\n self.verify(\n len(hash_lst) == 0 or len(set(hash_lst)) == 1,\n@@ -494,7 +492,7 @@ class TestICEEcpri(TestCase):\n # destroy rule and test\n self.pmd_output.execute_cmd(\"flow destroy 1 rule 0\")\n self.pmd_output.execute_cmd(\"flow list 1\")\n- data_lst = self.get_receive_lst(tag_lst, [pkt_str], stats=False)\n+ data_lst = self.get_receive_lst(tag_lst, [pkt_str], check_rss=False)\n hash_lst = [i.get(\"RSS hash\") for i in data_lst]\n self.verify(\n len(hash_lst) == 0 or len(set(hash_lst)) == 1,\n@@ -544,7 +542,7 @@ class TestICEEcpri(TestCase):\n out_data = {}\n for dst_mac in dst_mac_lst:\n pkt_lst = [pkt.format(dst_mac) for pkt in module_pkt_lst]\n- reta_line = self.get_receive_lst(tag_lst[:1], pkt_lst, stats=False)\n+ reta_line = self.get_receive_lst(tag_lst[:1], pkt_lst, check_rss=False)\n out_data.setdefault(dst_mac, reta_line)\n # verify\n for key in out_data.keys():\n@@ -1031,7 +1029,7 @@ class TestICEEcpri(TestCase):\n Mac_list[1]\n )\n ]\n- data_lst = self.get_receive_lst(tag_lst[:1], pkt_lst, stats=False)\n+ data_lst = self.get_receive_lst(tag_lst[:1], pkt_lst, check_rss=False)\n queue = [data.get(\"queue\") for data in data_lst]\n self.verify([i for i in queue if i in [\"5\", \"6\"]], \"pkt go to wrong queue!\")\n self.verify(\n@@ -1048,7 +1046,7 @@ class TestICEEcpri(TestCase):\n Mac_list[1]\n )\n ]\n- data_lst = self.get_receive_lst(tag_lst, pkt_lst, stats=False)\n+ data_lst = self.get_receive_lst(tag_lst, pkt_lst, check_rss=False)\n self.verify(\n [data.get(\"queue\") for data in data_lst] == [None, \"1\"],\n \"pkt go to wrong queue!\",\n@@ -1207,13 +1205,16 @@ class TestICEEcpri(TestCase):\n \"mark id or queue wrong!\",\n )\n \n- def get_receive_lst(self, tag_lst=[], pkt_lst=[], pmd_output=\"\", stats=True):\n+ def get_receive_lst(self, tag_lst=[], pkt_lst=[], pmd_output=\"\", check_rss=True):\n data_lst = []\n for tag in tag_lst:\n for pkt in pkt_lst:\n pkt_str = pkt % tag\n out = self.send_pkt(pkt_str=pkt_str, pmd_output=pmd_output)\n- rfc.verify_directed_by_rss(out, rxq=16, stats=stats)\n+ # packets without hash or hitting the fdir rule whose action is to queue\n+ # do not need to check the calculation of hash value.\n+ if check_rss:\n+ rfc.verify_directed_by_rss(out, rxq=16, stats=check_rss)\n reta_line = self.get_receive_data(out)\n data_lst.append(reta_line)\n return data_lst\n", "prefixes": [ "V2" ] }