Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119890/?format=api
{ "id": 119890, "url": "https://patches.dpdk.org/api/patches/119890/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221116121121.1969-1-madhuker.mythri@oracle.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221116121121.1969-1-madhuker.mythri@oracle.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221116121121.1969-1-madhuker.mythri@oracle.com", "date": "2022-11-16T12:11:21", "name": "net/failsafe: Fix crash due to in-valid sub-device port id", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4a7578453c0f34de3fe9b8c8ed159997b89bae2f", "submitter": { "id": 2516, "url": "https://patches.dpdk.org/api/people/2516/?format=api", "name": "Madhuker Mythri", "email": "madhuker.mythri@oracle.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221116121121.1969-1-madhuker.mythri@oracle.com/mbox/", "series": [ { "id": 25782, "url": "https://patches.dpdk.org/api/series/25782/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25782", "date": "2022-11-16T12:11:21", "name": "net/failsafe: Fix crash due to in-valid sub-device port id", "version": 1, "mbox": "https://patches.dpdk.org/series/25782/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119890/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 28056A055A;\n\tWed, 16 Nov 2022 13:11:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0810640E03;\n\tWed, 16 Nov 2022 13:11:57 +0100 (CET)", "from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com\n [205.220.177.32])\n by mails.dpdk.org (Postfix) with ESMTP id 3108C40DFB\n for <dev@dpdk.org>; Wed, 16 Nov 2022 13:11:55 +0100 (CET)", "from pps.filterd (m0246630.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 2AGBWaeh003361; Wed, 16 Nov 2022 12:11:55 GMT", "from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com\n (phxpaimrmta03.appoci.oracle.com [138.1.37.129])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kv3hdveby-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 16 Nov 2022 12:11:55 +0000", "from pps.filterd\n (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])\n by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5)\n with ESMTP id 2AGBt4af016789; Wed, 16 Nov 2022 12:11:54 GMT", "from pps.reinject (localhost [127.0.0.1])\n by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id\n 3kuk1x5kqe-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 16 Nov 2022 12:11:54 +0000", "from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com\n (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AGCBrcj003794;\n Wed, 16 Nov 2022 12:11:53 GMT", "from mmythri-7410.in.oracle.com (dhcp-10-191-207-105.vpn.oracle.com\n [10.191.207.105])\n by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id\n 3kuk1x5kn9-1; Wed, 16 Nov 2022 12:11:52 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding;\n s=corp-2022-7-12; bh=LbUHfuSs/D8m2YSZii+48D0x66KrV/doe4P0vWad5xM=;\n b=Zq+ncRNmxUENlbeDDmLrR8y7Uvhm1badDQjcGQ4TsqxM2JxxOXn3QLJX2xBVzVbVoPfS\n 5I0J5jnAwEI3QWAZCoO7oz1J6b8FtKW22g2R6H/nMNvggw3BbfgVCqZlFm/PTF0FG+z3\n 8NAEkFh9oCN7jgTLtQ4HRs+WAH+czlRDqTji7EEGKhLluaDPf1Lug/dlsV9JcvQC+0Yh\n FxUoFAdto0eSORI6tZqnUGBIK/O3I+OnWVjMg7t0CRWHg8mgIbGjcoDqdOXptAbpyHn8\n 1l58cHcsEdh52Z7PHSgtvpCWPOnJBPb5aONFnHrQIIKUCJSUmCzXpb5wO4o7/r5oM05v Ag==", "From": "madhuker.mythri@oracle.com", "To": "grive@u256.net", "Cc": "dev@dpdk.org, Madhuker Mythri <madhuker.mythri@oracle.com>", "Subject": "[PATCH] net/failsafe: Fix crash due to in-valid sub-device port id", "Date": "Wed, 16 Nov 2022 17:41:21 +0530", "Message-Id": "<20221116121121.1969-1-madhuker.mythri@oracle.com>", "X-Mailer": "git-send-email 2.32.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 malwarescore=0\n bulkscore=0 spamscore=0\n mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000\n definitions=main-2211160085", "X-Proofpoint-ORIG-GUID": "A0TbscYifggoJnhVSQ1_wQ94XTKlmOXq", "X-Proofpoint-GUID": "A0TbscYifggoJnhVSQ1_wQ94XTKlmOXq", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Madhuker Mythri <madhuker.mythri@oracle.com>\n\nCrash occurring while the DPDK secondary processes trying to probe the\ntap-device, where tap-device is a sub-device of Fail-safe device.\nSome-times we get in-valid sub-devices(with the in-valid port-id's),\ndue to which the IPC communication does not get response and causes the\ncommunication failures b/w primary/secondary process.\nSo, need to validate the sub-device(tap) while secondary process probe in\nthe Fail-safe PMD, to avoid such issues.\n\nBugzilla Id: 1116\n\nSigned-off-by: Madhuker Mythri <madhuker.mythri@oracle.com>\n---\n drivers/net/failsafe/failsafe.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 32811403b4..51d4440ac7 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -361,6 +361,9 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)\n \t\t\tif (sdev->devargs.name[0] == '\\0')\n \t\t\t\tcontinue;\n \n+\t\t\tif (!rte_eth_dev_is_valid_port(PORT_ID(sdev)))\n+\t\t\t\tcontinue;\n+\n \t\t\t/* rebuild devargs to be able to get the bus name. */\n \t\t\tret = rte_devargs_parse(&devargs,\n \t\t\t\t\t\tsdev->devargs.name);\n", "prefixes": [] }