Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119780/?format=api
{ "id": 119780, "url": "https://patches.dpdk.org/api/patches/119780/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221111160140.860054-2-mingjinx.ye@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221111160140.860054-2-mingjinx.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221111160140.860054-2-mingjinx.ye@intel.com", "date": "2022-11-11T16:01:40", "name": "[v4,2/2] net/ice: fix scalar Tx path segment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d63948b42bc650a09e93b9eebf1df89a1d5a9c98", "submitter": { "id": 2862, "url": "https://patches.dpdk.org/api/people/2862/?format=api", "name": "Mingjin Ye", "email": "mingjinx.ye@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221111160140.860054-2-mingjinx.ye@intel.com/mbox/", "series": [ { "id": 25727, "url": "https://patches.dpdk.org/api/series/25727/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25727", "date": "2022-11-11T16:01:39", "name": "[v4,1/2] net/ice: fix scalar Rx path segment", "version": 4, "mbox": "https://patches.dpdk.org/series/25727/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119780/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/119780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1A99A0542;\n\tFri, 11 Nov 2022 09:15:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3720427F2;\n\tFri, 11 Nov 2022 09:14:57 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 75E5340141;\n Fri, 11 Nov 2022 09:14:55 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2022 00:14:54 -0800", "from unknown (HELO yemj..) ([10.239.252.253])\n by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2022 00:14:46 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1668154495; x=1699690495;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=HgBItZ5oRZNI38DWu1k/BLO3isjCHWlc2wASGMnfx40=;\n b=UsiQ6VoUHR9vOuReN8L6ZbNAAFmdnl3Okoprhju7ATtQVbIvf9N12CAc\n KMyyzss6L+waZXScRsA0ycr3+eul+3e4wGvueUfVkOT6JAm0yOKQyJE8q\n zohurtxEZtx6FWfStamVBSM9XAGuJxaAYfjkGgPwpTCqSASkw48ItScPB\n v3Uvbn5bokkibEQ81S9tfysKNnwrOVCAYAX/yOk3WPMt2l6qQypzMpP4n\n 9KEsYqg+uqbtGTWIn9rUeErTEWpoKHf2YjIBR4LBnDCsi+gGSq1m3DMfD\n 1laBF6RwKcW8PWEyxuWyRmQar9Mx1QSNWq5EVfTubY6sVsPL/E7Plpznn A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10527\"; a=\"291957036\"", "E=Sophos;i=\"5.96,156,1665471600\"; d=\"scan'208\";a=\"291957036\"", "E=McAfee;i=\"6500,9779,10527\"; a=\"706472250\"", "E=Sophos;i=\"5.96,156,1665471600\"; d=\"scan'208\";a=\"706472250\"" ], "From": "Mingjin Ye <mingjinx.ye@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com,\n Mingjin Ye <mingjinx.ye@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,\n Kevin Liu <kevinx.liu@intel.com>", "Subject": "[PATCH v4 2/2] net/ice: fix scalar Tx path segment", "Date": "Fri, 11 Nov 2022 16:01:40 +0000", "Message-Id": "<20221111160140.860054-2-mingjinx.ye@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221111160140.860054-1-mingjinx.ye@intel.com>", "References": "<20221111120401.802805-2-mingjinx.ye@intel.com>\n <20221111160140.860054-1-mingjinx.ye@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The scalar Tx path would send empty buffer that causes the Tx queue to\noverflow.\n\nThis patch adds the last buffer length judgment in tx_prepare to fix this\nissue, rte_errno will be set to EINVAL and returned if the last buffer is\nempty.\n\nFixes: 17c7d0f9d6a4 (\"net/ice: support basic Rx/Tx\")\nFixes: ccf33dccf7aa (\"net/ice: check illegal packet sizes\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mingjin Ye <mingjinx.ye@intel.com>\nv3:\n\t* delete unused variable.\n---\n drivers/net/ice/ice_rxtx.c | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex e6ddd2513d..c1cde65a39 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -3643,6 +3643,22 @@ ice_set_tx_function_flag(struct rte_eth_dev *dev, struct ice_tx_queue *txq)\n #define ICE_MIN_TSO_MSS 64\n #define ICE_MAX_TSO_MSS 9728\n #define ICE_MAX_TSO_FRAME_SIZE 262144\n+\n+/*Check for emtpy mbuf*/\n+static inline uint16_t\n+ice_check_emtpy_mbuf(struct rte_mbuf *tx_pkt)\n+{\n+\tstruct rte_mbuf *txd = tx_pkt;\n+\n+\twhile (txd != NULL) {\n+\t\tif (txd->data_len == 0)\n+\t\t\treturn -1;\n+\t\ttxd = txd->next;\n+\t}\n+\n+\treturn 0;\n+}\n+\n uint16_t\n ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t uint16_t nb_pkts)\n@@ -3689,6 +3705,12 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\trte_errno = -ret;\n \t\t\treturn i;\n \t\t}\n+\n+\t\tif (ice_check_emtpy_mbuf(m) != 0) {\n+\t\t\trte_errno = EINVAL;\n+\t\t\tPMD_DRV_LOG(ERR, \"INVALID mbuf:\tlast mbuf data_len=[0]\");\n+\t\t\treturn i;\n+\t\t}\n \t}\n \treturn i;\n }\n", "prefixes": [ "v4", "2/2" ] }