Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119712/?format=api
{ "id": 119712, "url": "https://patches.dpdk.org/api/patches/119712/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221110081050.76753-1-ke1.xu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221110081050.76753-1-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221110081050.76753-1-ke1.xu@intel.com", "date": "2022-11-10T08:10:50", "name": "[V1] tests/tso: improve checksum verify code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cc5c8334b132f75194123f08dab7732ea84a5f67", "submitter": { "id": 2810, "url": "https://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221110081050.76753-1-ke1.xu@intel.com/mbox/", "series": [ { "id": 25692, "url": "https://patches.dpdk.org/api/series/25692/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=25692", "date": "2022-11-10T08:10:50", "name": "[V1] tests/tso: improve checksum verify code", "version": 1, "mbox": "https://patches.dpdk.org/series/25692/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119712/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119712/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F968A04FD;\n\tThu, 10 Nov 2022 09:12:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 61732400EF;\n\tThu, 10 Nov 2022 09:12:00 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 59717400D4\n for <dts@dpdk.org>; Thu, 10 Nov 2022 09:11:59 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Nov 2022 00:11:58 -0800", "from dpdk-xuke-lab.sh.intel.com ([10.67.114.198])\n by orsmga007.jf.intel.com with ESMTP; 10 Nov 2022 00:11:56 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1668067919; x=1699603919;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=0KL7yo/FZqXnS9q6wGPr4dcoCLnrDbRo/r1YB+HBkOc=;\n b=ZgrhqdecjdXLI2pZikX0fan+KHWSu8vTVjE1DbGN6fjVRVFPNdfnyw7x\n nJM+UAyuhS04449iHCN+NNP/r3xZWKCOWpPK4OXLJrJOaiUHaMvIRjS4m\n E8LUo7qqSS4R+9Ofax2XO5Xf+r2ULkO0+9bGo4Aczubou75AruD7xpEpL\n udZmcG9LQ0lI65DG51evYNIIhD8H/ecHBcYar3WNYuyiLa3fGh5ZBvqna\n qw5ami5FI17H2lfAKzy9gj/hAXVkucPowTBnJtESTsM1/y9WvDY1amorh\n rfHZi4TaS80VjkdA7tONDgRcYx00BlVFJRbo5zKgYXpeLiIAohcYMchPr w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10526\"; a=\"291645115\"", "E=Sophos;i=\"5.96,153,1665471600\"; d=\"scan'208\";a=\"291645115\"", "E=McAfee;i=\"6500,9779,10526\"; a=\"631570983\"", "E=Sophos;i=\"5.96,153,1665471600\"; d=\"scan'208\";a=\"631570983\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com,\n\tke1.xu@intel.com", "Subject": "[dts][PATCH V1] tests/tso: improve checksum verify code", "Date": "Thu, 10 Nov 2022 16:10:50 +0800", "Message-Id": "<20221110081050.76753-1-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Reimplemented the checksum calculation with a non-file method.\nReplaced property pks with a local variable pkts.\nRenamed local variable pks to pkt as it stands for a single packet.\nUse the name of layers as the index of packet to check if it is in a packet rather than check if it is in the dumped string of a packet.\nRenamed checksum_list and checksum_list1 to chksum_list_rx and checksum_list_good.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n tests/TestSuite_tso.py | 51 +++++++++++++++++-------------------------\n 1 file changed, 20 insertions(+), 31 deletions(-)", "diff": "diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py\nindex 9f4e27a3..e95f68cf 100644\n--- a/tests/TestSuite_tso.py\n+++ b/tests/TestSuite_tso.py\n@@ -138,41 +138,30 @@ class TestTSO(TestCase):\n scanner = 'tcpdump -vv -r /tmp/tcpdump_{iface}.pcap 2>/dev/null | grep \"seq\" | grep \"length\"'\n return self.tcpdump_scanner(scanner.format(**locals()))\n \n- def get_chksum_value_and_verify(self, dump_pcap, save_file, Nic_list):\n+ def get_chksum_value_and_verify(self, dump_pcap, Nic_list):\n packet = Packet()\n- self.pks = packet.read_pcapfile(dump_pcap, self.tester)\n- for i in range(len(self.pks)):\n- pks = self.pks[i]\n- out = repr(pks)\n- chksum_list = re.findall(r\"chksum=(0x\\w+)\", out)\n- pks[\"IP\"].chksum = None\n- if \"VXLAN\" in out:\n- pks[\"UDP\"].chksum = None\n- pks[\"VXLAN\"][\"IP\"].chksum = None\n- pks[\"VXLAN\"][\"TCP\"].chksum = None\n- elif \"GRE\" in out:\n- pks[\"GRE\"][\"IP\"].chksum = None\n- pks[\"GRE\"][\"TCP\"].chksum = None\n- packet.save_pcapfile(self.tester, filename=save_file)\n- self.pks = Packet().read_pcapfile(dump_pcap, self.tester)\n- self.pks1 = Packet().read_pcapfile(save_file, self.tester)\n- self.tester.send_expect(\"rm -rf %s\" % save_file, \"#\")\n- for i in range(len(self.pks1)):\n- pks = self.pks[i]\n- out = repr(pks)\n- chksum_list = re.findall(r\"chksum=(0x\\w+)\", out)\n- out1 = repr(self.pks1[i])\n- chksum_list1 = re.findall(r\"chksum=(0x\\w+)\", out1)\n- if self.nic in Nic_list and \"VXLAN\" in out:\n+ pkts = packet.read_pcapfile(dump_pcap, self.tester)\n+ for pkt in pkts:\n+ chksum_list_rx = re.findall(r\"chksum\\s*=\\s*(0x\\w+)\", pkt.show(dump=True))\n+ pkt[\"IP\"].chksum = None\n+ if \"VXLAN\" in pkt:\n+ pkt[\"UDP\"].chksum = None\n+ pkt[\"VXLAN\"][\"IP\"].chksum = None\n+ pkt[\"VXLAN\"][\"TCP\"].chksum = None\n+ elif \"GRE\" in pkt:\n+ pkt[\"GRE\"][\"IP\"].chksum = None\n+ pkt[\"GRE\"][\"TCP\"].chksum = None\n+ chksum_list_good = re.findall(r\"chksum\\s*=\\s*(0x\\w+)\", pkt.show2(dump=True))\n+ if self.nic in Nic_list and \"VXLAN\" in pkt:\n self.verify(\n- chksum_list[0] == chksum_list1[0]\n- and chksum_list[2] == chksum_list1[2]\n- and chksum_list[3] == chksum_list1[3],\n+ chksum_list_rx[0] == chksum_list_good[0]\n+ and chksum_list_rx[2] == chksum_list_good[2]\n+ and chksum_list_rx[3] == chksum_list_good[3],\n \"The obtained chksum value is incorrect.\",\n )\n else:\n self.verify(\n- chksum_list == chksum_list1,\n+ chksum_list_rx == chksum_list_good,\n \"The obtained chksum value is incorrect.\",\n )\n \n@@ -439,7 +428,7 @@ class TestTSO(TestCase):\n int(tx_outlist[num]) == loading_size % 800,\n \"the packet segmentation incorrect, %s\" % tx_outlist,\n )\n- self.get_chksum_value_and_verify(dump_pcap, save_file, Nic_list)\n+ self.get_chksum_value_and_verify(dump_pcap, Nic_list)\n \n for loading_size in self.loading_sizes:\n # Nvgre test\n@@ -474,7 +463,7 @@ class TestTSO(TestCase):\n int(tx_outlist[num]) == loading_size % 800,\n \"the packet segmentation incorrect, %s\" % tx_outlist,\n )\n- self.get_chksum_value_and_verify(dump_pcap, save_file, Nic_list)\n+ self.get_chksum_value_and_verify(dump_pcap, Nic_list)\n \n def test_perf_TSO_2ports(self):\n \"\"\"\n", "prefixes": [ "V1" ] }