Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119599/?format=api
{ "id": 119599, "url": "https://patches.dpdk.org/api/patches/119599/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20221109060923.21957-1-linglix.chen@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20221109060923.21957-1-linglix.chen@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20221109060923.21957-1-linglix.chen@intel.com", "date": "2022-11-09T06:09:23", "name": "[V1] tests/pmdrss_hash: remove port stop all command", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ced477a9b958db118c294aaf208034132a5c04cc", "submitter": { "id": 1843, "url": "https://patches.dpdk.org/api/people/1843/?format=api", "name": "Lingli Chen", "email": "linglix.chen@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20221109060923.21957-1-linglix.chen@intel.com/mbox/", "series": [ { "id": 25649, "url": "https://patches.dpdk.org/api/series/25649/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=25649", "date": "2022-11-09T06:09:23", "name": "[V1] tests/pmdrss_hash: remove port stop all command", "version": 1, "mbox": "https://patches.dpdk.org/series/25649/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119599/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3C6EA0093;\n\tWed, 9 Nov 2022 08:02:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 53BBB400D7;\n\tWed, 9 Nov 2022 08:02:38 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 52DAF400D4\n for <dts@dpdk.org>; Wed, 9 Nov 2022 08:02:36 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Nov 2022 23:02:36 -0800", "from unknown (HELO localhost.localdomain) ([10.239.252.99])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Nov 2022 23:02:34 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1667977357; x=1699513357;\n h=from:to:cc:subject:date:message-id;\n bh=a+EfnQhhmqNxmmrZgkGxKX+A4q3J8Ii5M2h1pj8K3kI=;\n b=RfG850cUyFNPNZrUJyE9K8bwuCsYFsym38V6LzSlqPnMkc/R+wNqCLgz\n Y2iYwhekipFcU1bUAaEW02s9EPhCZmflkI5U6xB1CapdqgrmgnCTzllCy\n 39MWO3hgEBZa631OmHKLBhe+5b5r7mrc0VUlP1AT/vI2qpFpErMpSuD2B\n v7RDDDKnBPZqC8fZKUKOSx9wl+O03AHNWbcdE5X4StZITm8QFE7z3/tBZ\n lQVwge5tgpEU0Qs36lCOvzzzjkBuTuVRUMhv7Q9hq7q6Q3jjmy0xCoEbZ\n 8qYMsDWRsPJYHQio2QAb080iqWCKejzyw/XqguzA51FZMkIBlGbRt+2ve w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10525\"; a=\"375183301\"", "E=Sophos;i=\"5.96,149,1665471600\"; d=\"scan'208\";a=\"375183301\"", "E=McAfee;i=\"6500,9779,10525\"; a=\"667888744\"", "E=Sophos;i=\"5.96,149,1665471600\"; d=\"scan'208\";a=\"667888744\"" ], "From": "Lingli Chen <linglix.chen@intel.com>", "To": "dts@dpdk.org", "Cc": "zhiminx.huang@intel.com,\n\tLingli Chen <linglix.chen@intel.com>", "Subject": "[dts][PATCH V1] tests/pmdrss_hash: remove port stop all command", "Date": "Wed, 9 Nov 2022 01:09:23 -0500", "Message-Id": "<20221109060923.21957-1-linglix.chen@intel.com>", "X-Mailer": "git-send-email 2.17.1", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "1. Executing the `port stop all` command destroys all flow rules associated with the port. Therefore, remove this command.\n2. modify toeplitz_symmetric case sync with testplan: the hash value and queue should be the same for symmetric packets.\n\nSigned-off-by: Lingli Chen <linglix.chen@intel.com>\n---\n tests/TestSuite_pmdrss_hash.py | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)", "diff": "diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py\nindex da9d143a..afa30bf3 100644\n--- a/tests/TestSuite_pmdrss_hash.py\n+++ b/tests/TestSuite_pmdrss_hash.py\n@@ -456,7 +456,7 @@ class TestPmdrssHash(TestCase):\n status = \"true\"\n result.insert(i, 0)\n if i % 2 == 1:\n- if pre_RSS_hash != tmp_reta_line[\"RSS hash\"]:\n+ if pre_RSS_hash == tmp_reta_line[\"RSS hash\"]:\n status = \"true\"\n result.insert(len(reta_lines) + (i - 1) // 2, 0)\n else:\n@@ -549,7 +549,6 @@ class TestPmdrssHash(TestCase):\n self.dut.send_expect(\"set promisc all off\", \"testpmd> \")\n self.dut.send_expect(\"set nbcore %d\" % (queue + 1), \"testpmd> \")\n \n- self.dut.send_expect(\"port stop all\", \"testpmd> \")\n self.dut.send_expect(\"flow flush 0\", \"testpmd> \")\n rule_cmd = f\"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}\"\n if \"sctp\" in iptype or \"udp\" in iptype or \"tcp\" in iptype:\n@@ -558,7 +557,6 @@ class TestPmdrssHash(TestCase):\n rule_cmd = rule_cmd.replace(\"ipv4\", \"ipv6\")\n outx = self.dut.send_expect(rule_cmd, \"testpmd> \")\n self.verify(\"created\" in outx, \"Create flow failed\")\n- self.dut.send_expect(\"port start all\", \"testpmd> \")\n out = self.dut.send_expect(\"port config all rss %s\" % rsstype, \"testpmd> \")\n self.verify(\n \"error\" not in out, \"Configuration of RSS hash failed: Invalid argument\"\n@@ -600,7 +598,6 @@ class TestPmdrssHash(TestCase):\n self.dut.send_expect(\"set promisc all off\", \"testpmd> \")\n self.dut.send_expect(\"set nbcore %d\" % (queue + 1), \"testpmd> \")\n \n- self.dut.send_expect(\"port stop all\", \"testpmd> \")\n self.dut.send_expect(\"flow flush 0\", \"testpmd> \")\n rule_cmd = f\"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}\"\n if \"sctp\" in iptype or \"udp\" in iptype or \"tcp\" in iptype:\n@@ -609,7 +606,6 @@ class TestPmdrssHash(TestCase):\n rule_cmd = rule_cmd.replace(\"ipv4\", \"ipv6\")\n outx = self.dut.send_expect(rule_cmd, \"testpmd> \")\n self.verify(\"created\" in outx, \"Create flow failed\")\n- self.dut.send_expect(\"port start all\", \"testpmd> \")\n out = self.dut.send_expect(\"port config all rss %s\" % rsstype, \"testpmd> \")\n self.verify(\n \"error\" not in out, \"Configuration of RSS hash failed: Invalid argument\"\n@@ -657,7 +653,6 @@ class TestPmdrssHash(TestCase):\n self.dut.send_expect(\"set promisc all off\", \"testpmd> \")\n self.dut.send_expect(\"set nbcore %d\" % (queue + 1), \"testpmd> \")\n \n- self.dut.send_expect(\"port stop all\", \"testpmd> \")\n # some nic not support change hash algorithm\n self.dut.send_expect(\"flow flush 0\", \"testpmd> \")\n rule_cmd = f\"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}\"\n@@ -667,7 +662,6 @@ class TestPmdrssHash(TestCase):\n rule_cmd = rule_cmd.replace(\"ipv4\", \"ipv6\")\n outx = self.dut.send_expect(rule_cmd, \"testpmd> \")\n self.verify(\"created\" in outx, \"Create flow failed\")\n- self.dut.send_expect(\"port start all\", \"testpmd> \")\n out = self.dut.send_expect(\"port config all rss %s\" % rsstype, \"testpmd> \")\n self.verify(\n \"error\" not in out, \"Configuration of RSS hash failed: Invalid argument\"\n", "prefixes": [ "V1" ] }