Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119589/?format=api
https://patches.dpdk.org/api/patches/119589/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221109050130.392235-1-mingxia.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109050130.392235-1-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109050130.392235-1-mingxia.liu@intel.com", "date": "2022-11-09T05:01:30", "name": "[v1] common/idpf: fix tainted scalar", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7902a3a1fc63225bfd13132e2d06c5210c9cbca8", "submitter": { "id": 2514, "url": "https://patches.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221109050130.392235-1-mingxia.liu@intel.com/mbox/", "series": [ { "id": 25643, "url": "https://patches.dpdk.org/api/series/25643/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25643", "date": "2022-11-09T05:01:30", "name": "[v1] common/idpf: fix tainted scalar", "version": 1, "mbox": "https://patches.dpdk.org/series/25643/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119589/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/119589/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C6F0A0093;\n\tWed, 9 Nov 2022 06:55:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 290BE400D7;\n\tWed, 9 Nov 2022 06:55:02 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 2D07F400D4;\n Wed, 9 Nov 2022 06:54:59 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Nov 2022 21:54:59 -0800", "from dpdk-mingxial-01.sh.intel.com ([10.67.119.112])\n by fmsmga006.fm.intel.com with ESMTP; 08 Nov 2022 21:54:57 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1667973300; x=1699509300;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=BfirQqPNF8X7xT+5gnrXgEBciMyBmpqvXMTiFzguUhw=;\n b=Rr9jhTTfEa8z3+ft3kG22FKYGMVURHO8eOGmtvG3w8opiWWlXvQH+s2I\n upPl0UtZiYtni/grfm5M9X22+BHfewhzYFG31xhg7UEqZevDCIbXxvqjB\n Q/CTXTjaYJnZG06EwvMWMQ7Fa1+5+Hw69GjV6wo++zd1AxNRaK0XzwruO\n yKTreau5mJ+OsVAqm9Ox2EPut5Edh47wLaBVXa4jPdLkNNW7IScvIgbPn\n /klT6EA185fRR3NqtP17shVdSYMrLt3J/svkEDtSo5uK+L0GRVh/LIFcy\n g6RWATOyI13YCovMBOZhaqvju25ANJM6Zw6CYTWaL9gj36ko/i87m2Vbg Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10525\"; a=\"375172650\"", "E=Sophos;i=\"5.96,149,1665471600\"; d=\"scan'208\";a=\"375172650\"", "E=McAfee;i=\"6500,9779,10525\"; a=\"881798685\"", "E=Sophos;i=\"5.96,149,1665471600\"; d=\"scan'208\";a=\"881798685\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com,\n junfeng.guo@intel.com, mingxial <mingxia.liu@intel.com>, stable@dpdk.org", "Subject": "[PATCH v1] common/idpf: fix tainted scalar", "Date": "Wed, 9 Nov 2022 05:01:30 +0000", "Message-Id": "<20221109050130.392235-1-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: mingxial <mingxia.liu@intel.com>\n\nPassing tainted expression \"msg.data_len\" to\n\"rte_memcpy\", which uses it as a loop boundary.\n\nReplace tainted expression with a temp variable\nto avoid the tainted scalar coverity warning.\n\nCoverity issue: 381688\nFixes: fb4ac04e9bfa (\"common/idpf: introduce common library\")\nCc: stable@dpdk.org\n\nSigned-off-by: mingxial <mingxia.liu@intel.com>\n---\n drivers/common/idpf/base/idpf_common.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c\nindex 1debf129a3..bcc0c11ae8 100644\n--- a/drivers/common/idpf/base/idpf_common.c\n+++ b/drivers/common/idpf/base/idpf_common.c\n@@ -221,6 +221,7 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n {\n \tstruct idpf_ctlq_msg msg = { 0 };\n \tint status;\n+\tu16 msg_data_len;\n \n \t*pending = 1;\n \n@@ -234,7 +235,8 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n \te->desc.datalen = msg.data_len;\n \tif (msg.data_len > 0) {\n \t\te->buf_len = msg.data_len;\n-\t\tidpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg.data_len,\n+\t\tmsg_data_len = msg.data_len;\n+\t\tidpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,\n \t\t\t IDPF_DMA_TO_NONDMA);\n \t}\n \treturn status;\n", "prefixes": [ "v1" ] }{ "id": 119589, "url": "