Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119406/?format=api
{ "id": 119406, "url": "https://patches.dpdk.org/api/patches/119406/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221102095408.327440-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221102095408.327440-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221102095408.327440-1-brian.dooley@intel.com", "date": "2022-11-02T09:54:08", "name": "[v2] crypto/qat: fix reallocate OpenSSL version check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3433a1d270a6170eb1b5dafb37a0cab032db1bbf", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221102095408.327440-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 25526, "url": "https://patches.dpdk.org/api/series/25526/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25526", "date": "2022-11-02T09:54:08", "name": "[v2] crypto/qat: fix reallocate OpenSSL version check", "version": 2, "mbox": "https://patches.dpdk.org/series/25526/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119406/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119406/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62B8DA00C2;\n\tWed, 2 Nov 2022 10:54:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 025A340693;\n\tWed, 2 Nov 2022 10:54:15 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 5156840223;\n Wed, 2 Nov 2022 10:54:13 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2022 02:54:12 -0700", "from silpixa00400883.ir.intel.com ([10.243.23.148])\n by orsmga006.jf.intel.com with ESMTP; 02 Nov 2022 02:54:10 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1667382853; x=1698918853;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=A+tEdSDzEPg+uzYqGybVXU3Sp6YDsZ6+Ubm0m/tZdFk=;\n b=bgkDRlx6yi4nHvnW7eGEIK4NCuuVSoGeS6qRShnJTDx8gN3MAxS6Zqbj\n Mnonm/csqvPdMD9uHEHViwdS5ij6dIOUapLWN+aMrZKaBHb8I4+qRqSf+\n MpjpfqcwT9ynuIvO6qpmncOf2Ctf3lsB1h5IX04hqt2cOOo0X8IcY128e\n vOvsiXptbvKjvie0r20ajO4uRlTk3cdbSuG0+3+hZl/SO2yGOb4sUxRjy\n 9R+o9f390JiBX/b9W3p191umos89Qs8+dLoVIznoWBycBVJxLsSSpCeN9\n bg6Vb7jtH9eLDVnK0CIhuDjLxdgz+g4EyMY0bDib5ciXoFPHWpQJrmg6t w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10518\"; a=\"311082030\"", "E=Sophos;i=\"5.95,232,1661842800\"; d=\"scan'208\";a=\"311082030\"", "E=McAfee;i=\"6500,9779,10518\"; a=\"612177217\"", "E=Sophos;i=\"5.95,232,1661842800\"; d=\"scan'208\";a=\"612177217\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Kai Ji <kai.ji@intel.com>", "Cc": "dev@dpdk.org, stable@dpdk.org, gakhil@marvell.com, david.coyle@intel.com,\n kevin.osullivan@intel.com, Brian Dooley <brian.dooley@intel.com>", "Subject": "[PATCH v2] crypto/qat: fix reallocate OpenSSL version check", "Date": "Wed, 2 Nov 2022 09:54:08 +0000", "Message-Id": "<20221102095408.327440-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221031174919.642522-1-brian.dooley@intel.com>", "References": "<20221031174919.642522-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move the ossl_legacy_provider_unload() into the right place for secure\nprotocol for QAT. Remove unnecessary unload from session destroy.\n\nFixes: 52d59b92b06d (\"crypto/qat: enable OpenSSL legacy provider in session\")\nCc: kai.ji@intel.com\nCC: stable@dpdk.org\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\nv2:\n- Use ossl legacy provider helper functions\n- Cast session pointer to void\n---\n drivers/crypto/qat/qat_sym_session.c | 26 +++++++-------------------\n 1 file changed, 7 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 71fa595031..0ebc66f89e 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -520,19 +520,7 @@ qat_sym_session_configure(struct rte_cryptodev *dev,\n \tint ret;\n \n #if (OPENSSL_VERSION_NUMBER >= 0x30000000L)\n-\t\tOSSL_PROVIDER * legacy;\n-\t\tOSSL_PROVIDER *deflt;\n-\n-\t\t/* Load Multiple providers into the default (NULL) library context */\n-\t\tlegacy = OSSL_PROVIDER_load(NULL, \"legacy\");\n-\t\tif (legacy == NULL)\n-\t\t\treturn -EINVAL;\n-\n-\t\tdeflt = OSSL_PROVIDER_load(NULL, \"default\");\n-\t\tif (deflt == NULL) {\n-\t\t\tOSSL_PROVIDER_unload(legacy);\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\tossl_legacy_provider_load();\n #endif\n \tret = qat_sym_session_set_parameters(dev, xform,\n \t\t\tCRYPTODEV_GET_SYM_SESS_PRIV(sess),\n@@ -545,8 +533,7 @@ qat_sym_session_configure(struct rte_cryptodev *dev,\n \t}\n \n # if (OPENSSL_VERSION_NUMBER >= 0x30000000L)\n-\t\tOSSL_PROVIDER_unload(legacy);\n-\t\tOSSL_PROVIDER_unload(deflt);\n+\tossl_legacy_provider_unload();\n # endif\n \treturn 0;\n }\n@@ -2639,7 +2626,8 @@ qat_sec_session_set_docsis_parameters(struct rte_cryptodev *dev,\n \t\treturn ret;\n \tqat_sym_session_finalize(session);\n \n-\treturn qat_sym_gen_dev_ops[qat_dev_gen].set_session((void *)cdev, session);\n+\treturn qat_sym_gen_dev_ops[qat_dev_gen].set_session((void *)cdev,\n+\t\t\t(void *)session);\n }\n \n int\n@@ -2668,6 +2656,9 @@ qat_security_session_create(void *dev,\n \t\treturn ret;\n \t}\n \n+#if (OPENSSL_VERSION_NUMBER >= 0x30000000L)\n+\tossl_legacy_provider_unload();\n+#endif\n \treturn 0;\n }\n \n@@ -2684,9 +2675,6 @@ qat_security_session_destroy(void *dev __rte_unused,\n \t\tmemset(s, 0, qat_sym_session_get_private_size(dev));\n \t}\n \n-# if (OPENSSL_VERSION_NUMBER >= 0x30000000L)\n-\tossl_legacy_provider_unload();\n-# endif\n \treturn 0;\n }\n \n", "prefixes": [ "v2" ] }