Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119234/?format=api
{ "id": 119234, "url": "https://patches.dpdk.org/api/patches/119234/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221027105014.371696-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221027105014.371696-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221027105014.371696-1-brian.dooley@intel.com", "date": "2022-10-27T10:50:14", "name": "[v1] crypto/qat: fix null hash algorithm digest size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3e971e1458edc3643420ccea68494b57e0d3e71c", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221027105014.371696-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 25453, "url": "https://patches.dpdk.org/api/series/25453/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25453", "date": "2022-10-27T10:50:14", "name": "[v1] crypto/qat: fix null hash algorithm digest size", "version": 1, "mbox": "https://patches.dpdk.org/series/25453/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119234/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C66FFA00C5;\n\tThu, 27 Oct 2022 12:50:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 648AC42B85;\n\tThu, 27 Oct 2022 12:50:21 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id E7EE640A7F;\n Thu, 27 Oct 2022 12:50:19 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Oct 2022 03:50:18 -0700", "from silpixa00400883.ir.intel.com ([10.243.23.148])\n by orsmga006.jf.intel.com with ESMTP; 27 Oct 2022 03:50:16 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666867820; x=1698403820;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=F5RwR8mvGeWYlhIHQdtOGP1XWJZhYedjoOWu4lPK68U=;\n b=kavHBQqNvpnATeVov8xVG+i95jLtMxDt33CONiHa7nwlhwLyEo2I2YkY\n yucQbR10zj4ZWEYmQzLRDkUgKandOMAbrBawUyS7m6/+fRnfezNAm3NQ4\n H/PppijHlqqKxTq5z83EN9IhhU9kfmhxH2fR+9nw0ORxd9f4SMYUHt5Ds\n TB0LdmYi290fFOzzASltVkmffUJWZWM9YexuRE7OPJpFUQ2L4RTOpn4yq\n vo8T0QInbPe6LTC7h5eVJzs4mDQ6n/3tmL+TDxy2mrJuTnlEwfKkbjoHu\n C4ogxdz1oUQxojB/WQH8MSLTVANhQlP33igmavjX207ya7Hp/5W+krnKW g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10512\"; a=\"305803472\"", "E=Sophos;i=\"5.95,217,1661842800\"; d=\"scan'208\";a=\"305803472\"", "E=McAfee;i=\"6500,9779,10512\"; a=\"610321369\"", "E=Sophos;i=\"5.95,217,1661842800\"; d=\"scan'208\";a=\"610321369\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Kai Ji <kai.ji@intel.com>", "Cc": "dev@dpdk.org, stable@dpdk.org, gakhil@marvell.com,\n arkadiuszx.kusztal@intel.com, Brian Dooley <brian.dooley@intel.com>,\n declan.doherty@intel.com", "Subject": "[PATCH v1] crypto/qat: fix null hash algorithm digest size", "Date": "Thu, 27 Oct 2022 10:50:14 +0000", "Message-Id": "<20221027105014.371696-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add check for null hash algorithm digest size. Digest size should be 4B\nor request will be rejected.\n\nFixes: 1703e94ac5ce (\"qat: add driver for QuickAssist devices\")\nCc: declan.doherty@intel.com\nCc: stable@dpdk.org\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\n drivers/crypto/qat/qat_sym_session.c | 19 +++++++++++++++----\n 1 file changed, 15 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex d96122b208..ff4b537706 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -2040,7 +2040,12 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \thash_offset = cdesc->cd_cur_ptr-((uint8_t *)&cdesc->cd);\n \thash = (struct icp_qat_hw_auth_setup *)cdesc->cd_cur_ptr;\n \thash->auth_config.reserved = 0;\n-\thash->auth_config.config =\n+\tif (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_NULL)\n+\t\thash->auth_config.config =\n+\t\t\tICP_QAT_HW_AUTH_CONFIG_BUILD(cdesc->auth_mode,\n+\t\t\t\tcdesc->qat_hash_alg, 4);\n+\telse\n+\t\thash->auth_config.config =\n \t\t\tICP_QAT_HW_AUTH_CONFIG_BUILD(cdesc->auth_mode,\n \t\t\t\tcdesc->qat_hash_alg, digestsize);\n \n@@ -2408,10 +2413,16 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \t/* Auth CD config setup */\n \thash_cd_ctrl->hash_cfg_offset = hash_offset >> 3;\n \thash_cd_ctrl->hash_flags = ICP_QAT_FW_AUTH_HDR_FLAG_NO_NESTED;\n-\thash_cd_ctrl->inner_res_sz = digestsize;\n-\thash_cd_ctrl->final_sz = digestsize;\n \thash_cd_ctrl->inner_state1_sz = state1_size;\n-\tauth_param->auth_res_sz = digestsize;\n+\tif (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_NULL) {\n+\t\thash_cd_ctrl->inner_res_sz = 4;\n+\t\thash_cd_ctrl->final_sz = 4;\n+\t\tauth_param->auth_res_sz = 4;\n+\t} else {\n+\t\thash_cd_ctrl->inner_res_sz = digestsize;\n+\t\thash_cd_ctrl->final_sz = digestsize;\n+\t\tauth_param->auth_res_sz = digestsize;\n+\t}\n \n \thash_cd_ctrl->inner_state2_sz = state2_size;\n \thash_cd_ctrl->inner_state2_offset = hash_cd_ctrl->hash_cfg_offset +\n", "prefixes": [ "v1" ] }