Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119035/?format=api
{ "id": 119035, "url": "https://patches.dpdk.org/api/patches/119035/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221014131836.46728-1-kim.tae.kyung@navercorp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221014131836.46728-1-kim.tae.kyung@navercorp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221014131836.46728-1-kim.tae.kyung@navercorp.com", "date": "2022-10-14T13:18:36", "name": "vdpa/ifc: fix update_datapath error handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9116b7cb4a74a63f5650458282fec6b891ff8ff8", "submitter": { "id": 2878, "url": "https://patches.dpdk.org/api/people/2878/?format=api", "name": "Taekyung Kim", "email": "nonzerosume@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221014131836.46728-1-kim.tae.kyung@navercorp.com/mbox/", "series": [ { "id": 25392, "url": "https://patches.dpdk.org/api/series/25392/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25392", "date": "2022-10-14T13:18:36", "name": "vdpa/ifc: fix update_datapath error handling", "version": 1, "mbox": "https://patches.dpdk.org/series/25392/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119035/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/119035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39869A0542;\n\tMon, 24 Oct 2022 17:33:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C324B42BB8;\n\tMon, 24 Oct 2022 17:33:08 +0200 (CEST)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id D4F1A42C6E\n for <dev@dpdk.org>; Fri, 14 Oct 2022 15:18:46 +0200 (CEST)", "by mail-pf1-f172.google.com with SMTP id f140so4900180pfa.1\n for <dev@dpdk.org>; Fri, 14 Oct 2022 06:18:46 -0700 (PDT)", "from localhost.localdomain ([121.124.172.139])\n by smtp.gmail.com with ESMTPSA id\n x6-20020a170902a38600b00179988ca61bsm1650792pla.161.2022.10.14.06.18.43\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 14 Oct 2022 06:18:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=GauJimOXhJwkkdDg9L3OhpGU6Pip50sjCyMcqEbU7ho=;\n b=pMJ95c+6m2zbeV1vFY7DoLR/SI1GlnL9skueGbhKwrlJMNw6iBVDws1b+Dq9gdzFyP\n pAbwe9J8amMd3r6QANTcj/YldmteB47amL/2ByfGy7Wg6lHjS00U8qlwjEvx03F1gZ9I\n QJm00zKytxh27WAak7/NhCyLdPLYGDBRg1eGX+xtEN3mNRm4k72Hp2Jlze8TN9ek+DbY\n PCe2S0ryd1cJW18+wNEZVNEshNlbfPtrtxxFlqZT1EkQ3LmlwodQfN3zCUtLexkbfm0j\n 1GIn0/sl+/mxGB8E32jhzRnnlwFeW1ref/8HLq4D9DAy0hawbzHrUHBFh6oJ0JO2PpiO\n dQIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=GauJimOXhJwkkdDg9L3OhpGU6Pip50sjCyMcqEbU7ho=;\n b=0lQa8Z3F1//3oG3nL9VYVh8K2udndHICjQO7sFjeTQF8EDPZC9BWPFLbKpRspDWWsU\n LeGr4MhZ97HSowpMudh18YHYPFJcJ/sv6MN7KSLiRXAHS9EOxO0i5galMornG/i3cNqv\n dLp/yM8RdEoWcKZhhcFY25b0BJc8J+4CPw/O3jfllTSetK7T/lMDToOCQwgJhozRDvVl\n aSa2J/QbLODMWE+WKPq89V62Dw6Lho/428pPFnRqXJD5mneuxOHDGQMdSGgfda602Q6x\n nLImu+guErwboZUSdhygCPYBqEXLtjiRF0/S9SF2mLIof5cgwskh5Z/2gPJQZy5ZyK1I\n vkAg==", "X-Gm-Message-State": "ACrzQf35gNMZcA4dndpryBwLmKy44lCjkyXO9W78t83KeU7yDaHo6+2b\n 9P6cTw+oxwWPSiY0KFTxAu0miJJjOJE=", "X-Google-Smtp-Source": "\n AMsMyM5fxitBkhcu8VzWl2wprzrhbO+eQQB0JgNhR9H7Ro27iVxoBCiPsvJI1o0AhPzhGAG9PjvX4Q==", "X-Received": "by 2002:a05:6a00:2184:b0:561:4fb2:86f with SMTP id\n h4-20020a056a00218400b005614fb2086fmr5394309pfi.10.1665753525915;\n Fri, 14 Oct 2022 06:18:45 -0700 (PDT)", "From": "Taekyung Kim <nonzerosume@gmail.com>", "X-Google-Original-From": "Taekyung Kim <kim.tae.kyung@navercorp.com>", "To": "dev@dpdk.org", "Cc": "Taekyung Kim <kim.tae.kyung@navercorp.com>,\n Xiao Wang <xiao.w.wang@intel.com>", "Subject": "[PATCH] vdpa/ifc: fix update_datapath error handling", "Date": "Fri, 14 Oct 2022 22:18:36 +0900", "Message-Id": "<20221014131836.46728-1-kim.tae.kyung@navercorp.com>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 24 Oct 2022 17:33:00 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Stop and return the error code when update_datapath fails.\nupdate_datapath prepares resources for the vdpa device.\nThe driver should not perform any further actions\nif update_datapath returns an error.\n\nSigned-off-by: Taekyung Kim <kim.tae.kyung@navercorp.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 20 ++++++++++++++++----\n 1 file changed, 16 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex d5ac583589..795967e998 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -1063,7 +1063,10 @@ ifcvf_dev_config(int vid)\n \tinternal = list->internal;\n \tinternal->vid = vid;\n \trte_atomic32_set(&internal->dev_attached, 1);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %p\", vdev);\n+\t\treturn -1;\n+\t}\n \n \tif (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) != 0)\n \t\tDRV_LOG(NOTICE, \"vDPA (%s): software relay is used.\",\n@@ -1105,7 +1108,10 @@ ifcvf_dev_close(int vid)\n \t\tinternal->sw_fallback_running = false;\n \t} else {\n \t\trte_atomic32_set(&internal->dev_attached, 0);\n-\t\tupdate_datapath(internal);\n+\t\tif (update_datapath(internal) < 0) {\n+\t\t\tDRV_LOG(ERR, \"failed to update datapath: %p\", vdev);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \tinternal->configured = 0;\n@@ -1632,7 +1638,10 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tpthread_mutex_unlock(&internal_list_lock);\n \n \trte_atomic32_set(&internal->started, 1);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %s\", pci_dev->name);\n+\t\treturn -1;\n+\t}\n \n \trte_kvargs_free(kvlist);\n \treturn 0;\n@@ -1661,7 +1670,10 @@ ifcvf_pci_remove(struct rte_pci_device *pci_dev)\n \n \tinternal = list->internal;\n \trte_atomic32_set(&internal->started, 0);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %s\", pci_dev->name);\n+\t\treturn -1;\n+\t}\n \n \trte_pci_unmap_device(internal->pdev);\n \trte_vfio_container_destroy(internal->vfio_container_fd);\n", "prefixes": [] }