Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118785/?format=api
{ "id": 118785, "url": "https://patches.dpdk.org/api/patches/118785/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221020111453.1982947-7-ktejasree@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221020111453.1982947-7-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221020111453.1982947-7-ktejasree@marvell.com", "date": "2022-10-20T11:14:53", "name": "[13/13] crypto/cnxk: remove dead code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d9d4df871cd1ede2e0e24bf76c1cff81b496581a", "submitter": { "id": 1789, "url": "https://patches.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221020111453.1982947-7-ktejasree@marvell.com/mbox/", "series": [ { "id": 25341, "url": "https://patches.dpdk.org/api/series/25341/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25341", "date": "2022-10-20T11:14:47", "name": "fixes and improvements to cnxk crypto PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/25341/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118785/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/118785/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A7AD4A0552;\n\tThu, 20 Oct 2022 13:15:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9B5B542D5A;\n\tThu, 20 Oct 2022 13:15:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id BC5D442D5F\n for <dev@dpdk.org>; Thu, 20 Oct 2022 13:15:10 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 29K6Q2gT008909\n for <dev@dpdk.org>; Thu, 20 Oct 2022 04:15:10 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kb1258wjp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 20 Oct 2022 04:15:10 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 20 Oct 2022 04:15:08 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 20 Oct 2022 04:15:08 -0700", "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 8829D3F7091;\n Thu, 20 Oct 2022 04:15:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=6LTsY0cjeWSyWhq0vzYgpSd1uLpzfEiO56l0FDSU1Ug=;\n b=KT12SrqfhLl6T+pGCP7FF9UGdbbuXGA1EYilJaRz+oxzM+TgQgNVvY74lQktEu2kDhFs\n tMs6xHmCraRnabXxKrNgnT7Y/naWjov/4bvpEGTbkEAD7xNlgXt/GtyU2WAhjn5kywwJ\n jkOkcXjAS1sAFkiP3VJEnvMxi0r+T0qfoOBD1LDJU3dGp6kein9PwLcmh78D/yk0U0m0\n I64QNs2h0mBa7UITsZJiXmJiEaS5d4bXP76YGv4bmOtoV4jqMBoOZm53Coau62wTjDHz\n 9RGrb0l1Rn4y2INUbPe7yMs0O1JH8Ev81+TsRnRq9cBbdK3RT5zS3tT91knGGav30A1v 0Q==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Vidya Sagar Velumuri\n <vvelumuri@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 13/13] crypto/cnxk: remove dead code", "Date": "Thu, 20 Oct 2022 16:44:53 +0530", "Message-ID": "<20221020111453.1982947-7-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221020111453.1982947-1-ktejasree@marvell.com>", "References": "<20221020111453.1982947-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "8aKxazLl16zObxhTTY6DkKgE99SBWTo6", "X-Proofpoint-ORIG-GUID": "8aKxazLl16zObxhTTY6DkKgE99SBWTo6", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2022-10-20_03,2022-10-20_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Anoob Joseph <anoobj@marvell.com>\n\nCoverity issue: 381022\nFixes: d94414d1627f (\"crypto/cnxk: separate out PDCP cipher datapath\")\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 38 ++++++++++++++---------------------\n 1 file changed, 15 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex 4675512bbc..47516592a3 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -2675,6 +2675,8 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\tfc_params.dst_iov = fc_params.src_iov = (void *)src;\n \t\tprepare_iov_from_pkt_inplace(m_src, &fc_params, &flags);\n \t} else {\n+\t\tuint32_t pkt_len;\n+\n \t\t/* Out of place processing */\n \t\tfc_params.src_iov = (void *)src;\n \t\tfc_params.dst_iov = (void *)dst;\n@@ -2686,33 +2688,23 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t\tgoto err_exit;\n \t\t}\n \n-\t\tif (unlikely(m_dst != NULL)) {\n-\t\t\tuint32_t pkt_len;\n-\n-\t\t\t/* Try to make room as much as src has */\n-\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_dst);\n-\n-\t\t\tif (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) {\n-\t\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len;\n-\t\t\t\tif (!rte_pktmbuf_append(m_dst, pkt_len)) {\n-\t\t\t\t\tplt_dp_err(\"Not enough space in \"\n-\t\t\t\t\t\t \"m_dst %p, need %u\"\n-\t\t\t\t\t\t \" more\",\n-\t\t\t\t\t\t m_dst, pkt_len);\n-\t\t\t\t\tret = -EINVAL;\n-\t\t\t\t\tgoto err_exit;\n-\t\t\t\t}\n-\t\t\t}\n+\t\t/* Try to make room as much as src has */\n+\t\tpkt_len = rte_pktmbuf_pkt_len(m_dst);\n \n-\t\t\tif (prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0)) {\n-\t\t\t\tplt_dp_err(\"Prepare dst iov failed for \"\n-\t\t\t\t\t \"m_dst %p\",\n-\t\t\t\t\t m_dst);\n+\t\tif (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) {\n+\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len;\n+\t\t\tif (unlikely(rte_pktmbuf_append(m_dst, pkt_len) == NULL)) {\n+\t\t\t\tplt_dp_err(\"Not enough space in m_dst %p, need %u more\", m_dst,\n+\t\t\t\t\t pkt_len);\n \t\t\t\tret = -EINVAL;\n \t\t\t\tgoto err_exit;\n \t\t\t}\n-\t\t} else {\n-\t\t\tfc_params.dst_iov = (void *)src;\n+\t\t}\n+\n+\t\tif (unlikely(prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0))) {\n+\t\t\tplt_dp_err(\"Prepare dst iov failed for m_dst %p\", m_dst);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto err_exit;\n \t\t}\n \t}\n \n", "prefixes": [ "13/13" ] }