Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118501/?format=api
{ "id": 118501, "url": "https://patches.dpdk.org/api/patches/118501/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221018194131.23006-35-andrew.boyer@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221018194131.23006-35-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221018194131.23006-35-andrew.boyer@amd.com", "date": "2022-10-18T19:41:29", "name": "[v2,34/36] net/ionic: use a helper variable for page size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74de6f6c39660e7a2a6e1b00d425490043a29cb9", "submitter": { "id": 2861, "url": "https://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221018194131.23006-35-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25088, "url": "https://patches.dpdk.org/api/series/25088/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25088", "date": "2022-10-11T00:49:57", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "https://patches.dpdk.org/series/25088/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118501/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/118501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1B99A0560;\n\tTue, 18 Oct 2022 21:48:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E65A742B77;\n\tTue, 18 Oct 2022 21:48:22 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2071.outbound.protection.outlook.com [40.107.223.71])\n by mails.dpdk.org (Postfix) with ESMTP id 7E0134282F\n for <dev@dpdk.org>; Tue, 18 Oct 2022 21:48:20 +0200 (CEST)", "from DS7PR06CA0031.namprd06.prod.outlook.com (2603:10b6:8:54::11) by\n CY5PR12MB6624.namprd12.prod.outlook.com (2603:10b6:930:40::14) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5723.32; Tue, 18 Oct 2022 19:48:19 +0000", "from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com\n (2603:10b6:8:54:cafe::3e) by DS7PR06CA0031.outlook.office365.com\n (2603:10b6:8:54::11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend\n Transport; Tue, 18 Oct 2022 19:48:18 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5746.16 via Frontend Transport; Tue, 18 Oct 2022 19:48:18 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct\n 2022 14:48:18 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=TT+rarOOQ8aEmNaS3fBf6MsHbKyjmbPwed5Qza3Sfj6x/TzUPTbq/enh12c0jIjWMsHUKLJUCSWfima07TKSblYDgEygU47NnseTU00GlkuweAsuNrj/XHV1ZvDT5gs71NXZWjEh9STxtkcdUlt0K8mWRYjKW/t4eSLJtY6J53CA7O0ouwx5PVkoOAsWc6DRnlYu8s708/QPD4zzaR0EyCdxQxwcQ7OxK+RIODdRLH5Hjy9+LXQXp2eC8AJOOZBT2ehxB8vfoYURAy/zaU1b4VawNw/u1qUap81ZBneOKXtIHXg9bWU2GmvIhFAbbKLibccUc7jtluP4hSDJuZKuWw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=LlcvdoKp8bmaHhpUOyyVvE2v42bEkhEYKiFFkxD6trI=;\n b=jT6KZkeFbzTIGG9T7wa4AEFBFDEmWRLqUNdcRtFjp5LJSBHNwcQSBQ3JBVPp4deHK0qFJQmnDl00zMBmi94DVEZRfYg/6vjxPtNHoZ0vVjv4qXVkZTShIAjrIYtQRNL/nHskwwMxy3jp1/TgvDLXorygMEpywN++dCRCR5d1x18HfG6O5bR4oWZty5l/5ejX9NCxWAzBoo0XPAkLd0Atka1igkeUDXxTmI+UHBQ80V5AQgP7vA2gtP6xb4D9M23hA/YrfIsY9WOoMAF6nIP+ga5NI3+hrzvURwJ8mlo7nJbv4jtCNSlOBdRPxaD/DIYwwCgRE9YbDLUaKUCkLQ/yrw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LlcvdoKp8bmaHhpUOyyVvE2v42bEkhEYKiFFkxD6trI=;\n b=wd3qs1Jr+z0fz73tIk5+RPo+LXLRl/My3+bZNZvk+xlZ5G6AVOa3xt5QJurGCrcw1tbKuP0JyFY6gXIT0h4W3tycHhrhGMQItkmospa7rZ0SwT7bDlXkhvYITyAYu9vlPBy1Bc8+GJQC5vPWosR916/qeXCPB2cZ4hPPVmAAxI4=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH v2 34/36] net/ionic: use a helper variable for page size", "Date": "Tue, 18 Oct 2022 12:41:29 -0700", "Message-ID": "<20221018194131.23006-35-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221011005032.47584-1-andrew.boyer@amd.com>", "References": "<20221011005032.47584-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT024:EE_|CY5PR12MB6624:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e3d7cee3-6092-4f41-7b78-08dab141b4b9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ZtjnH+qxUM6QD0IPvknb0KkB4tBHB2AKhm8TNjOqY+IRL27QT8l7ZxseJ6M/C0tmAJjwSW6TrtoLKY4eTYV6i85dOTMXcxe8e32+15B/Q8cPnZSat7uC21Xva7AKU/+EuJA7nP1OstkamlpXbGRZvgAYrT5+gK9kYk3xk4FQTxawQBnbPLY74Htf7Q3MHfGl3go8DrNmlWm5eGHvQlI/7KrFeLwi+RwxLxtUg2kr074qrRiasA0VcWVEzt/rawSOoUCDPh7UloT57hCfzbCGKUVorHRUIIWVaRCkZY5eUXSx+wOSsxlD4GYnDVLwymjdv/s9tpkYxJ5Bx3Jemd89kgminlVWmhWvsP/pg/PCbxNLP9j1BmxNw7NiiHdd8nPOFrTViv9BYwyGcs8oUjg04+DgucSsLchEudpQFDYbxfVsCWH59QHoTG+61OooUt5i/MRZ6LdHL4+tXnSTtyTihhcfY3mKNFTcMfu4J6YAtZ0lFs+2qfZqgo1IfA85YP1nlRGibr4KrYpoc/oZEAUM3aSpLb8TxaadwmUUY8lULJXqiVOPH0BBzy6jatSdjr5TYn6uzrckz5uWYcpCacx7wszAgSqeplp95l84o68b64g14k2cLG7t9pkIYqLa3Qmw8zEvME99LUqVdzbhb+Z2vAvU7/aa82LqT9uSwwmSpLPgng+gcOJcxFiwhq2S3tJOMxpV3GugwEd5wj8UrkvIK41N3alcKWMRRj8/dxpsCAbrO5vhfDwWDuJXZpe+ZkX0r+xZhBuvxrDu9DodPNrL8HayuLkaeEkXWS1SHJEzS5ZE0h2Iil9wyK2J+QGNztAB", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(2616005)(41300700001)(6666004)(70206006)(8936002)(6916009)(36756003)(4326008)(478600001)(8676002)(70586007)(36860700001)(16526019)(26005)(44832011)(81166007)(356005)(40480700001)(82740400003)(1076003)(86362001)(186003)(40460700003)(82310400005)(426003)(83380400001)(47076005)(316002)(336012)(2906002)(5660300002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Oct 2022 19:48:18.8766 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e3d7cee3-6092-4f41-7b78-08dab141b4b9", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT024.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY5PR12MB6624", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This improves readability.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_lif.c | 26 ++++++++++++--------------\n 1 file changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 383fff9ffd..1b5932db12 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -576,6 +576,7 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \trte_iova_t q_base_pa = 0;\n \trte_iova_t cq_base_pa = 0;\n \trte_iova_t sg_base_pa = 0;\n+\tsize_t page_size = rte_mem_page_size();\n \tint err;\n \n \t*qcq = NULL;\n@@ -584,18 +585,18 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \tcq_size = num_descs * cq_desc_size;\n \tsg_size = num_descs * sg_desc_size;\n \n-\ttotal_size = RTE_ALIGN(q_size, rte_mem_page_size()) +\n-\t\t\tRTE_ALIGN(cq_size, rte_mem_page_size());\n+\ttotal_size = RTE_ALIGN(q_size, page_size) +\n+\t\t\tRTE_ALIGN(cq_size, page_size);\n \t/*\n \t * Note: aligning q_size/cq_size is not enough due to cq_base address\n \t * aligning as q_base could be not aligned to the page.\n-\t * Adding rte_mem_page_size().\n+\t * Adding page_size.\n \t */\n-\ttotal_size += rte_mem_page_size();\n+\ttotal_size += page_size;\n \n \tif (flags & IONIC_QCQ_F_SG) {\n-\t\ttotal_size += RTE_ALIGN(sg_size, rte_mem_page_size());\n-\t\ttotal_size += rte_mem_page_size();\n+\t\ttotal_size += RTE_ALIGN(sg_size, page_size);\n+\t\ttotal_size += page_size;\n \t}\n \n \tnew = rte_zmalloc_socket(\"ionic\", struct_size,\n@@ -610,7 +611,7 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \t/* Most queue types will store 1 ptr per descriptor */\n \tnew->q.info = rte_calloc_socket(\"ionic\",\n \t\t\t\tnum_descs * num_segs, sizeof(void *),\n-\t\t\t\trte_mem_page_size(), socket_id);\n+\t\t\t\tpage_size, socket_id);\n \tif (!new->q.info) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate queue info\");\n \t\terr = -ENOMEM;\n@@ -648,16 +649,13 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \tq_base = new->base;\n \tq_base_pa = new->base_pa;\n \n-\tcq_base = (void *)RTE_ALIGN((uintptr_t)q_base + q_size,\n-\t\t\trte_mem_page_size());\n-\tcq_base_pa = RTE_ALIGN(q_base_pa + q_size,\n-\t\t\trte_mem_page_size());\n+\tcq_base = (void *)RTE_ALIGN((uintptr_t)q_base + q_size, page_size);\n+\tcq_base_pa = RTE_ALIGN(q_base_pa + q_size, page_size);\n \n \tif (flags & IONIC_QCQ_F_SG) {\n \t\tsg_base = (void *)RTE_ALIGN((uintptr_t)cq_base + cq_size,\n-\t\t\t\trte_mem_page_size());\n-\t\tsg_base_pa = RTE_ALIGN(cq_base_pa + cq_size,\n-\t\t\t\trte_mem_page_size());\n+\t\t\t\tpage_size);\n+\t\tsg_base_pa = RTE_ALIGN(cq_base_pa + cq_size, page_size);\n \t\tionic_q_sg_map(&new->q, sg_base, sg_base_pa);\n \t}\n \n", "prefixes": [ "v2", "34/36" ] }