Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118443/?format=api
{ "id": 118443, "url": "https://patches.dpdk.org/api/patches/118443/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-9-hernan.vargas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221019003918.257506-9-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221019003918.257506-9-hernan.vargas@intel.com", "date": "2022-10-19T00:38:56", "name": "[v4,08/30] baseband/acc100: allocate ring/queue mem when NULL", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "07e9f7303f7641558afc24481cff01e09251c187", "submitter": { "id": 2659, "url": "https://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-9-hernan.vargas@intel.com/mbox/", "series": [ { "id": 25287, "url": "https://patches.dpdk.org/api/series/25287/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25287", "date": "2022-10-19T00:38:48", "name": "baseband/acc100: changes for 22.11", "version": 4, "mbox": "https://patches.dpdk.org/series/25287/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118443/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/118443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A1CF9A0560;\n\tTue, 18 Oct 2022 18:43:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C4BFD42B6D;\n\tTue, 18 Oct 2022 18:42:58 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id BDF574114E;\n Tue, 18 Oct 2022 18:42:51 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Oct 2022 09:42:51 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga005.jf.intel.com with ESMTP; 18 Oct 2022 09:42:50 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666111372; x=1697647372;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=efbK+o7E5aU0cedH55x+g6myohiCXD5HLG2eapZh8jY=;\n b=dibgF820YutHk65CWLdHK4kQWHo8r6sPIs531cs84g7K4EGpJgbKvWMX\n N34zi8F00BYlYjQwFtVAsBUunZModPVFy9gklQFWr05sQ1dP3ABTKn7Ed\n JR98RDfjNQNS1KFh6AkqhQgTe6jTk6xu37Ed6gwNzIUX6liykZThxO+IF\n xJzSagYcZB4KHT+Wcvn/wFTBJAZgUSrx6a4zYbK89AKgoHfwlFJJhVbBP\n CbHFaCfA8R9sQk7UtFYRwCnAu+/PehHi+MB432yggLvOAmh7JhdC9Xuhs\n KsxZxBohSMD0oZgh9i4cWIt/Hpvgqm5+tPvhiHYvVjSI8T1h4kMBBPuGj g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10504\"; a=\"368192053\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"368192053\"", "E=McAfee;i=\"6500,9779,10504\"; a=\"803836038\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"803836038\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v4 08/30] baseband/acc100: allocate ring/queue mem when NULL", "Date": "Tue, 18 Oct 2022 17:38:56 -0700", "Message-Id": "<20221019003918.257506-9-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20221019003918.257506-1-hernan.vargas@intel.com>", "References": "<20221019003918.257506-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Allocate info ring, tail pointers and HARQ layout memory for a device\nonly if it hasn't already been allocated.\n\nFixes: 06531464151 (\"baseband/acc100: support interrupt\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 30 ++++++++++++++++++---------\n 1 file changed, 20 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex 1c83d591e3..00d02ce90d 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -408,9 +408,9 @@ allocate_info_ring(struct rte_bbdev *dev)\n \t\treg_addr = &vf_reg_addr;\n \t/* Allocate InfoRing */\n \td->info_ring = rte_zmalloc_socket(\"Info Ring\",\n-\t\t\tACC_INFO_RING_NUM_ENTRIES *\n-\t\t\tsizeof(*d->info_ring), RTE_CACHE_LINE_SIZE,\n-\t\t\tdev->data->socket_id);\n+\t\tACC_INFO_RING_NUM_ENTRIES *\n+\t\tsizeof(*d->info_ring), RTE_CACHE_LINE_SIZE,\n+\t\tdev->data->socket_id);\n \tif (d->info_ring == NULL) {\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Failed to allocate Info Ring for %s:%u\",\n@@ -499,7 +499,8 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)\n \tacc_reg_write(d, reg_addr->ring_size, value);\n \n \t/* Configure tail pointer for use when SDONE enabled */\n-\td->tail_ptrs = rte_zmalloc_socket(\n+\tif (d->tail_ptrs == NULL)\n+\t\td->tail_ptrs = rte_zmalloc_socket(\n \t\t\tdev->device->driver->name,\n \t\t\tACC100_NUM_QGRPS * ACC100_NUM_AQS * sizeof(uint32_t),\n \t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n@@ -507,8 +508,8 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)\n \t\trte_bbdev_log(ERR, \"Failed to allocate tail ptr for %s:%u\",\n \t\t\t\tdev->device->driver->name,\n \t\t\t\tdev->data->dev_id);\n-\t\trte_free(d->sw_rings);\n-\t\treturn -ENOMEM;\n+\t\tret = -ENOMEM;\n+\t\tgoto free_sw_rings;\n \t}\n \td->tail_ptr_iova = rte_malloc_virt2iova(d->tail_ptrs);\n \n@@ -531,15 +532,16 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)\n \t\t/* Continue */\n \t}\n \n-\td->harq_layout = rte_zmalloc_socket(\"HARQ Layout\",\n+\tif (d->harq_layout == NULL)\n+\t\td->harq_layout = rte_zmalloc_socket(\"HARQ Layout\",\n \t\t\tACC_HARQ_LAYOUT * sizeof(*d->harq_layout),\n \t\t\tRTE_CACHE_LINE_SIZE, dev->data->socket_id);\n \tif (d->harq_layout == NULL) {\n \t\trte_bbdev_log(ERR, \"Failed to allocate harq_layout for %s:%u\",\n \t\t\t\tdev->device->driver->name,\n \t\t\t\tdev->data->dev_id);\n-\t\trte_free(d->sw_rings);\n-\t\treturn -ENOMEM;\n+\t\tret = -ENOMEM;\n+\t\tgoto free_tail_ptrs;\n \t}\n \n \t/* Mark as configured properly */\n@@ -548,8 +550,16 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id)\n \trte_bbdev_log_debug(\n \t\t\t\"ACC100 (%s) configured sw_rings = %p, sw_rings_iova = %#\"\n \t\t\tPRIx64, dev->data->name, d->sw_rings, d->sw_rings_iova);\n-\n \treturn 0;\n+\n+free_tail_ptrs:\n+\trte_free(d->tail_ptrs);\n+\td->tail_ptrs = NULL;\n+free_sw_rings:\n+\trte_free(d->sw_rings_base);\n+\td->sw_rings = NULL;\n+\n+\treturn ret;\n }\n \n static int\n", "prefixes": [ "v4", "08/30" ] }