Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118441/?format=api
https://patches.dpdk.org/api/patches/118441/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-7-hernan.vargas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221019003918.257506-7-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221019003918.257506-7-hernan.vargas@intel.com", "date": "2022-10-19T00:38:54", "name": "[v4,06/30] baseband/acc100: check for unlikely operation vals", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b57ce1514ca769a2532f3deedb9a83a3043bcb4", "submitter": { "id": 2659, "url": "https://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-7-hernan.vargas@intel.com/mbox/", "series": [ { "id": 25287, "url": "https://patches.dpdk.org/api/series/25287/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25287", "date": "2022-10-19T00:38:48", "name": "baseband/acc100: changes for 22.11", "version": 4, "mbox": "https://patches.dpdk.org/series/25287/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118441/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/118441/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 630BDA0560;\n\tTue, 18 Oct 2022 18:43:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DD8C34281B;\n\tTue, 18 Oct 2022 18:42:56 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id AF81140395;\n Tue, 18 Oct 2022 18:42:50 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Oct 2022 09:42:50 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga005.jf.intel.com with ESMTP; 18 Oct 2022 09:42:49 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666111371; x=1697647371;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=QaTbNZdhqbqRUJjXYTAah0qOcYz3IFLqRt5408HO/J0=;\n b=Ygn7E3G0JQI3wElDpp+uSO4teLKcL5uKtDe7CpsERrFalyP66RdLci/z\n mFPY5kjOjr4qU+Za+QDsbUgYgJhfKa7YiXzV9WgtzSzxupBZlc+9/EaLd\n mGN2gt2N9m4fYC0Vzm+x+YV/h2lovhyDyUsdgtwZ6WzkvrUyFrLC2QfQ7\n zU5WXmIeztfvfG0ikv5eGtZJfSBU6+AuncY7lCbpr2HkFqcBeq9Wsq/5r\n dPw0zeKxo891r1FmAUedwNKIJ2a2LyTqFsAbbDEOaGgalc/q2fBszuoBH\n /V0NvCXTOo5sLjfVSwbploxgCKK+DK3syu4PxyALIBp0wzBGFXZa2nZDP g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10504\"; a=\"368192046\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"368192046\"", "E=McAfee;i=\"6500,9779,10504\"; a=\"803836023\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"803836023\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v4 06/30] baseband/acc100: check for unlikely operation vals", "Date": "Tue, 18 Oct 2022 17:38:54 -0700", "Message-Id": "<20221019003918.257506-7-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20221019003918.257506-1-hernan.vargas@intel.com>", "References": "<20221019003918.257506-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add unlikely checks for NULL operation values.\n\nFixes: f404dfe35cc (\"baseband/acc100: support 4G processing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex bf0d7d77e7..50c1536dee 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -2179,6 +2179,10 @@ enqueue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op,\n \tr = op->turbo_enc.tb_params.r;\n \n \twhile (mbuf_total_left > 0 && r < c) {\n+\t\tif (unlikely(input == NULL)) {\n+\t\t\trte_bbdev_log(ERR, \"Not enough input segment\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tseg_total_left = rte_pktmbuf_data_len(input) - in_offset;\n \t\t/* Set up DMA descriptor */\n \t\tdesc = acc_desc(q, total_enqueued_cbs);\n@@ -3096,6 +3100,8 @@ acc100_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,\n \t\t\tbreak;\n \t\tenqueued_cbs += ret;\n \t}\n+\tif (unlikely(enqueued_cbs == 0))\n+\t\treturn 0; /* Nothing to enqueue */\n \n \tacc_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n@@ -3624,6 +3630,8 @@ acc100_dequeue_dec(struct rte_bbdev_queue_data *q_data,\n \n \tfor (i = 0; i < dequeue_num; ++i) {\n \t\top = acc_op_tail(q, dequeued_cbs);\n+\t\tif (unlikely(op == NULL))\n+\t\t\tbreak;\n \t\tif (op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)\n \t\t\tret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,\n \t\t\t\t\t&aq_dequeued);\n@@ -3669,6 +3677,8 @@ acc100_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,\n \tfor (i = 0; i < dequeue_num; ++i) {\n \t\top = (q->ring_addr + ((q->sw_ring_tail + dequeued_cbs)\n \t\t\t& q->sw_ring_wrap_mask))->req.op_addr;\n+\t\tif (unlikely(op == NULL))\n+\t\t\tbreak;\n \t\tif (op->ldpc_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)\n \t\t\tret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,\n \t\t\t\t\t&aq_dequeued);\n", "prefixes": [ "v4", "06/30" ] }{ "id": 118441, "url": "