Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118440/?format=api
{ "id": 118440, "url": "https://patches.dpdk.org/api/patches/118440/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-6-hernan.vargas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221019003918.257506-6-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221019003918.257506-6-hernan.vargas@intel.com", "date": "2022-10-19T00:38:53", "name": "[v4,05/30] baseband/acc100: check turbo dec/enc input", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2d9d967986bd14f143fc4be0498e4d4df53a0bc9", "submitter": { "id": 2659, "url": "https://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221019003918.257506-6-hernan.vargas@intel.com/mbox/", "series": [ { "id": 25287, "url": "https://patches.dpdk.org/api/series/25287/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25287", "date": "2022-10-19T00:38:48", "name": "baseband/acc100: changes for 22.11", "version": 4, "mbox": "https://patches.dpdk.org/series/25287/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118440/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/118440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58B39A0560;\n\tTue, 18 Oct 2022 18:43:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1072141181;\n\tTue, 18 Oct 2022 18:42:56 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 2F690410F2;\n Tue, 18 Oct 2022 18:42:50 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Oct 2022 09:42:49 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga005.jf.intel.com with ESMTP; 18 Oct 2022 09:42:49 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666111370; x=1697647370;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=HbCou0+HVjXKeVF9Kajp1A6qMKJ9V56tFaWq+5VVT94=;\n b=ZiJX38foUxXJFqGBPxXc3O0w8ZFF45JJT+6rOyzhTIiO4rqS/XxOvjEQ\n 4NxyAI/7NqfQON0jmjdDz0tpuBvY03o3F0y64RZoDVqS6unjvrsdHDQ++\n P6TEO+5QLkuSTQwuyLdc7GkSXApd+tm2r/HfQcAbNFfy4DE72Ten/cZzT\n uX5PBXQSUefZLNb+bABSn0yJDrW9Ma6kzIACRlPEL50TrdDk2497+rWLE\n U15bS0nyevir9TzJVPvAOFspKrKZGmParP9eFcjdiMfyuRHXyJD6+U6z8\n X6mI7In5+KH0Bgqy7NG+Ej+i7Wu84VDqiny/MtiX938tyhozLo3OIhyQu Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10504\"; a=\"368192042\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"368192042\"", "E=McAfee;i=\"6500,9779,10504\"; a=\"803836018\"", "E=Sophos;i=\"5.95,193,1661842800\"; d=\"scan'208\";a=\"803836018\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v4 05/30] baseband/acc100: check turbo dec/enc input", "Date": "Tue, 18 Oct 2022 17:38:53 -0700", "Message-Id": "<20221019003918.257506-6-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20221019003918.257506-1-hernan.vargas@intel.com>", "References": "<20221019003918.257506-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add NULL check for the turbo decoder and encoder input length.\n\nFixes: 3bfc5f60403 (\"baseband/acc100: add debug function to validate input\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 23 ++++++++++++++++++-----\n 1 file changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex a80ecdca84..bf0d7d77e7 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -1763,6 +1763,11 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q)\n \t\treturn -1;\n \t}\n \n+\tif (unlikely(turbo_enc->input.length == 0)) {\n+\t\trte_bbdev_log(ERR, \"input length null\");\n+\t\treturn -1;\n+\t}\n+\n \tif (turbo_enc->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) {\n \t\ttb = &turbo_enc->tb_params;\n \t\tif ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE\n@@ -1782,11 +1787,12 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q)\n \t\t\t\t\tRTE_BBDEV_TURBO_MAX_CB_SIZE);\n \t\t\treturn -1;\n \t\t}\n-\t\tif (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1))\n+\t\tif (unlikely(tb->c_neg > 0)) {\n \t\t\trte_bbdev_log(ERR,\n-\t\t\t\t\t\"c_neg (%u) is out of range 0 <= value <= %u\",\n-\t\t\t\t\ttb->c_neg,\n-\t\t\t\t\tRTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1);\n+\t\t\t\t\t\"c_neg (%u) expected to be null\",\n+\t\t\t\t\ttb->c_neg);\n+\t\t\treturn -1;\n+\t\t}\n \t\tif (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) {\n \t\t\trte_bbdev_log(ERR,\n \t\t\t\t\t\"c (%u) is out of range 1 <= value <= %u\",\n@@ -2280,6 +2286,11 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q)\n \t\treturn -1;\n \t}\n \n+\tif (unlikely(turbo_dec->input.length == 0)) {\n+\t\trte_bbdev_log(ERR, \"input length null\");\n+\t\treturn -1;\n+\t}\n+\n \tif (turbo_dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) {\n \t\ttb = &turbo_dec->tb_params;\n \t\tif ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE\n@@ -2300,11 +2311,13 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q)\n \t\t\t\t\tRTE_BBDEV_TURBO_MAX_CB_SIZE);\n \t\t\treturn -1;\n \t\t}\n-\t\tif (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1))\n+\t\tif (unlikely(tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1))) {\n \t\t\trte_bbdev_log(ERR,\n \t\t\t\t\t\"c_neg (%u) is out of range 0 <= value <= %u\",\n \t\t\t\t\ttb->c_neg,\n \t\t\t\t\tRTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1);\n+\t\t\t\t\treturn -1;\n+\t\t}\n \t\tif (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) {\n \t\t\trte_bbdev_log(ERR,\n \t\t\t\t\t\"c (%u) is out of range 1 <= value <= %u\",\n", "prefixes": [ "v4", "05/30" ] }