Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1184,
    "url": "https://patches.dpdk.org/api/patches/1184/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415347284-15468-1-git-send-email-liang.xu@cinfotech.cn/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1415347284-15468-1-git-send-email-liang.xu@cinfotech.cn>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1415347284-15468-1-git-send-email-liang.xu@cinfotech.cn",
    "date": "2014-11-07T08:01:24",
    "name": "[dpdk-dev,v6] eal: map uio resources after hugepages when the base_virtaddr is configured.",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "bd1c927ac7bbb8e48b2153f9ba2c2baf9adb5363",
    "submitter": {
        "id": 106,
        "url": "https://patches.dpdk.org/api/people/106/?format=api",
        "name": "lxu",
        "email": "liang.xu@cinfotech.cn"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415347284-15468-1-git-send-email-liang.xu@cinfotech.cn/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1184/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1184/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0BA337EC4;\n\tFri,  7 Nov 2014 08:52:15 +0100 (CET)",
            "from out1134-201.mail.aliyun.com (out1134-201.mail.aliyun.com\n\t[42.120.134.201]) by dpdk.org (Postfix) with ESMTP id 7E89C590B\n\tfor <dev@dpdk.org>; Fri,  7 Nov 2014 08:52:12 +0100 (CET)",
            "from dev.SSG-140(mailfrom:liang.xu@cinfotech.cn ip:203.110.175.218)\n\tby smtp.aliyun-inc.com(10.147.34.67); Fri, 07 Nov 2014 16:01:32 +0800"
        ],
        "X-Alimail-AntiSpam": "AC=CONTINUE; BC=0.1407826|-1; FP=0|0|0|0|0|-1|-1|-1;\n\tHT=r41g08146; MF=liang.xu@cinfotech.cn; PH=DS; RN=4; RT=4; SR=0; ",
        "From": "lxu <liang.xu@cinfotech.cn>",
        "To": "dev@dpdk.org",
        "Date": "Fri,  7 Nov 2014 16:01:24 +0800",
        "Message-Id": "<1415347284-15468-1-git-send-email-liang.xu@cinfotech.cn>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn>",
        "References": "<1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn>",
        "Subject": "[dpdk-dev] [PATCH v6] eal: map uio resources after hugepages when\n\tthe base_virtaddr is configured.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "A multiple process DPDK application must mmap hugepages and pci resource into same virtual addresses. By default the virtual addresses chosen by the primary process automatically when calling the mmap. But sometime the virtual addresses chosen by the primary process isn't usable at secondary process. Such as the secondary process linked with more libraries than primary process. The library has been mapped into this virtual address. The command line parameter 'base-virtaddr' has been added for this situation. If it's configured, the hugepages will be mapped into this base address. But the virtual address of uio resource mapped still does not refer to the parameter. In that case it would still fail.\n\nThis patch try to map uio resources after hugepages when the base_virtaddr is configured. So the error of \"EAL: pci_map_resource(): cannot mmap\" can be resolved by set base-virtaddr into free virtual address space.\n\nSigned-off-by: lxu <liang.xu@cinfotech.cn>\n---\n lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 ++++++++++++++++++++++++++++-\n 1 file changed, 28 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\nindex 7e62266..a2c9ab6 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n@@ -273,6 +273,24 @@ pci_get_uio_dev(struct rte_pci_device *dev, char *dstbuf,\n \treturn uio_num;\n }\n \n+static inline const struct rte_memseg *\n+get_physmem_last(void)\n+{\n+\tconst struct rte_memseg * seg = rte_eal_get_physmem_layout();\n+\tconst struct rte_memseg * last = seg;\n+\tunsigned i = 0;\n+\n+\tfor (i=0; i<RTE_MAX_MEMSEG; i++, seg++) {\n+\t\tif (seg->addr == NULL)\n+\t\t\tbreak;\n+\n+\t\tif(seg->addr > last->addr)\n+\t\t \tlast = seg;\n+\n+\t}\n+\treturn last;\n+}\n+\n /* map the PCI resource of a PCI device in virtual memory */\n int\n pci_uio_map_resource(struct rte_pci_device *dev)\n@@ -290,6 +308,13 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \tstruct mapped_pci_resource *uio_res;\n \tstruct pci_map *maps;\n \n+\t/* map uio resource into user required virtual address */\n+\tstatic void * requested_addr;\n+\tif (internal_config.base_virtaddr && NULL == requested_addr) {\n+\t\tconst struct rte_memseg * last = get_physmem_last();\n+\t\trequested_addr = RTE_PTR_ADD(last->addr, last->len);\n+\t}\n+\n \tdev->intr_handle.fd = -1;\n \tdev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;\n \n@@ -371,10 +396,12 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \t\t\tif (maps[j].addr != NULL)\n \t\t\t\tfail = 1;\n \t\t\telse {\n-\t\t\t\tmapaddr = pci_map_resource(NULL, fd, (off_t)offset,\n+\t\t\t\tmapaddr = pci_map_resource(requested_addr, fd, (off_t)offset,\n \t\t\t\t\t\t(size_t)maps[j].size);\n \t\t\t\tif (mapaddr == NULL)\n \t\t\t\t\tfail = 1;\n+\t\t\t\telse if (NULL != requested_addr)\n+\t\t\t\t\trequested_addr = RTE_PTR_ADD(mapaddr, maps[j].size);\n \t\t\t}\n \n \t\t\tif (fail) {\n",
    "prefixes": [
        "dpdk-dev",
        "v6"
    ]
}