Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 11833,
    "url": "https://patches.dpdk.org/api/patches/11833/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1459414919-44829-5-git-send-email-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1459414919-44829-5-git-send-email-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1459414919-44829-5-git-send-email-pablo.de.lara.guarch@intel.com",
    "date": "2016-03-31T09:01:55",
    "name": "[dpdk-dev,v2,4/8] l2fwd-crypto: fix length of random IV/AAD",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d030b11ab179095fdb76bdbcfd91fe64c255b122",
    "submitter": {
        "id": 9,
        "url": "https://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1459414919-44829-5-git-send-email-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/11833/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/11833/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C8D9F5A83;\n\tThu, 31 Mar 2016 11:02:06 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 6E1915A1F\n\tfor <dev@dpdk.org>; Thu, 31 Mar 2016 11:02:00 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP; 31 Mar 2016 02:02:00 -0700",
            "from sie-lab-214-036.ir.intel.com (HELO\n\tsie-lab-214-36.ir.intel.com) ([10.237.214.36])\n\tby orsmga002.jf.intel.com with ESMTP; 31 Mar 2016 02:01:58 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.24,421,1455004800\"; d=\"scan'208\";a=\"945104489\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "declan.doherty@intel.com, Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Thu, 31 Mar 2016 10:01:55 +0100",
        "Message-Id": "<1459414919-44829-5-git-send-email-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.5.5",
        "In-Reply-To": "<1459414919-44829-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "References": "<1459342950-52434-1-git-send-email-pablo.de.lara.guarch@intel.com>\n\t<1459414919-44829-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 4/8] l2fwd-crypto: fix length of random IV/AAD",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "App was generating a random IV/AAD of only 4 bytes,\ninstead of the actual length, since it was using sizeof(length).\n\nFixes: 27cf2d1b18e1 (\"examples/l2fwd-crypto: discover capabilities\")\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n examples/l2fwd-crypto/main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex 1b0c229..c323b55 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -643,7 +643,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n \t\t\t\tport_cparams[i].aad.phys_addr = options->aad.phys_addr;\n \t\t\t\tif (!options->aad_param)\n \t\t\t\t\tgenerate_random_key(port_cparams[i].aad.data,\n-\t\t\t\t\t\tsizeof(port_cparams[i].aad.length));\n+\t\t\t\t\t\tport_cparams[i].aad.length);\n \n \t\t\t}\n \n@@ -661,7 +661,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n \t\t\tport_cparams[i].iv.phys_addr = options->iv.phys_addr;\n \t\t\tif (!options->iv_param)\n \t\t\t\tgenerate_random_key(port_cparams[i].iv.data,\n-\t\t\t\t\t\tsizeof(port_cparams[i].iv.length));\n+\t\t\t\t\t\tport_cparams[i].iv.length);\n \n \t\t\tport_cparams[i].cipher_algo = options->cipher_xform.cipher.algo;\n \t\t}\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "4/8"
    ]
}