Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11828/?format=api
{ "id": 11828, "url": "https://patches.dpdk.org/api/patches/11828/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1459373905-10296-1-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1459373905-10296-1-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1459373905-10296-1-git-send-email-stephen@networkplumber.org", "date": "2016-03-30T21:38:25", "name": "[dpdk-dev] vmxnet3: remove asserts that confuse coverity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "625d42a4363f380c0646552f721aa11888eb3730", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1459373905-10296-1-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/11828/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/11828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 55D602C72;\n\tWed, 30 Mar 2016 23:38:14 +0200 (CEST)", "from mail-pa0-f42.google.com (mail-pa0-f42.google.com\n\t[209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 2D89C2C61\n\tfor <dev@dpdk.org>; Wed, 30 Mar 2016 23:38:12 +0200 (CEST)", "by mail-pa0-f42.google.com with SMTP id zm5so49995139pac.0\n\tfor <dev@dpdk.org>; Wed, 30 Mar 2016 14:38:12 -0700 (PDT)", "from xeon-e3.home.lan (static-50-53-73-178.bvtn.or.frontiernet.net.\n\t[50.53.73.178]) by smtp.gmail.com with ESMTPSA id\n\tzp5sm8145221pac.9.2016.03.30.14.38.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 30 Mar 2016 14:38:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=TC9XmlaJElUHBMm8tXffQiUTSAdQM0c3VFh7PD3Vjxc=;\n\tb=G2HimiWc5BbFp8MpjNMQ2IfTHkhiXeXr6hiR2m29QsYu++p25KcMMr7yZajr8p6rqa\n\tZix/oJmSqcXIQInbgAYswN5PBEb5xD05cwtLpLR9I9T6ZgLDf1wUKtGbfCLtKnler4Ql\n\tt+fROCoXI2sPka7QhDHVlv0Ia1GbdX5R6yZ2fbeUtTZ+9Pd80Mtdox+EkXikesxgCDQo\n\tDRaTRvjl+DNOhjYNvhnyjk5NhQXQfcsnAGzhnnNVFXWgF0F5MJiCXqHkyuy3CKXLMpis\n\t6Syd6PCMeTpOQ5NUu/2yEZZvZk/VmfOqbU987tb22rpWWDtbGgeLICJ2BsGjYugj3zbd\n\tdSPw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=TC9XmlaJElUHBMm8tXffQiUTSAdQM0c3VFh7PD3Vjxc=;\n\tb=A5IhyelEiF/ed8A6KNM82XOycIYNI2gstxTOnTcwJQFwAgEcLS83MkfxM4wGROeTcH\n\tUOyhwB5gD6yFVwzA4mspjopyLMOfLKQf8EACp0wE5itYZf1e01l+al/NQHxwfVPjcjqd\n\t8YH6RmXZy60krgXIq28l0RsXEL04jzgyLY+T3Es3Tuc/rYoA0iOr+Qf2LG2Y/Qy9+1Uj\n\tP4Ky8jSix0G4qnvuahLYxDPdeijXwLSJuuvG4OVzaowBZi6eRNCnZFssCzk0nmhaOoNT\n\tFVTokOe2mjTLf4/v08dDinLESysN91/nD7ibAnCjqwrzlPWMab1GefxgiYoHDOR2mRPJ\n\tp8Ig==", "X-Gm-Message-State": "AD7BkJKSfWSDiBntXaVa38fCEi6RyqgPZGJHjzFpG9OhnQPzat9WfDcMQnb15TMNZGhJyw==", "X-Received": "by 10.66.90.136 with SMTP id bw8mr16724948pab.52.1459373891355; \n\tWed, 30 Mar 2016 14:38:11 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Yong Wang <yongwang@vmware.com>", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 30 Mar 2016 14:38:25 -0700", "Message-Id": "<1459373905-10296-1-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "Subject": "[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These asserts are only for debugging and never fired during\nany testing, but they confuse coverity's null tracking.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex 66b0eed..f72156a 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t * the last mbuf of the current packet.\n \t\t */\n \t\tif (rcd->sop) {\n-\t\t\tVMXNET3_ASSERT(rxq->start_seg != NULL);\n \t\t\tVMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);\n \n \t\t\tif (unlikely(rcd->len == 0)) {\n@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\tstruct rte_mbuf *start = rxq->start_seg;\n \n \t\t\tVMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);\n-\t\t\tVMXNET3_ASSERT(start != NULL);\n \n \t\t\tstart->pkt_len += rxm->data_len;\n \t\t\tstart->nb_segs++;\n", "prefixes": [ "dpdk-dev" ] }