Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118098/?format=api
{ "id": 118098, "url": "https://patches.dpdk.org/api/patches/118098/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221012235037.3293072-2-abdullah.sevincer@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221012235037.3293072-2-abdullah.sevincer@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221012235037.3293072-2-abdullah.sevincer@intel.com", "date": "2022-10-12T23:50:35", "name": "[v2,2/4] event/dlb2: add check valid producer coremask", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f44964c45d8336902c179daf28cdbebd6320709d", "submitter": { "id": 2843, "url": "https://patches.dpdk.org/api/people/2843/?format=api", "name": "Sevincer, Abdullah", "email": "abdullah.sevincer@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221012235037.3293072-2-abdullah.sevincer@intel.com/mbox/", "series": [ { "id": 25193, "url": "https://patches.dpdk.org/api/series/25193/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25193", "date": "2022-10-12T23:50:34", "name": "[v2,1/4] event/dlb2: remove cos from port probing", "version": 2, "mbox": "https://patches.dpdk.org/series/25193/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/118098/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/118098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 69EBFA00C2;\n\tThu, 13 Oct 2022 01:51:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C1B2642C27;\n\tThu, 13 Oct 2022 01:51:05 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 0BFC542C27\n for <dev@dpdk.org>; Thu, 13 Oct 2022 01:51:03 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Oct 2022 16:50:42 -0700", "from txanpdk02.an.intel.com ([10.123.117.76])\n by orsmga006.jf.intel.com with ESMTP; 12 Oct 2022 16:50:41 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1665618664; x=1697154664;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=hw2Z23jK2/NoCFTItVAVZZSwl2EpQ2uDI8Wvr0UOex8=;\n b=EQKRzYv1pk/ZqQH+brWlhtMKVwJ6EcK6JoF5LeK/2d6dwayd1BkY8pZR\n el8Fm8uAvEW9z/qn279gAXOFh5uBm0N1e6FjGmc7t3A73iDvG1hB9T3co\n e3ryzv5sIAilXCLGFph1YpH2gNFULOplt+foNn4AZzmyMhNqpZHo3LDWC\n 9vufCBhpOcB1lGpvEa7x1j7bGyddABYwGvrcV8CHw1Sb8kuBogh8kLLda\n qNkoa9lfpJmFi5ioiR/tBHDjvP0X0KTfj48aho9KaUH6RJW5UHSNKJy2x\n 6CY1ndZ7YsMgC1jJ4wczIpRCNQVsA3h8lvR3oyYnH+GJbqZA0LskSjz+7 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10498\"; a=\"366936403\"", "E=Sophos;i=\"5.95,180,1661842800\"; d=\"scan'208\";a=\"366936403\"", "E=McAfee;i=\"6500,9779,10498\"; a=\"604746838\"", "E=Sophos;i=\"5.95,180,1661842800\"; d=\"scan'208\";a=\"604746838\"" ], "X-ExtLoop1": "1", "From": "Abdullah Sevincer <abdullah.sevincer@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com,\n\tAbdullah Sevincer <abdullah.sevincer@intel.com>", "Subject": "[PATCH v2 2/4] event/dlb2: add check valid producer coremask", "Date": "Wed, 12 Oct 2022 18:50:35 -0500", "Message-Id": "<20221012235037.3293072-2-abdullah.sevincer@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221012235037.3293072-1-abdullah.sevincer@intel.com>", "References": "<20221012143247.3239356-1-abdullah.sevincer@intel.com,\n shivani.doneria@intel.com>\n <20221012235037.3293072-1-abdullah.sevincer@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit add checks during port probing\nfor validating producer core masks if\nthey are a subset of eal coremask. Error\nis returned if producer coremask is not a subset\nof eal coremask.\n\nSigned-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>\n---\n drivers/event/dlb2/pf/base/dlb2_resource.c | 21 +++++++++++++--------\n 1 file changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c\nindex 3f36acb6a4..dd8390a013 100644\n--- a/drivers/event/dlb2/pf/base/dlb2_resource.c\n+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c\n@@ -918,9 +918,8 @@ int\n dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)\n {\n \tconst struct dlb2_devargs *args = (const struct dlb2_devargs *)probe_args;\n-\tconst char *mask = NULL;\n-\tint cpu = 0, cnt = 0, cores[RTE_MAX_LCORE];\n-\tint i;\n+\tconst char *mask = args ? args->producer_coremask : NULL;\n+\tint cpu = 0, cnt = 0, cores[RTE_MAX_LCORE], i;\n \n \tif (args) {\n \t\tmask = (const char *)args->producer_coremask;\n@@ -933,16 +932,17 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)\n \n \thw->num_prod_cores = 0;\n \tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\t\tbool is_pcore = (mask && cores[i] != -1);\n+\n \t\tif (rte_lcore_is_enabled(i)) {\n-\t\t\tif (mask) {\n+\t\t\tif (is_pcore) {\n \t\t\t\t/*\n \t\t\t\t * Populate the producer cores from parsed\n \t\t\t\t * coremask\n \t\t\t\t */\n-\t\t\t\tif (cores[i] != -1) {\n-\t\t\t\t\thw->prod_core_list[cores[i]] = i;\n-\t\t\t\t\thw->num_prod_cores++;\n-\t\t\t\t}\n+\t\t\t\thw->prod_core_list[cores[i]] = i;\n+\t\t\t\thw->num_prod_cores++;\n+\n \t\t\t} else if ((++cnt == DLB2_EAL_PROBE_CORE ||\n \t\t\t rte_lcore_count() < DLB2_EAL_PROBE_CORE)) {\n \t\t\t\t/*\n@@ -952,7 +952,12 @@ dlb2_resource_probe(struct dlb2_hw *hw, const void *probe_args)\n \t\t\t\tcpu = i;\n \t\t\t\tbreak;\n \t\t\t}\n+\t\t} else if (is_pcore) {\n+\t\t\tDLB2_LOG_ERR(\"Producer coremask(%s) must be a subset of EAL coremask\",\n+\t\t\t\t mask);\n+\t\t\treturn -1;\n \t\t}\n+\n \t}\n \t/* Use the first core in producer coremask to probe */\n \tif (hw->num_prod_cores)\n", "prefixes": [ "v2", "2/4" ] }