Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117867/?format=api
{ "id": 117867, "url": "https://patches.dpdk.org/api/patches/117867/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221010214720.766459-1-mpiszczek@ddn.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221010214720.766459-1-mpiszczek@ddn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221010214720.766459-1-mpiszczek@ddn.com", "date": "2022-10-10T21:47:19", "name": "[v3] pci: read amd iommu virtual address width", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "22b1ed0780bd29977aa0a96fc4a509a946a2b08c", "submitter": { "id": 2840, "url": "https://patches.dpdk.org/api/people/2840/?format=api", "name": "Michael Piszczek", "email": "mpiszczek@ddn.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221010214720.766459-1-mpiszczek@ddn.com/mbox/", "series": [ { "id": 25127, "url": "https://patches.dpdk.org/api/series/25127/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25127", "date": "2022-10-10T21:47:19", "name": "[v3] pci: read amd iommu virtual address width", "version": 3, "mbox": "https://patches.dpdk.org/series/25127/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117867/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/117867/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D6DCA0544;\n\tTue, 11 Oct 2022 03:51:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7059942BC8;\n\tTue, 11 Oct 2022 03:51:11 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84])\n by mails.dpdk.org (Postfix) with ESMTP id CA2FE40146\n for <dev@dpdk.org>; Mon, 10 Oct 2022 23:47:33 +0200 (CEST)", "from DM5PR07CA0089.namprd07.prod.outlook.com (2603:10b6:4:ae::18) by\n DM4PR19MB6341.namprd19.prod.outlook.com (2603:10b6:8:a8::17) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5709.15; Mon, 10 Oct 2022 21:47:31 +0000", "from DM6NAM04FT050.eop-NAM04.prod.protection.outlook.com\n (2603:10b6:4:ae:cafe::a8) by DM5PR07CA0089.outlook.office365.com\n (2603:10b6:4:ae::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend\n Transport; Mon, 10 Oct 2022 21:47:31 +0000", "from uww-mx01.datadirectnet.com (50.222.100.11) by\n DM6NAM04FT050.mail.protection.outlook.com (10.13.159.146) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 21:47:30 +0000", "from localhost (unknown [10.68.0.8])\n by uww-mx01.datadirectnet.com (Postfix) with ESMTP id 2FD7D20C684B;\n Mon, 10 Oct 2022 15:48:41 -0600 (MDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=K3or/wAPIJnrW5ZwCO0ZDYufzzJ+GKBLlVmM2Q7COwY1C7ZGL8EZAmA96D5CzZKgbhcE9Xk3VYECivhahh8y0DO58opFcqa6iroIRIcF0OVcP/7D/E866hOpPOK9ZmlLy5zU2OJTWFasAKaQEQlxJgjr5bL12eyzLHrjR0tAnatCJzk1IVs/byQR/l/Zihab2esZ139EN+1qj7jBghSd6DudFf/g8p1aXupwrAXR6AC8w9r0Dz0ONIO9meKe54LNxRIAl32NiIE0GasDrsw8AhCxvzwHoUy1hFiqcnmHKb6k702gn0VkkGuIUZ3B+DNwDJdlqXaL8Mwv5OFC5Mkf9A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6RFBDaZJY9leCz+YJ5hcLitKpkHpdJzxh8SVVyW4IOk=;\n b=aPdTOJYALa/+CWxQ2a5K57um57rF/mFpqfLt1tZNB93mnrkmD5JHrNPYVCQ0DLc2HE2+m/RaOXg2jK/P1/AU11jL8a4UP+x5pnamX8L1NP79JEoGbNnl21lDKsZ88pEw47wLGnL0GKaELARWe3oHqoJKsA58dq5aYzq6UStZpOH1glUhKMt0hu9e8PL6cTNYrKpAsfkCcbP6MbXNDUG38Ey4dZIGQ915DYg9Ld+6yUeXVOacw4DITQioZb/LP7f+8FZwaG3k6tzlDukbChK02kLn0l64WkcvjvNBw8NK/2vdEUoJUmTWFo6+XlDORjcfvBTgp8fgon9nIjl+lwpAJw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 50.222.100.11) smtp.rcpttodomain=amd.com smtp.mailfrom=ddn.com; dmarc=pass\n (p=reject sp=none pct=100) action=none header.from=ddn.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6RFBDaZJY9leCz+YJ5hcLitKpkHpdJzxh8SVVyW4IOk=;\n b=fNCpL7fXXLuCXNWrJbm2AaFqugWrOzES/U9HvdcGsiJrZr+pknTEWKKPADleqmf95Vp17TiqmKgWCwikz4MW3WBAUysS3N4gHxo+qzM3QAjt+3nIBqutI9cFLPt/Y7AHxquz3tkIvfa7xsaNhkC+7U7kiES1lAZgUZO17lBQhoo=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 50.222.100.11)\n smtp.mailfrom=ddn.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ddn.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ddn.com designates\n 50.222.100.11 as permitted sender) receiver=protection.outlook.com;\n client-ip=50.222.100.11; helo=uww-mx01.datadirectnet.com; pr=C", "From": "Michael Piszczek <mpiszczek@ddn.com>", "To": "dev@dpdk.org", "Cc": "Vipin.Varghese@amd.com,\n\tMichael Piszczek <mpiszczek@ddn.com>", "Subject": "[PATCH v3] pci: read amd iommu virtual address width", "Date": "Mon, 10 Oct 2022 23:47:19 +0200", "Message-Id": "<20221010214720.766459-1-mpiszczek@ddn.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "References": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM04FT050:EE_|DM4PR19MB6341:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "00c75939-f6f9-41de-47fe-08daab09086c", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n VzFZVZcUf+MhZR2nmgPH89yoJOVpU4L1YvDGo4SjsZFEZfPwGhyXwbGGQEUiEip9zKABZX2Dtp5kmustWhSStXGSov1K+760PhAmIxce+vn/njyBJVGGRCt1ChhiPgwv/IwIMx0lM33DxuEOe0BEuwL++2OVtHwuhd6bTOTN7CThvzZ5QywfcGwDERiraSuYDbgEQzF7wi3zj6H8d6yGnGustDOUl50jmY4vsKt5HQsbaBM3JLhp+H1tC0tT4R/gOPShFKX0YmiMlfJYexsnnwh4/56orUQw2nVljw6h6rUVIyIiUL0Zd2tSzwYGshz+Xpys/1Kfyb6gwH3D0BsH6X7HeP0kqbITkJ3hoTdodNkljd/YPvvpDAiXksqtumCqCWKoVGPJhYFVmtyLO56ixyX5itEvxtUabdjSncJuTh8Ei12kim0mflxQcjworftr6BUuVrMDulw5UYvpNzLwAR7XGMiAV7VKgzBPk0eX8zWHuGDaQowjClkYCaqjwMr21h9hsa/LrL2LbHEd0YMvWR0EZo5JxeUBG2D6ug7SPGUS7sdJc6iNOrDUqkz+Ty2pDoU0WN6Z6yAefxu/pthjXcPOXfPkpc6kDFIT7AwU5YXyL/UWQaelV747uGN+ciKU3/IAs4ssrfRflvbncEMZDn86AK9yvomV5L9lexoxkkLkNn6+jSxTU8Ko3bW+wbLsn6PwI5w53vNieLBVMPCCtl3xggXc7ErACKfjFC/obUTmdDoDS8ULhwv3FIgbSpzbGGwnoVioxR9x12r0bVyFvw==", "X-Forefront-Antispam-Report": "CIP:50.222.100.11; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:uww-mx01.datadirectnet.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230022)(4636009)(396003)(39850400004)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(36756003)(40480700001)(2906002)(86362001)(70586007)(186003)(1076003)(41300700001)(4326008)(8936002)(70206006)(8676002)(81166007)(356005)(5660300002)(316002)(82740400003)(6916009)(36860700001)(478600001)(336012)(6666004)(83380400001)(6266002)(82310400005)(2616005)(26005)(47076005)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ddn.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Oct 2022 21:47:30.9934 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 00c75939-f6f9-41de-47fe-08daab09086c", "X-MS-Exchange-CrossTenant-Id": "753b6e26-6fd3-43e6-8248-3f1735d59bb4", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4; Ip=[50.222.100.11];\n Helo=[uww-mx01.datadirectnet.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM04FT050.eop-NAM04.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR19MB6341", "X-Mailman-Approved-At": "Tue, 11 Oct 2022 03:51:08 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add code to read the virtual address width for AMD processors.\n\nSigned-off-by: Michael Piszczek <mpiszczek@ddn.com>\n---\n drivers/bus/pci/linux/pci.c | 47 +++++++++++++++++++++++--------------\n 1 file changed, 30 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex e521459870..8c6082ee7a 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -492,15 +492,18 @@ rte_pci_scan(void)\n }\n \n #if defined(RTE_ARCH_X86)\n+\n bool\n pci_device_iommu_support_va(const struct rte_pci_device *dev)\n {\n #define VTD_CAP_MGAW_SHIFT\t16\n #define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define RD_AMD_CAP_VASIZE_SHIFT 15\n+#define RD_AMD_CAP_VASIZE_MASK (0x7F << RD_AMD_CAP_VASIZE_SHIFT)\n \tconst struct rte_pci_addr *addr = &dev->addr;\n \tchar filename[PATH_MAX];\n \tFILE *fp;\n-\tuint64_t mgaw, vtd_cap_reg = 0;\n+\tuint64_t mgaw, cap_reg = 0;\n \n \tsnprintf(filename, sizeof(filename),\n \t\t \"%s/\" PCI_PRI_FMT \"/iommu/intel-iommu/cap\",\n@@ -508,26 +511,36 @@ pci_device_iommu_support_va(const struct rte_pci_device *dev)\n \t\t addr->function);\n \n \tfp = fopen(filename, \"r\");\n-\tif (fp == NULL) {\n-\t\t/* We don't have an Intel IOMMU, assume VA supported */\n-\t\tif (errno == ENOENT)\n-\t\t\treturn true;\n-\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't open %s: %s\\n\",\n-\t\t\t__func__, filename, strerror(errno));\n-\t\treturn false;\n-\t}\n+\tif (fp != NULL) {\n+\t\t/* We have an Intel IOMMU */\n+\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t RTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\tfclose(fp);\n+\t\t\treturn false;\n+\t\t}\n \n-\t/* We have an Intel IOMMU */\n-\tif (fscanf(fp, \"%\" PRIx64, &vtd_cap_reg) != 1) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n \t\tfclose(fp);\n-\t\treturn false;\n+\t\tmgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n \t}\n+\telse {\n+\t\tsnprintf(filename, sizeof(filename),\n+\t\t\t \"%s/\" PCI_PRI_FMT \"/iommu/amd-iommu/cap\",\n+\t\t\t rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n+\t\t\t addr->function);\n+\n+\t\tfp = fopen(filename, \"r\");\n+\t\tif (fp != NULL) {\n+\t\t\t/* We have an Amd IOMMU */\n+\t\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t\t RTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\t\tfclose(fp);\n+\t\t\t\treturn false;\n+\t\t\t}\n \n-\tfclose(fp);\n-\n-\tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\t\t\tfclose(fp);\n+\t\t\tmgaw = ((cap_reg & RD_AMD_CAP_VASIZE_MASK) >> RD_AMD_CAP_VASIZE_SHIFT) + 1;\n+\t\t}\n+\t}\n \n \t/*\n \t * Assuming there is no limitation by now. We can not know at this point\n", "prefixes": [ "v3" ] }