Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117611/?format=api
{ "id": 117611, "url": "https://patches.dpdk.org/api/patches/117611/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-31-andrew.boyer@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007174336.54354-31-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007174336.54354-31-andrew.boyer@amd.com", "date": "2022-10-07T17:43:31", "name": "[30/35] net/ionic: add alignment and socket info in allocations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aff1c0529e05f61edccbf30b1c23cff8ff606859", "submitter": { "id": 2861, "url": "https://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-31-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25037, "url": "https://patches.dpdk.org/api/series/25037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25037", "date": "2022-10-07T17:43:01", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "https://patches.dpdk.org/series/25037/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117611/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2AF04A04FD;\n\tFri, 7 Oct 2022 19:47:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 11CB342C09;\n\tFri, 7 Oct 2022 19:45:14 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2053.outbound.protection.outlook.com [40.107.92.53])\n by mails.dpdk.org (Postfix) with ESMTP id 7D27E42BDB\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:45:09 +0200 (CEST)", "from MW4PR03CA0332.namprd03.prod.outlook.com (2603:10b6:303:dc::7)\n by SN7PR12MB6909.namprd12.prod.outlook.com (2603:10b6:806:263::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct\n 2022 17:45:06 +0000", "from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:dc:cafe::85) by MW4PR03CA0332.outlook.office365.com\n (2603:10b6:303:dc::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend\n Transport; Fri, 7 Oct 2022 17:45:06 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:45:05 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct\n 2022 12:45:02 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=YWfBr5efvm2OUch/R8x1RaLJq6xGs5Vhv2UPTlmDYObXoVNzZ4BdscfUye/hpcfimn84tqIaWTmlRv0NEmPl4HG049s4zu0Q4GIXx0/N20JmwKkx0q4KOcy+jkj2pBrV76mJAICN3o80ps2z/Nx7LulsnYTWsDns6kZrIPiwbt9W2kz+BLuTRokafcnzgbfuL6XtWVgQXEXv89pkMzPb2B8kVWbNfvXa+Kttje6A+NbIS4SkihhCbTSbOnncv2Hl+HEMtnUMY62uu7Mtd0hJioyLIV09TC8DDwsorhypTiKdETU1gFcf+XwQeaM4t2F1/1zlgN1hzBu1x259ot1ing==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4IbUbm1maboOS8MtFY/vuuNq/lASa8Zxb9GD2E7/Mm0=;\n b=KdWy5u7fnm5tYZVjNi5oBUD8D4hdguunnAU/1n5PyReOOZ/WQYhfb01EtUf8vHW0EOZ98nSg+LxyVydqcJ+hzDk0MR4kbyKLi414sFx3o6JUWY7l24+AIKD1oyRdiPkY0DIdiBAzYeYKIEejVHvYO4dtjj7tkgwrRXJhQgP9dOtSuGGJoEVYvZLLYAJPjz9LPa2Hm92GQTOUc9spbERKO1iXDd3kew21xqplJKHOx7BS5OjQnl/koqYqP1Es3aG3/n84WRvscYjssf4U6NFCyUxtUU657dY1ZOUIE7PWuIXrrsXF9AV+Igrt6zTkE6TIw2mCPOulqQ1VNv3mq/aR9Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=4IbUbm1maboOS8MtFY/vuuNq/lASa8Zxb9GD2E7/Mm0=;\n b=mm6vzVCofNNLlEKuf1c+31W+GnlXmZrYREwHUxKU/TVwokvkISbVuey5TjKE0FQS25YylyppFX0fyA1i3ahN3CvCTs9WByEQe/pYFpl7WaUoGhk98lpQchSHUBabeCHNsbkdqL0vh6M0tVrtjsBlUTncoMRWK7EwqdoHLiZ67Yc=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH 30/35] net/ionic: add alignment and socket info in allocations", "Date": "Fri, 7 Oct 2022 10:43:31 -0700", "Message-ID": "<20221007174336.54354-31-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221007174336.54354-1-andrew.boyer@amd.com>", "References": "<20221007174336.54354-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT068:EE_|SN7PR12MB6909:EE_", "X-MS-Office365-Filtering-Correlation-Id": "0a539fca-9142-4eb3-5bd0-08daa88babad", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n kl86n/I8fwett3+QnzpBNTKhMgCIe/WyMlu+znnFlxz+80OA6UZp+N/eZlpta7t2ZbjDpo+HHnTfXM/1z9YIgIvlsWgbuJEZAj34nyVZf37efJvCdpRvL6p5Vw+w9HzRr5rFQ9jq2PWk2Mt+8m3cvLjy3hlvuuFdOijKCJ7da15VSkTPc1sMp3TnIa8EK8JDzPuTwRaNXcC0WOkDGCgSXOHSt9V9IhigRuDNtk27WlbWn8Y/2Px9zHin3wAZay4Uifzz5wjSgpNUnWR/6XKuESTrmwWCn7dM62DCmHeGQHFsmibUeyJFvvoaUOzHTlCxj6UZVdbhW1w2AbImLnuM//wRrEXuHOQQ7Zu0egBX0cAg1MtFOFSlIhXMWPFVVhPseOv3dft+hvtCMkUdgajDB5BjUZ8AvU5ZwPSMs0MWuUVfy6XJJnTn5smHiBhenYC8DeGWeRtifKnEq8o0vjUsfxuYNQ1XPY5VnL84DnLeE0+Fz6mwjp9akSOPMgCO50+8h3TIp1hTaM2INZLeyLVBTao6f9jej5VrjQJL7h67zwYSFOrci82hOpjEeS1PU566ZDRFErGXmiwMfE7h+8ylSPQVzjAyZV2u5gn3JFsPpjZKZ3RXrk1PhyWszYD7/ciWRDGAaeFV7mBWXTPLr3mluQ2bRIT6kjBLh796uO5NHahz6aLfOn0HINsgx5t6BswQ30hBvGMmmFpEJm4OgPqnegPsexGewEVAv9BjpFzuyQZyzaMJeWdpO+Fvch5B7h0nZO7i45Fswou+KWgPTIakmAgvw0Cd5v+OXywgzLOPcGLP6bto3VLGgEe3KGzel4J0", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(44832011)(5660300002)(41300700001)(186003)(47076005)(316002)(16526019)(6666004)(356005)(82310400005)(86362001)(2616005)(70206006)(70586007)(2906002)(6916009)(81166007)(336012)(1076003)(40460700003)(82740400003)(8676002)(8936002)(83380400001)(4326008)(426003)(36756003)(26005)(40480700001)(478600001)(36860700001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Oct 2022 17:45:05.8813 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0a539fca-9142-4eb3-5bd0-08daa88babad", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT068.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB6909", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This will avoid memory access penalties on NUMA systems.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_ethdev.c | 5 +++--\n drivers/net/ionic/ionic_lif.c | 13 ++++++++-----\n drivers/net/ionic/ionic_rx_filter.c | 3 +--\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 43fa5f8bbf..36fb09b810 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1005,7 +1005,8 @@ eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params)\n \t/* Allocate memory for storing MAC addresses */\n \teth_dev->data->mac_addrs = rte_calloc(\"ionic\",\n \t\t\t\t\tadapter->max_mac_addrs,\n-\t\t\t\t\tRTE_ETHER_ADDR_LEN, 0);\n+\t\t\t\t\tRTE_ETHER_ADDR_LEN,\n+\t\t\t\t\tRTE_CACHE_LINE_SIZE);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tIONIC_PRINT(ERR, \"Failed to allocate %u bytes needed to \"\n \t\t\t\"store MAC addresses\",\n@@ -1083,7 +1084,7 @@ eth_ionic_dev_probe(void *bus_dev, struct rte_device *rte_dev,\n \t\tgoto err;\n \t}\n \n-\tadapter = rte_zmalloc(\"ionic\", sizeof(*adapter), 0);\n+\tadapter = rte_zmalloc(\"ionic\", sizeof(*adapter), RTE_CACHE_LINE_SIZE);\n \tif (!adapter) {\n \t\tIONIC_PRINT(ERR, \"OOM\");\n \t\terr = -ENOMEM;\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex fbeec8ef2e..cf9605c791 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -598,7 +598,8 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \t\ttotal_size += rte_mem_page_size();\n \t}\n \n-\tnew = rte_zmalloc(\"ionic\", struct_size, 0);\n+\tnew = rte_zmalloc_socket(\"ionic\", struct_size,\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!new) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate queue structure\");\n \t\treturn -ENOMEM;\n@@ -1037,17 +1038,19 @@ ionic_lif_alloc(struct ionic_lif *lif)\n \t\treturn -ENOMEM;\n \t}\n \n-\tlif->txqcqs = rte_calloc(\"ionic\",\n+\tlif->txqcqs = rte_calloc_socket(\"ionic\",\n \t\t\t\tadapter->max_ntxqs_per_lif,\n-\t\t\t\tsizeof(*lif->txqcqs), 0);\n+\t\t\t\tsizeof(*lif->txqcqs),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!lif->txqcqs) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate tx queues array\");\n \t\treturn -ENOMEM;\n \t}\n \n-\tlif->rxqcqs = rte_calloc(\"ionic\",\n+\tlif->rxqcqs = rte_calloc_socket(\"ionic\",\n \t\t\t\tadapter->max_nrxqs_per_lif,\n-\t\t\t\tsizeof(*lif->rxqcqs), 0);\n+\t\t\t\tsizeof(*lif->rxqcqs),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!lif->rxqcqs) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate rx queues array\");\n \t\treturn -ENOMEM;\ndiff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c\nindex fdedb9e288..5f9b569f64 100644\n--- a/drivers/net/ionic/ionic_rx_filter.c\n+++ b/drivers/net/ionic/ionic_rx_filter.c\n@@ -55,8 +55,7 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id,\n \tstruct ionic_rx_filter *f;\n \tuint32_t key;\n \n-\tf = rte_zmalloc(\"ionic\", sizeof(*f), 0);\n-\n+\tf = rte_zmalloc(\"ionic\", sizeof(*f), RTE_CACHE_LINE_SIZE);\n \tif (!f)\n \t\treturn -ENOMEM;\n \n", "prefixes": [ "30/35" ] }