Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117598/?format=api
{ "id": 117598, "url": "https://patches.dpdk.org/api/patches/117598/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-19-andrew.boyer@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007174336.54354-19-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007174336.54354-19-andrew.boyer@amd.com", "date": "2022-10-07T17:43:19", "name": "[18/35] net/ionic: do one-time init of receive descriptors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "65be6336a6dd52838b80ed050d97158e5fde80ce", "submitter": { "id": 2861, "url": "https://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-19-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25037, "url": "https://patches.dpdk.org/api/series/25037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25037", "date": "2022-10-07T17:43:01", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "https://patches.dpdk.org/series/25037/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117598/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 792F8A04FD;\n\tFri, 7 Oct 2022 19:46:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 559CA42BC8;\n\tFri, 7 Oct 2022 19:44:53 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45])\n by mails.dpdk.org (Postfix) with ESMTP id D283642684\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:44:51 +0200 (CEST)", "from MW4PR04CA0379.namprd04.prod.outlook.com (2603:10b6:303:81::24)\n by DM6PR12MB4387.namprd12.prod.outlook.com (2603:10b6:5:2ac::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct\n 2022 17:44:48 +0000", "from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:81:cafe::a6) by MW4PR04CA0379.outlook.office365.com\n (2603:10b6:303:81::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24 via Frontend\n Transport; Fri, 7 Oct 2022 17:44:48 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:48 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct\n 2022 12:44:47 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=O2T+F4SiZydozfxvCZ+fiOWQ0gK2Fnva72DSqSJiqnO2IYVe0/SCGlRBxdrlDZoL0T4Dd3tni02X5X4WZSxOESu7sfheS0glT73BWBuy2jpmnWktaBGzntqZYsN4msEgEwTCJ5odRiZU5eaz5NyD2bw7S5rvEuzQmaaMRxCQcxc1bVttDYMOoZdXoenl+RGo8VloEK6VmLHCbZPXhFLV3wEfpjUjKV8zJzQADphKy9+tHTXHWFlx/qS2HRWs9RFL6j2miWzKvizEULBRBiHd5AA0KRH7ohJXI6LKyKLn9IkC9ZNBA3acN0EBEaDjKX4tfcf+AuluLfiVzYTGqoAEdw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=0zbJ8OETcZL2YXjMs2URjDHyEnQijTUyw/o964mXprU=;\n b=d0Edp13veUHuGWn4Ps6ovs+h2MUKtFrB5qcdALM4Day8IWKnxEcZqKuIjLZN8tDY0FdVMJx3tRlQ7t6KcWKFpGmZMQJj5hKbNC3LVn5TmksqhlUk7qMAq5sNchzGBjiPdtagOiVu6BNB1qXMNRqakLlUZTmBTzxXFQrAFo9j0Nf/6BBZAWbnfNYVduMXiXOrqbP34JwpYTTGYAQt2M+uoO0R2G6lwnTKYr2LI83ldmanvaBSXRELY6h46PvJH9pFAdVueFfgMk+6qm/vJhAgu/sOVAssponjJZVrgYVxIVrUVC7byih/VADr+ToF3cWBZ4uFCre1wiqhbBo7UgSekQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0zbJ8OETcZL2YXjMs2URjDHyEnQijTUyw/o964mXprU=;\n b=LeArII9ds20C83kdgGiJiNteAWqhj0STnS3IvFJ2MaPCGiyd2y8gjm/ibvlTvBQ+VAghx9+5YusYcxhkBynaDN7xu3/l4JJNmtk8ll3ZOpDcUA7tsp+YB2mWbIXdy0mObaPtrtFzbfkj6BQhbcPxbIsCYqvf9E5DI68ckW3q+qE=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH 18/35] net/ionic: do one-time init of receive descriptors", "Date": "Fri, 7 Oct 2022 10:43:19 -0700", "Message-ID": "<20221007174336.54354-19-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221007174336.54354-1-andrew.boyer@amd.com>", "References": "<20221007174336.54354-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT050:EE_|DM6PR12MB4387:EE_", "X-MS-Office365-Filtering-Correlation-Id": "1f8269bc-dcb4-4734-3e5e-08daa88ba10e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +cFHuLJ+Sje7gXl0sSBB+Gzk5C6jGfAPXgickZI8Lc6wPO7TWsWfrb5q/gVOVVeneuNK7CIbWD2JQKg/XSIqG580K89hu/OpAPe/UGcPY4TpeMQLqc7IrNe/dR38igCvese+iW3EvOEonxFzoZlMd3qO/js6UxYxvHIDC8DoctlMuGlfiyh7S7e7ZWag+R0u2JTRcTJOzy1b0JdnhhRj9upRe0bpvXbwnsjDXKMIejswp/FC8RoJ5SZmV5CSfynMWck/47e4E66lB3hQY1WhNmkriHRG43/oI8gwu6bvfL0XaY1fh8yV9gFFR+63MRo/6H+Z5dLuFrA8N7ivnz7CZGnHTcY9JUG0JfC0KKwwDekgf82tDmGGqVP9HOxog22nVs5thEf+aiROsr9xq14By/0Xkp7cGtqS+OLi7wG6DraQNW6fmEJTIN92qm5OqigjSu6478pQBmXTlmRmNh3NDDLfNQuj5hPK/DurWc1n/eoAe8He4DV7KYS2y9N8YT5R2JMfBRMGxTdcCj1GpwTIuZWG+R1ylSLPkPa7WAwIzYIu0SLLnWqB3Kd3r4BFx3HNzfHV6ecm+47cx3IKK59iWiQAFnp8rKWJmHr0M9I3wOehQl6vHfEz6uNFO1hHO/UbLrCeD/KhWwdThMcdRavKEm6IzKJW9up2lJug78/aWcaOuRzg7vqzTZ95xGelR1eYaqCqTe0f6mqYJjhuBTi1L4GBuyJ6jACUhPh08lbpMAWQwgedIkyVOv5q/YWvsIBAk5Bh0EAvB5Jm2Oy9yhpdeqsygNi/2UJzZ+situenIAM=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(8936002)(44832011)(5660300002)(2906002)(41300700001)(81166007)(40480700001)(356005)(70206006)(2616005)(70586007)(6666004)(426003)(86362001)(26005)(4326008)(8676002)(82310400005)(40460700003)(82740400003)(1076003)(336012)(36860700001)(83380400001)(47076005)(478600001)(186003)(16526019)(316002)(6916009)(36756003)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Oct 2022 17:44:48.0769 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1f8269bc-dcb4-4734-3e5e-08daa88ba10e", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT050.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4387", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "These fields don't need to be set in the hot path.\nThis improves performance.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_rxtx.c | 38 ++++++++++++++++++++++++++++++----\n 1 file changed, 34 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 0c1cc842cf..2a34465e46 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -941,9 +941,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq)\n \t\tdesc = &desc_base[q->head_idx];\n \t\tdma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(rxm));\n \t\tdesc->addr = dma_addr;\n-\t\tdesc->len = rxq->hdr_seg_size;\n-\t\tdesc->opcode = (q->num_segs > 1) ? IONIC_RXQ_DESC_OPCODE_SG :\n-\t\t\tIONIC_RXQ_DESC_OPCODE_SIMPLE;\n \t\trxm->next = NULL;\n \n \t\tprev_rxm_seg = rxm;\n@@ -963,7 +960,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq)\n \t\t\tdata_iova = rte_mbuf_data_iova(rxm_seg);\n \t\t\tdma_addr = rte_cpu_to_le_64(data_iova);\n \t\t\telem->addr = dma_addr;\n-\t\t\telem->len = rxq->seg_size;\n \t\t\telem++;\n \n \t\t\trxm_seg->next = NULL;\n@@ -981,6 +977,38 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq)\n \treturn 0;\n }\n \n+/*\n+ * Perform one-time initialization of descriptor fields\n+ * which will not change for the life of the queue.\n+ */\n+static void __rte_cold\n+ionic_rx_init_descriptors(struct ionic_rx_qcq *rxq)\n+{\n+\tstruct ionic_queue *q = &rxq->qcq.q;\n+\tstruct ionic_rxq_desc *desc, *desc_base = q->base;\n+\tstruct ionic_rxq_sg_desc *sg_desc, *sg_desc_base = q->sg_base;\n+\tuint32_t i, j;\n+\tuint8_t opcode;\n+\n+\topcode = (q->num_segs > 1) ?\n+\t\tIONIC_RXQ_DESC_OPCODE_SG : IONIC_RXQ_DESC_OPCODE_SIMPLE;\n+\n+\t/*\n+\t * NB: Only the first segment needs to leave headroom (hdr_seg_size).\n+\t * Later segments (seg_size) do not.\n+\t */\n+\tfor (i = 0; i < q->num_descs; i++) {\n+\t\tdesc = &desc_base[i];\n+\t\tdesc->len = rte_cpu_to_le_16(rxq->hdr_seg_size);\n+\t\tdesc->opcode = opcode;\n+\n+\t\tsg_desc = &sg_desc_base[i];\n+\t\tfor (j = 0; j < q->num_segs - 1u; j++)\n+\t\t\tsg_desc->elems[j].len =\n+\t\t\t\trte_cpu_to_le_16(rxq->seg_size);\n+\t}\n+}\n+\n /*\n * Start Receive Units for specified queue.\n */\n@@ -1010,6 +1038,8 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n \tIONIC_PRINT(DEBUG, \"Starting RX queue %u, %u descs, size %u segs %u\",\n \t\trx_queue_id, q->num_descs, rxq->frame_size, q->num_segs);\n \n+\tionic_rx_init_descriptors(rxq);\n+\n \terr = ionic_lif_rxq_init(rxq);\n \tif (err)\n \t\treturn err;\n", "prefixes": [ "18/35" ] }