Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117295/?format=api
{ "id": 117295, "url": "https://patches.dpdk.org/api/patches/117295/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221004095132.198777-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221004095132.198777-2-david.marchand@redhat.com", "date": "2022-10-04T09:51:29", "name": "[v2,1/4] crypto/ccp: remove some printf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6039923b0ac6a2364f4065984bac371138af4b74", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221004095132.198777-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 24961, "url": "https://patches.dpdk.org/api/series/24961/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24961", "date": "2022-10-04T09:51:28", "name": "crypto/ccp cleanup", "version": 2, "mbox": "https://patches.dpdk.org/series/24961/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117295/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B131EA0543;\n\tTue, 4 Oct 2022 11:51:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A497242685;\n\tTue, 4 Oct 2022 11:51:53 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id D832540DDC\n for <dev@dpdk.org>; Tue, 4 Oct 2022 11:51:51 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-465-dNVGwF8vPIyGcKzjoL8DhA-1; Tue, 04 Oct 2022 05:51:47 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com\n [10.11.54.8])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B21F91C07544;\n Tue, 4 Oct 2022 09:51:46 +0000 (UTC)", "from localhost.localdomain (unknown [10.40.195.42])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9C35CC15BA4;\n Tue, 4 Oct 2022 09:51:45 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1664877111;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Hq9X973YpqwKfFDZ+JAxgM6jUH9gsoIi+s0znsUAPYQ=;\n b=EdGaHqCqKqwQfrCa4eV0/RKiAlR5c05frtaxxYrP1mfX+oBiHv6e1SWOCKjhd0dMwjFYTu\n gDXREQYZZy6TOeVWnkFcIYiSKL4te1Porv33AbvH83q96cwuX/W5dzjd69dCZROq4oCw+9\n cLFtcCM9ysQQEEOsEg/c5aNDwNb5RTs=", "X-MC-Unique": "dNVGwF8vPIyGcKzjoL8DhA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, sunilprakashrao.uttarwar@amd.com, stable@dpdk.org,\n Ravi Kumar <ravi1.kumar@amd.com>", "Subject": "[PATCH v2 1/4] crypto/ccp: remove some printf", "Date": "Tue, 4 Oct 2022 11:51:29 +0200", "Message-Id": "<20221004095132.198777-2-david.marchand@redhat.com>", "In-Reply-To": "<20221004095132.198777-1-david.marchand@redhat.com>", "References": "<20220909150411.3702860-1-david.marchand@redhat.com>\n <20221004095132.198777-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A DPDK application must _not_ use printf.\nUse log framework.\n\nFixes: ef4b04f87fa6 (\"crypto/ccp: support device init\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/crypto/ccp/ccp_dev.c | 4 ++--\n drivers/crypto/ccp/ccp_pci.c | 3 ++-\n drivers/crypto/ccp/rte_ccp_pmd.c | 2 +-\n 3 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c\nindex 424ead82c3..9c9cb81236 100644\n--- a/drivers/crypto/ccp/ccp_dev.c\n+++ b/drivers/crypto/ccp/ccp_dev.c\n@@ -362,7 +362,7 @@ ccp_find_lsb_regions(struct ccp_queue *cmd_q, uint64_t status)\n \t\tif (ccp_get_bit(&cmd_q->lsbmask, j))\n \t\t\tweight++;\n \n-\tprintf(\"Queue %d can access %d LSB regions of mask %lu\\n\",\n+\tCCP_LOG_DBG(\"Queue %d can access %d LSB regions of mask %lu\\n\",\n \t (int)cmd_q->id, weight, cmd_q->lsbmask);\n \n \treturn weight ? 0 : -EINVAL;\n@@ -709,7 +709,7 @@ ccp_probe_devices(struct rte_pci_device *pci_dev,\n \t\tsnprintf(dirname, sizeof(dirname), \"%s/%s\",\n \t\t\t SYSFS_PCI_DEVICES, d->d_name);\n \t\tif (is_ccp_device(dirname, ccp_id, &ccp_type)) {\n-\t\t\tprintf(\"CCP : Detected CCP device with ID = 0x%x\\n\",\n+\t\t\tCCP_LOG_DBG(\"CCP : Detected CCP device with ID = 0x%x\\n\",\n \t\t\t ccp_id[ccp_type].device_id);\n \t\t\tret = ccp_probe_device(ccp_type, pci_dev);\n \t\t\tif (ret == 0)\ndiff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c\nindex 38029a9081..c941e222c7 100644\n--- a/drivers/crypto/ccp/ccp_pci.c\n+++ b/drivers/crypto/ccp/ccp_pci.c\n@@ -11,6 +11,7 @@\n #include <rte_string_fns.h>\n \n #include \"ccp_pci.h\"\n+#include \"ccp_pmd_private.h\"\n \n static const char * const uio_module_names[] = {\n \t\"igb_uio\",\n@@ -41,7 +42,7 @@ ccp_check_pci_uio_module(void)\n \t\trewind(fp);\n \t}\n \tfclose(fp);\n-\tprintf(\"Insert igb_uio or uio_pci_generic kernel module(s)\");\n+\tCCP_LOG_DBG(\"Insert igb_uio or uio_pci_generic kernel module(s)\");\n \treturn -1;/* uio not inserted */\n }\n \ndiff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c\nindex 013f3be1e6..7338ef0ae8 100644\n--- a/drivers/crypto/ccp/rte_ccp_pmd.c\n+++ b/drivers/crypto/ccp/rte_ccp_pmd.c\n@@ -250,7 +250,7 @@ cryptodev_ccp_create(const char *name,\n \t\tgoto init_error;\n \t}\n \n-\tprintf(\"CCP : Crypto device count = %d\\n\", cryptodev_cnt);\n+\tCCP_LOG_DBG(\"CCP : Crypto device count = %d\\n\", cryptodev_cnt);\n \tdev->device = &pci_dev->device;\n \tdev->device->driver = &pci_drv->driver;\n \tdev->driver_id = ccp_cryptodev_driver_id;\n", "prefixes": [ "v2", "1/4" ] }