Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117203/?format=api
{ "id": 117203, "url": "https://patches.dpdk.org/api/patches/117203/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220930085302.317536-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930085302.317536-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930085302.317536-1-brian.dooley@intel.com", "date": "2022-09-30T08:53:02", "name": "[v4] examples/fips_validation: add parsing for AES CTR", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8d2d516e4e5b7c2db29529d2564e5851031397fe", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220930085302.317536-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 24930, "url": "https://patches.dpdk.org/api/series/24930/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24930", "date": "2022-09-30T08:53:02", "name": "[v4] examples/fips_validation: add parsing for AES CTR", "version": 4, "mbox": "https://patches.dpdk.org/series/24930/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117203/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/117203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 974CAA00C4;\n\tFri, 30 Sep 2022 10:53:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7AED840E5A;\n\tFri, 30 Sep 2022 10:53:11 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id EE5EE40684\n for <dev@dpdk.org>; Fri, 30 Sep 2022 10:53:09 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Sep 2022 01:53:08 -0700", "from silpixa00400883.ir.intel.com ([10.243.23.138])\n by fmsmga007.fm.intel.com with ESMTP; 30 Sep 2022 01:53:06 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1664527990; x=1696063990;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=PVJ8gZ2j5i+gYXZOgILDch9UOjv8+tWmhKh84yx1S9M=;\n b=AsStmDn6Eut2xjb7gEurha2SvBBQA6E6HgJrBUutagiYZBrNdZMu8dZK\n e4hs+l+ICr27G/fMgXTFogxOPERXIw0T29FZ0VDYNSVm5vdx8W70w5GDb\n lqPXEUb7p0UHyzV2+y1lgGYNBwe0XTunM/enmvThDXrgn7YRxTTbII5QU\n 6cTfIVhJ8OeDOe2E+YqE6h30GStwtI67efH7vUOcTAs9HckHmGRB2VZPg\n cbkXUIUqgmCLyOydDZ7VB+ZXIdQcLh5o9ThZBxruidhaOza34Oze3sv9b\n rmPuxKB4EDtOOhvH82rKIfcEJP4VN5AXv/vf1qPDkvM3Vsil2iLCmqe6D g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10485\"; a=\"300861325\"", "E=Sophos;i=\"5.93,357,1654585200\"; d=\"scan'208\";a=\"300861325\"", "E=McAfee;i=\"6500,9779,10485\"; a=\"624916540\"", "E=Sophos;i=\"5.93,357,1654585200\"; d=\"scan'208\";a=\"624916540\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Brian Dooley <brian.dooley@intel.com>", "Cc": "dev@dpdk.org, gmuthukrishn@marvell.com, gakhil@marvell.com,\n roy.fan.zhang@intel.com, kai.ji@intel.com", "Subject": "[PATCH v4] examples/fips_validation: add parsing for AES CTR", "Date": "Fri, 30 Sep 2022 08:53:02 +0000", "Message-Id": "<20220930085302.317536-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220916135355.324573-1-brian.dooley@intel.com>", "References": "<20220916135355.324573-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added functionality to parse algorithm for AES CTR test\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\nAcked-by: Kai Ji <kai.ji@intel.com>\nAcked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\nv2: fix clang warning for int-in-bool-context\n---\nv3: in reply to fix and patchwork CI\n---\nv4: missing acks\n---\n examples/fips_validation/fips_validation.c | 2 ++\n examples/fips_validation/fips_validation.h | 2 ++\n examples/fips_validation/fips_validation_aes.c | 5 +++++\n examples/fips_validation/main.c | 9 +++++++--\n 4 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c\nindex cd905b2c5b..016888fe7f 100644\n--- a/examples/fips_validation/fips_validation.c\n+++ b/examples/fips_validation/fips_validation.c\n@@ -468,6 +468,8 @@ fips_test_parse_one_json_vector_set(void)\n \t\tinfo.algo = FIPS_TEST_ALGO_AES_CBC;\n \telse if (strstr(algo_str, \"AES-XTS\"))\n \t\tinfo.algo = FIPS_TEST_ALGO_AES_XTS;\n+\telse if (strstr(algo_str, \"AES-CTR\"))\n+\t\tinfo.algo = FIPS_TEST_ALGO_AES_CTR;\n \telse if (strstr(algo_str, \"SHA\"))\n \t\tinfo.algo = FIPS_TEST_ALGO_SHA;\n \telse\ndiff --git a/examples/fips_validation/fips_validation.h b/examples/fips_validation/fips_validation.h\nindex 5c1abcbd91..96fdbec41a 100644\n--- a/examples/fips_validation/fips_validation.h\n+++ b/examples/fips_validation/fips_validation.h\n@@ -35,6 +35,7 @@\n enum fips_test_algorithms {\n \t\tFIPS_TEST_ALGO_AES = 0,\n \t\tFIPS_TEST_ALGO_AES_CBC,\n+\t\tFIPS_TEST_ALGO_AES_CTR,\n \t\tFIPS_TEST_ALGO_AES_GCM,\n \t\tFIPS_TEST_ALGO_AES_CMAC,\n \t\tFIPS_TEST_ALGO_AES_CCM,\n@@ -105,6 +106,7 @@ enum fips_aesavs_test_types {\n \tAESAVS_TYPE_MMT,\n \tAESAVS_TYPE_MCT,\n \tAESAVS_TYPE_AFT,\n+\tAESAVS_TYPE_CTR,\n };\n \n enum fips_tdes_test_types {\ndiff --git a/examples/fips_validation/fips_validation_aes.c b/examples/fips_validation/fips_validation_aes.c\nindex 4f61505bb3..0ef97aa03d 100644\n--- a/examples/fips_validation/fips_validation_aes.c\n+++ b/examples/fips_validation/fips_validation_aes.c\n@@ -30,8 +30,10 @@\n #define TESTTYPE_JSON_STR\t\"testType\"\n #define DIR_JSON_STR\t\t\"direction\"\n #define KEYLEN_JSON_STR\t\t\"keyLen\"\n+#define OVERFLOW_JSON_STR\t\"overflow\"\n \n #define KEY_JSON_STR\t\"key\"\n+#define PAYLOADLEN_JSON_STR\t\"payloadLen\"\n #define IV_JSON_STR\t\"iv\"\n #define PT_JSON_STR\t\"pt\"\n #define CT_JSON_STR\t\"ct\"\n@@ -52,6 +54,7 @@ struct {\n \t\t{AESAVS_TYPE_MMT, \"MMT\"},\n \t\t{AESAVS_TYPE_MCT, \"MCT\"},\n \t\t{AESAVS_TYPE_AFT, \"AFT\"},\n+\t\t{AESAVS_TYPE_CTR, \"CTR\"},\n };\n \n struct aes_test_algo {\n@@ -60,6 +63,7 @@ struct aes_test_algo {\n } const algo_con[] = {\n \t\t{\"CBC\", RTE_CRYPTO_CIPHER_AES_CBC},\n \t\t{\"ECB\", RTE_CRYPTO_CIPHER_AES_ECB},\n+\t\t{\"CTR\", RTE_CRYPTO_CIPHER_AES_CTR},\n };\n \n static int\n@@ -291,6 +295,7 @@ parse_test_aes_json_init(void)\n \tcase AESAVS_TYPE_MCT:\n \t\tinfo.parse_writeback = parse_test_aes_mct_json_writeback;\n \t\tbreak;\n+\tcase AESAVS_TYPE_CTR:\n \tcase AESAVS_TYPE_AFT:\n \t\tinfo.parse_writeback = parse_test_aes_json_writeback;\n \t\tbreak;\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex e6c0b6a3a1..6713fe0582 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -771,9 +771,11 @@ prepare_aes_xform(struct rte_crypto_sym_xform *xform)\n \tstruct rte_crypto_cipher_xform *cipher_xform = &xform->cipher;\n \n \txform->type = RTE_CRYPTO_SYM_XFORM_CIPHER;\n-\n \tif (info.interim_info.aes_data.cipher_algo == RTE_CRYPTO_CIPHER_AES_CBC)\n \t\tcipher_xform->algo = RTE_CRYPTO_CIPHER_AES_CBC;\n+\telse if (info.interim_info.aes_data.cipher_algo ==\n+\t\t\tRTE_CRYPTO_CIPHER_AES_CTR)\n+\t\tcipher_xform->algo = RTE_CRYPTO_CIPHER_AES_CTR;\n \telse\n \t\tcipher_xform->algo = RTE_CRYPTO_CIPHER_AES_ECB;\n \n@@ -782,7 +784,8 @@ prepare_aes_xform(struct rte_crypto_sym_xform *xform)\n \t\t\tRTE_CRYPTO_CIPHER_OP_DECRYPT;\n \tcipher_xform->key.data = vec.cipher_auth.key.val;\n \tcipher_xform->key.length = vec.cipher_auth.key.len;\n-\tif (cipher_xform->algo == RTE_CRYPTO_CIPHER_AES_CBC) {\n+\tif (cipher_xform->algo == RTE_CRYPTO_CIPHER_AES_CBC ||\n+\t\t\tcipher_xform->algo == RTE_CRYPTO_CIPHER_AES_CTR) {\n \t\tcipher_xform->iv.length = vec.iv.len;\n \t\tcipher_xform->iv.offset = IV_OFF;\n \t} else {\n@@ -1797,6 +1800,7 @@ init_test_ops(void)\n {\n \tswitch (info.algo) {\n \tcase FIPS_TEST_ALGO_AES_CBC:\n+\tcase FIPS_TEST_ALGO_AES_CTR:\n \tcase FIPS_TEST_ALGO_AES:\n \t\ttest_ops.prepare_op = prepare_cipher_op;\n \t\ttest_ops.prepare_xform = prepare_aes_xform;\n@@ -2008,6 +2012,7 @@ fips_test_one_test_group(void)\n \t\tret = parse_test_xts_json_init();\n \t\tbreak;\n \tcase FIPS_TEST_ALGO_AES_CBC:\n+\tcase FIPS_TEST_ALGO_AES_CTR:\n \tcase FIPS_TEST_ALGO_AES:\n \t\tret = parse_test_aes_json_init();\n \t\tbreak;\n", "prefixes": [ "v4" ] }