Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117185/?format=api
{ "id": 117185, "url": "https://patches.dpdk.org/api/patches/117185/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-11-liudongdong3@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930072220.20753-11-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-11-liudongdong3@huawei.com", "date": "2022-09-30T07:22:11", "name": "[10/19] net/hns3: fix header file self contained", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5fa7056b8f4c260f9db084f40ab2bd467aa50d06", "submitter": { "id": 2718, "url": "https://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-11-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24928, "url": "https://patches.dpdk.org/api/series/24928/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24928", "date": "2022-09-30T07:22:03", "name": "some bugfixes and clean code for hns3 - part2", "version": 1, "mbox": "https://patches.dpdk.org/series/24928/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117185/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58599A034C;\n\tFri, 30 Sep 2022 09:25:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5602C42BB1;\n\tFri, 30 Sep 2022 09:24:18 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 3F0AE42B8F;\n Fri, 30 Sep 2022 09:24:15 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mf1nS3xvQzHtjY;\n Fri, 30 Sep 2022 15:19:24 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:13 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 10/19] net/hns3: fix header file self contained", "Date": "Fri, 30 Sep 2022 15:22:11 +0800", "Message-ID": "<20220930072220.20753-11-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>", "References": "<20220930072220.20753-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nHeader files should be self contained and should not be cyclically\ndependent. This patch fixed it.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu <humin29@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_cmd.h | 3 +++\n drivers/net/hns3/hns3_common.c | 2 +-\n drivers/net/hns3/hns3_dcb.h | 4 ++++\n drivers/net/hns3/hns3_ethdev.c | 2 +-\n drivers/net/hns3/hns3_fdir.h | 5 +++++\n drivers/net/hns3/hns3_flow.h | 3 +++\n drivers/net/hns3/hns3_intr.c | 2 +-\n drivers/net/hns3/hns3_mbx.h | 4 ++++\n drivers/net/hns3/hns3_mp.h | 2 ++\n drivers/net/hns3/hns3_regs.h | 3 +++\n drivers/net/hns3/hns3_rss.h | 2 ++\n drivers/net/hns3/hns3_rxtx.c | 2 +-\n drivers/net/hns3/hns3_rxtx.h | 9 +++++++++\n drivers/net/hns3/hns3_stats.h | 5 +++++\n drivers/net/hns3/hns3_tm.h | 2 ++\n 15 files changed, 46 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h\nindex 82c999061d..bee96c1e46 100644\n--- a/drivers/net/hns3/hns3_cmd.h\n+++ b/drivers/net/hns3/hns3_cmd.h\n@@ -7,6 +7,9 @@\n \n #include <stdint.h>\n \n+#include <rte_byteorder.h>\n+#include <rte_spinlock.h>\n+\n #define HNS3_CMDQ_TX_TIMEOUT\t\t30000\n #define HNS3_CMDQ_CLEAR_WAIT_TIME\t200\n #define HNS3_CMDQ_RX_INVLD_B\t\t0\ndiff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c\nindex e732f68238..14291193cb 100644\n--- a/drivers/net/hns3/hns3_common.c\n+++ b/drivers/net/hns3/hns3_common.c\n@@ -7,10 +7,10 @@\n #include <ethdev_pci.h>\n #include <rte_pci.h>\n \n-#include \"hns3_common.h\"\n #include \"hns3_logs.h\"\n #include \"hns3_regs.h\"\n #include \"hns3_rxtx.h\"\n+#include \"hns3_common.h\"\n \n int\n hns3_fw_version_get(struct rte_eth_dev *eth_dev, char *fw_version,\ndiff --git a/drivers/net/hns3/hns3_dcb.h b/drivers/net/hns3/hns3_dcb.h\nindex e06ec177c8..9d9e7684c1 100644\n--- a/drivers/net/hns3/hns3_dcb.h\n+++ b/drivers/net/hns3/hns3_dcb.h\n@@ -7,7 +7,11 @@\n \n #include <stdint.h>\n \n+#include <ethdev_driver.h>\n+#include <rte_ethdev.h>\n+\n #include \"hns3_cmd.h\"\n+#include \"hns3_ethdev.h\"\n \n #define HNS3_ETHER_MAX_RATE\t\t100000\n \ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex a1348f93a7..60e933998a 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -6,7 +6,6 @@\n #include <bus_pci_driver.h>\n #include <ethdev_pci.h>\n \n-#include \"hns3_ethdev.h\"\n #include \"hns3_common.h\"\n #include \"hns3_dump.h\"\n #include \"hns3_logs.h\"\n@@ -16,6 +15,7 @@\n #include \"hns3_dcb.h\"\n #include \"hns3_mp.h\"\n #include \"hns3_flow.h\"\n+#include \"hns3_ethdev.h\"\n \n #define HNS3_SERVICE_INTERVAL\t\t1000000 /* us */\n #define HNS3_SERVICE_QUICK_INTERVAL\t10\ndiff --git a/drivers/net/hns3/hns3_fdir.h b/drivers/net/hns3/hns3_fdir.h\nindex d81f04a3f3..1a14f1eceb 100644\n--- a/drivers/net/hns3/hns3_fdir.h\n+++ b/drivers/net/hns3/hns3_fdir.h\n@@ -5,6 +5,10 @@\n #ifndef _HNS3_FDIR_H_\n #define _HNS3_FDIR_H_\n \n+#include <stdint.h>\n+\n+#include <rte_flow.h>\n+\n struct hns3_fd_key_cfg {\n \tuint8_t key_sel;\n \tuint8_t inner_sipv6_word_en;\n@@ -177,6 +181,7 @@ struct hns3_fdir_info {\n };\n \n struct hns3_adapter;\n+struct hns3_hw;\n \n int hns3_init_fd_config(struct hns3_adapter *hns);\n int hns3_fdir_filter_init(struct hns3_adapter *hns);\ndiff --git a/drivers/net/hns3/hns3_flow.h b/drivers/net/hns3/hns3_flow.h\nindex 854fbb7ff0..ec94510152 100644\n--- a/drivers/net/hns3/hns3_flow.h\n+++ b/drivers/net/hns3/hns3_flow.h\n@@ -6,6 +6,9 @@\n #define _HNS3_FLOW_H_\n \n #include <rte_flow.h>\n+#include <ethdev_driver.h>\n+\n+#include \"hns3_rss.h\"\n \n struct hns3_flow_counter {\n \tLIST_ENTRY(hns3_flow_counter) next; /* Pointer to the next counter. */\ndiff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c\nindex 4bdcd6070b..57679254ee 100644\n--- a/drivers/net/hns3/hns3_intr.c\n+++ b/drivers/net/hns3/hns3_intr.c\n@@ -10,9 +10,9 @@\n \n #include \"hns3_common.h\"\n #include \"hns3_logs.h\"\n-#include \"hns3_intr.h\"\n #include \"hns3_regs.h\"\n #include \"hns3_rxtx.h\"\n+#include \"hns3_intr.h\"\n \n #define SWITCH_CONTEXT_US\t10\n \ndiff --git a/drivers/net/hns3/hns3_mbx.h b/drivers/net/hns3/hns3_mbx.h\nindex 0172a2e288..97f704426c 100644\n--- a/drivers/net/hns3/hns3_mbx.h\n+++ b/drivers/net/hns3/hns3_mbx.h\n@@ -5,6 +5,10 @@\n #ifndef _HNS3_MBX_H_\n #define _HNS3_MBX_H_\n \n+#include <stdint.h>\n+\n+#include <rte_spinlock.h>\n+\n enum HNS3_MBX_OPCODE {\n \tHNS3_MBX_RESET = 0x01, /* (VF -> PF) assert reset */\n \tHNS3_MBX_ASSERTING_RESET, /* (PF -> VF) PF is asserting reset */\ndiff --git a/drivers/net/hns3/hns3_mp.h b/drivers/net/hns3/hns3_mp.h\nindex a74221d086..230230bbfe 100644\n--- a/drivers/net/hns3/hns3_mp.h\n+++ b/drivers/net/hns3/hns3_mp.h\n@@ -5,6 +5,8 @@\n #ifndef _HNS3_MP_H_\n #define _HNS3_MP_H_\n \n+#include <ethdev_driver.h>\n+\n /* Local data for primary or secondary process. */\n struct hns3_process_local_data {\n \tbool init_done; /* Process action register completed flag. */\ndiff --git a/drivers/net/hns3/hns3_regs.h b/drivers/net/hns3/hns3_regs.h\nindex 5812eb39db..2636429844 100644\n--- a/drivers/net/hns3/hns3_regs.h\n+++ b/drivers/net/hns3/hns3_regs.h\n@@ -5,6 +5,9 @@\n #ifndef _HNS3_REGS_H_\n #define _HNS3_REGS_H_\n \n+#include <ethdev_driver.h>\n+#include <rte_dev_info.h>\n+\n /* bar registers for cmdq */\n #define HNS3_CMDQ_TX_ADDR_L_REG\t\t0x27000\n #define HNS3_CMDQ_TX_ADDR_H_REG\t\t0x27004\ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex 1589c67c59..6cae5f8634 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -4,6 +4,7 @@\n \n #ifndef _HNS3_RSS_H_\n #define _HNS3_RSS_H_\n+\n #include <rte_ethdev.h>\n #include <rte_flow.h>\n \n@@ -91,6 +92,7 @@ static inline uint32_t roundup_pow_of_two(uint32_t x)\n extern const uint8_t hns3_hash_key[HNS3_RSS_KEY_SIZE];\n \n struct hns3_adapter;\n+struct hns3_hw;\n \n int hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_conf *rss_conf);\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 0a342ed9a2..f1163ce8a9 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -17,10 +17,10 @@\n #endif\n \n #include \"hns3_common.h\"\n-#include \"hns3_rxtx.h\"\n #include \"hns3_regs.h\"\n #include \"hns3_logs.h\"\n #include \"hns3_mp.h\"\n+#include \"hns3_rxtx.h\"\n \n #define HNS3_CFG_DESC_NUM(num)\t((num) / 8 - 1)\n #define HNS3_RX_RING_PREFETCTH_MASK\t3\ndiff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h\nindex 455f8b9419..f2d73043b7 100644\n--- a/drivers/net/hns3/hns3_rxtx.h\n+++ b/drivers/net/hns3/hns3_rxtx.h\n@@ -6,7 +6,16 @@\n #define _HNS3_RXTX_H_\n \n #include <stdint.h>\n+\n+#include <ethdev_driver.h>\n #include <rte_mbuf_core.h>\n+#include <rte_ethdev.h>\n+#include <rte_ethdev_core.h>\n+#include <rte_io.h>\n+#include <rte_mempool.h>\n+#include <rte_memzone.h>\n+\n+#include \"hns3_ethdev.h\"\n \n #define\tHNS3_MIN_RING_DESC\t64\n #define\tHNS3_MAX_RING_DESC\t32768\ndiff --git a/drivers/net/hns3/hns3_stats.h b/drivers/net/hns3/hns3_stats.h\nindex 9d84072205..9a360f8870 100644\n--- a/drivers/net/hns3/hns3_stats.h\n+++ b/drivers/net/hns3/hns3_stats.h\n@@ -5,6 +5,9 @@\n #ifndef _HNS3_STATS_H_\n #define _HNS3_STATS_H_\n \n+#include <ethdev_driver.h>\n+#include <rte_ethdev.h>\n+\n /* TQP stats */\n struct hns3_tqp_stats {\n \tuint64_t rcb_tx_ring_pktnum_rcd; /* Total num of transmitted packets */\n@@ -145,6 +148,8 @@ struct hns3_reset_stats;\n #define HNS3_IMISSED_STATS_FIELD_OFFSET(f) \\\n \t(offsetof(struct hns3_rx_missed_stats, f))\n \n+struct hns3_hw;\n+\n int hns3_stats_get(struct rte_eth_dev *eth_dev,\n \t\t struct rte_eth_stats *rte_stats);\n int hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\ndiff --git a/drivers/net/hns3/hns3_tm.h b/drivers/net/hns3/hns3_tm.h\nindex 83e9cc8ba9..47345eeed1 100644\n--- a/drivers/net/hns3/hns3_tm.h\n+++ b/drivers/net/hns3/hns3_tm.h\n@@ -105,6 +105,8 @@ hns3_tm_calc_node_tc_no(struct hns3_tm_conf *conf, uint32_t node_id)\n \t\treturn 0;\n }\n \n+struct hns3_hw;\n+\n void hns3_tm_conf_init(struct rte_eth_dev *dev);\n void hns3_tm_conf_uninit(struct rte_eth_dev *dev);\n int hns3_tm_ops_get(struct rte_eth_dev *dev __rte_unused, void *arg);\n", "prefixes": [ "10/19" ] }