Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117091/?format=api
{ "id": 117091, "url": "https://patches.dpdk.org/api/patches/117091/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220929032746.10659-3-zhangfei.gao@linaro.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220929032746.10659-3-zhangfei.gao@linaro.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220929032746.10659-3-zhangfei.gao@linaro.org", "date": "2022-09-29T03:27:42", "name": "[v3,2/6] crypto/uadk: support basic operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0655282dda918fc55a577a7f8740c686aa7a9fb4", "submitter": { "id": 2701, "url": "https://patches.dpdk.org/api/people/2701/?format=api", "name": "Zhangfei Gao", "email": "zhangfei.gao@linaro.org" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220929032746.10659-3-zhangfei.gao@linaro.org/mbox/", "series": [ { "id": 24894, "url": "https://patches.dpdk.org/api/series/24894/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24894", "date": "2022-09-29T03:27:40", "name": "crypto/uadk: introduce uadk crypto driver", "version": 3, "mbox": "https://patches.dpdk.org/series/24894/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117091/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117091/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 645A8A00C4;\n\tThu, 29 Sep 2022 05:28:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 29F37427EC;\n\tThu, 29 Sep 2022 05:28:12 +0200 (CEST)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id A437340DDC\n for <dev@dpdk.org>; Thu, 29 Sep 2022 05:28:10 +0200 (CEST)", "by mail-pj1-f44.google.com with SMTP id\n bu5-20020a17090aee4500b00202e9ca2182so4716828pjb.0\n for <dev@dpdk.org>; Wed, 28 Sep 2022 20:28:10 -0700 (PDT)", "from localhost.localdomain ([45.128.198.71])\n by smtp.gmail.com with ESMTPSA id\n gn4-20020a17090ac78400b001fd66d5c42csm2304271pjb.49.2022.09.28.20.28.05\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 28 Sep 2022 20:28:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date;\n bh=fuxP8SNKLk9uy5vKU7Ew3ZeGmHM/TT3KtV1xfFhOJC0=;\n b=utjeymQqBHjKjZ40puPNMmAUwhbB/8tQkkGjXgjfoZ+VTbTLwVm2DFkMU7fRg/E+QH\n k35kRuGJ7A5LBoN9yluxHxIyLa3iWvE1AnkI4SJS30/JnImUJNlhUFJqjlhoXvq6/ySI\n As1GQG8LNWLk/BEfApYEDE9n6/cD0xztvls8rCRlwhlGYoLcTYP1cO76vSja5DwfLSZP\n +DV6bx5ZyO+FswQKhGEcFyKC7jOsSeTFivqcbIQESDIyMFxPaqF+ZBaU5OL5rrEJq9Cw\n GtHVacrnvSUwtTnapOf5Qo17jawFMR2uDRhkbReUT9bOgt0t5UrGed/mO2hRwPTLNOrI\n mhDQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date;\n bh=fuxP8SNKLk9uy5vKU7Ew3ZeGmHM/TT3KtV1xfFhOJC0=;\n b=lj6lF9GSEBSiZjLbwnsiFpZD9HL1PCbe3NuBwuc6VjoBKjmXLd1qL7xhxKJ3hivOvf\n xm62ApO/4jbfCH+zZgBI/Q2HUoG6Y3OjnlM7AtSanHRDvRSUOtIM21ACWlSSCSF5kApX\n N53ApOYOVm46qGxVK15yhFUGaLQ1ta21MoXe4p4c2L18jnWnoUK0ByHwpGuntqtjCtkx\n rADHQ250xJDmZGSg1X+C4JlINNTo7DWcOfStHYK7an8NHQsIGgyuYTQUOG8A3BXTK7ER\n EJbuSDIuli1ZY92LPpNV3U3ROpWp4uQuJanius6+60evH91zyZ6fYU/+XbxOsQpHR3pz\n Xwow==", "X-Gm-Message-State": "ACrzQf0G4JP20WGyfWqvHupO2SKOVTUJKSiLQ8F8bqIADDTkVSbujerg\n FnrI7XwIsEjqhDnjj1ZRRA2QSQ==", "X-Google-Smtp-Source": "\n AMsMyM4MZKidEJCfywQKym1vxb+rlgbwFSp4QQ6L3/h428LvCxX/22Gt5xPTzBEinDlIFuStoeJfFg==", "X-Received": "by 2002:a17:90b:4b4c:b0:203:1eef:d810 with SMTP id\n mi12-20020a17090b4b4c00b002031eefd810mr14186287pjb.75.1664422089909;\n Wed, 28 Sep 2022 20:28:09 -0700 (PDT)", "From": "Zhangfei Gao <zhangfei.gao@linaro.org>", "To": "Akhil Goyal <gakhil@marvell.com>,\n Declan Doherty <declan.doherty@intel.com>,\n Fan Zhang <roy.fan.zhang@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Ray Kinsella <mdr@ashroe.eu>", "Cc": "dev@dpdk.org,\n\tacc@openeuler.org,\n\tZhangfei Gao <zhangfei.gao@linaro.org>", "Subject": "[PATCH v3 2/6] crypto/uadk: support basic operations", "Date": "Thu, 29 Sep 2022 11:27:42 +0800", "Message-Id": "<20220929032746.10659-3-zhangfei.gao@linaro.org>", "X-Mailer": "git-send-email 2.36.1", "In-Reply-To": "<20220929032746.10659-1-zhangfei.gao@linaro.org>", "References": "<20220929032746.10659-1-zhangfei.gao@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Support the basic dev control operations: configure, close, start,\nstop and get info, as well as queue pairs operations.\n\nSigned-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>\n---\n drivers/crypto/uadk/uadk_crypto_pmd.c | 213 ++++++++++++++++++++++++--\n 1 file changed, 204 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c\nindex 5c2e6d8f40..d6d9f26337 100644\n--- a/drivers/crypto/uadk/uadk_crypto_pmd.c\n+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c\n@@ -10,6 +10,25 @@\n #include <uadk/wd_digest.h>\n #include <uadk/wd_sched.h>\n \n+/* Maximum length for digest (SHA-512 needs 64 bytes) */\n+#define DIGEST_LENGTH_MAX 64\n+\n+struct uadk_qp {\n+\t/* Ring for placing process packets */\n+\tstruct rte_ring *processed_pkts;\n+\t/* Queue pair statistics */\n+\tstruct rte_cryptodev_stats qp_stats;\n+\t/* Queue Pair Identifier */\n+\tuint16_t id;\n+\t/* Unique Queue Pair Name */\n+\tchar name[RTE_CRYPTODEV_NAME_MAX_LEN];\n+\t/* Buffer used to store the digest generated\n+\t * by the driver when verifying a digest provided\n+\t * by the user (using authentication verify operation)\n+\t */\n+\tuint8_t temp_digest[DIGEST_LENGTH_MAX];\n+} __rte_cache_aligned;\n+\n enum uadk_crypto_version {\n \tUADK_CRYPTO_V2,\n \tUADK_CRYPTO_V3,\n@@ -28,16 +47,192 @@ RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);\n \t\t\"%s() line %u: \" fmt \"\\n\", __func__, __LINE__, \\\n \t\t## __VA_ARGS__)\n \n+static const struct rte_cryptodev_capabilities uadk_crypto_v2_capabilities[] = {\n+\t/* End of capabilities */\n+\tRTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()\n+};\n+\n+/* Configure device */\n+static int\n+uadk_crypto_pmd_config(struct rte_cryptodev *dev __rte_unused,\n+\t\t struct rte_cryptodev_config *config __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+/* Start device */\n+static int\n+uadk_crypto_pmd_start(struct rte_cryptodev *dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+/* Stop device */\n+static void\n+uadk_crypto_pmd_stop(struct rte_cryptodev *dev __rte_unused)\n+{\n+}\n+\n+/* Close device */\n+static int\n+uadk_crypto_pmd_close(struct rte_cryptodev *dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+/* Get device statistics */\n+static void\n+uadk_crypto_pmd_stats_get(struct rte_cryptodev *dev,\n+\t\t\t struct rte_cryptodev_stats *stats)\n+{\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tstruct uadk_qp *qp = dev->data->queue_pairs[qp_id];\n+\n+\t\tstats->enqueued_count += qp->qp_stats.enqueued_count;\n+\t\tstats->dequeued_count += qp->qp_stats.dequeued_count;\n+\t\tstats->enqueue_err_count += qp->qp_stats.enqueue_err_count;\n+\t\tstats->dequeue_err_count += qp->qp_stats.dequeue_err_count;\n+\t}\n+}\n+\n+/* Reset device statistics */\n+static void\n+uadk_crypto_pmd_stats_reset(struct rte_cryptodev *dev __rte_unused)\n+{\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tstruct uadk_qp *qp = dev->data->queue_pairs[qp_id];\n+\n+\t\tmemset(&qp->qp_stats, 0, sizeof(qp->qp_stats));\n+\t}\n+}\n+\n+/* Get device info */\n+static void\n+uadk_crypto_pmd_info_get(struct rte_cryptodev *dev,\n+\t\t\t struct rte_cryptodev_info *dev_info)\n+{\n+\tstruct uadk_crypto_priv *priv = dev->data->dev_private;\n+\n+\tif (dev_info != NULL) {\n+\t\tdev_info->driver_id = dev->driver_id;\n+\t\tdev_info->driver_name = dev->device->driver->name;\n+\t\tdev_info->max_nb_queue_pairs = 128;\n+\t\t/* No limit of number of sessions */\n+\t\tdev_info->sym.max_nb_sessions = 0;\n+\t\tdev_info->feature_flags = dev->feature_flags;\n+\n+\t\tif (priv->version == UADK_CRYPTO_V2)\n+\t\t\tdev_info->capabilities = uadk_crypto_v2_capabilities;\n+\t}\n+}\n+\n+/* Release queue pair */\n+static int\n+uadk_crypto_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)\n+{\n+\tstruct uadk_qp *qp = dev->data->queue_pairs[qp_id];\n+\n+\tif (qp) {\n+\t\trte_ring_free(qp->processed_pkts);\n+\t\trte_free(qp);\n+\t\tdev->data->queue_pairs[qp_id] = NULL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/* set a unique name for the queue pair based on its name, dev_id and qp_id */\n+static int\n+uadk_pmd_qp_set_unique_name(struct rte_cryptodev *dev,\n+\t\t\t struct uadk_qp *qp)\n+{\n+\tunsigned int n = snprintf(qp->name, sizeof(qp->name),\n+\t\t\t\t \"uadk_crypto_pmd_%u_qp_%u\",\n+\t\t\t\t dev->data->dev_id, qp->id);\n+\n+\tif (n >= sizeof(qp->name))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n+/* Create a ring to place process packets on */\n+static struct rte_ring *\n+uadk_pmd_qp_create_processed_pkts_ring(struct uadk_qp *qp,\n+\t\t\t\t unsigned int ring_size, int socket_id)\n+{\n+\tstruct rte_ring *r = qp->processed_pkts;\n+\n+\tif (r) {\n+\t\tif (rte_ring_get_size(r) >= ring_size) {\n+\t\t\tUADK_LOG(INFO, \"Reusing existing ring %s for processed packets\",\n+\t\t\t\t qp->name);\n+\t\t\treturn r;\n+\t\t}\n+\n+\t\tUADK_LOG(ERR, \"Unable to reuse existing ring %s for processed packets\",\n+\t\t\t qp->name);\n+\t\treturn NULL;\n+\t}\n+\n+\treturn rte_ring_create(qp->name, ring_size, socket_id,\n+\t\t\t RING_F_EXACT_SZ);\n+}\n+\n+static int\n+uadk_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n+\t\t\t const struct rte_cryptodev_qp_conf *qp_conf,\n+\t\t\t int socket_id)\n+{\n+\tstruct uadk_qp *qp;\n+\n+\t/* Free memory prior to re-allocation if needed. */\n+\tif (dev->data->queue_pairs[qp_id] != NULL)\n+\t\tuadk_crypto_pmd_qp_release(dev, qp_id);\n+\n+\t/* Allocate the queue pair data structure. */\n+\tqp = rte_zmalloc_socket(\"uadk PMD Queue Pair\", sizeof(*qp),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n+\tif (qp == NULL)\n+\t\treturn (-ENOMEM);\n+\n+\tqp->id = qp_id;\n+\tdev->data->queue_pairs[qp_id] = qp;\n+\n+\tif (uadk_pmd_qp_set_unique_name(dev, qp))\n+\t\tgoto qp_setup_cleanup;\n+\n+\tqp->processed_pkts = uadk_pmd_qp_create_processed_pkts_ring(qp,\n+\t\t\t\tqp_conf->nb_descriptors, socket_id);\n+\tif (qp->processed_pkts == NULL)\n+\t\tgoto qp_setup_cleanup;\n+\n+\tmemset(&qp->qp_stats, 0, sizeof(qp->qp_stats));\n+\n+\treturn 0;\n+\n+qp_setup_cleanup:\n+\tif (qp) {\n+\t\trte_free(qp);\n+\t\tqp = NULL;\n+\t}\n+\treturn -EINVAL;\n+}\n+\n static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {\n-\t\t.dev_configure\t\t= NULL,\n-\t\t.dev_start\t\t= NULL,\n-\t\t.dev_stop\t\t= NULL,\n-\t\t.dev_close\t\t= NULL,\n-\t\t.stats_get\t\t= NULL,\n-\t\t.stats_reset\t\t= NULL,\n-\t\t.dev_infos_get\t\t= NULL,\n-\t\t.queue_pair_setup\t= NULL,\n-\t\t.queue_pair_release\t= NULL,\n+\t\t.dev_configure\t\t= uadk_crypto_pmd_config,\n+\t\t.dev_start\t\t= uadk_crypto_pmd_start,\n+\t\t.dev_stop\t\t= uadk_crypto_pmd_stop,\n+\t\t.dev_close\t\t= uadk_crypto_pmd_close,\n+\t\t.stats_get\t\t= uadk_crypto_pmd_stats_get,\n+\t\t.stats_reset\t\t= uadk_crypto_pmd_stats_reset,\n+\t\t.dev_infos_get\t\t= uadk_crypto_pmd_info_get,\n+\t\t.queue_pair_setup\t= uadk_crypto_pmd_qp_setup,\n+\t\t.queue_pair_release\t= uadk_crypto_pmd_qp_release,\n \t\t.sym_session_get_size\t= NULL,\n \t\t.sym_session_configure\t= NULL,\n \t\t.sym_session_clear\t= NULL,\n", "prefixes": [ "v3", "2/6" ] }